From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91587C53200 for ; Wed, 29 Jul 2026 15:23:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uxAawK0krQhU1JdrYbRxXBvsWT/VL+JMubOqhc452Us=; b=ql4NFk91CuvbBk YMyVPzrpPKV6v2PlRTIuMRPiCetRv3O7WIP1oKSqU+eY3JtNZX8pcWC0vcf76MBOCCTRzO6SerBxm +SiQCGtH+H5Mpp9U+ykdEN8PFqH4ZofQnd+3NIiXSTyPej2fDalNaCa9/YVhq/jtMmtJ9WPY1NLWd OyI+CBOIQiRpYOR7jg8jIQX2Guj90jeWt8qeadJ8CokDfjwkWZxJkRJpPkG+nUsR9YCvVIbrA1Z6J we4z81zMgg3xizB6+UBbsC2kFJCMdrBLlFbFVEfoANyqa5eMdjz3j8W48yWzPAlhZcpPMTlb68n06 aO0LACBo90Pf8gwgJdMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wp67s-00000008O21-23Js; Wed, 29 Jul 2026 15:23:20 +0000 Received: from extorris.mess.org ([92.243.27.206]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wp67p-00000008NzX-2pEJ; Wed, 29 Jul 2026 15:23:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mess.org; s=2020; t=1785338594; bh=DtSRpaDqclNo6U2QeRpHGIfjJQ060yIsBqj5BnAVUds=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kRZ8KGAOL6EqVgxyRAdfiAx/PJNUqZgOafokziLGPQwBEjxQDCkoEz7Cd0SfZPC7J Rvm9LwFzvIvdSTpUxq5s0U82Hd9iufuxQd/JHFSP0aG8MQa+1+zueHZ/4UVqoyW3jl uIHTqIdPx2ojbJWSZxE387+0Hnb0ZTqo95wA/6uagMoUHX+xqJEdWnnp6KD7vX/hcw 27K+o7qe4u4GQm1CW6ILHtjM+vMDbr56koTRsDs1jgJp5nBJGgPrRFdKUbObNhHPBt xgzmnZPx+IoPlZTOcg2lxdtDviuNTBBeE5zQRG/RIx9cqRLK7Hnid0LT5L7kNtw4XO as4CvZ0GgzuKA== Received: by extorris.mess.org (Postfix, from userid 1004) id 8734D4253C; Wed, 29 Jul 2026 16:23:14 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mess.org; s=2020; t=1785338593; bh=DtSRpaDqclNo6U2QeRpHGIfjJQ060yIsBqj5BnAVUds=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lKUuARmW0Vn7htby5uV2rHilrxDdlmglNPpjFcciCvKE0sDFwL24CQGjPWcgGDnQg VYtNPwuAdaOxzMadtz4G7gQ2hYcOFE+StrRtpE7eeduvzY40xAkpoeTTMxTBTqvr14 rIdhE2Oko0L6gSgV1MwiggWxtceIW+Zw+B64AdHH7FGkSU+V8tiJCF6FmbwqivQs0Y 51jBvjP4YHuG9ldRxn+J9VHOSq23Rd7ZwqUNBleaXHdja+rE0auN05fGCEQkndmoek J3oY0ITRGM1q82pxpUJktIJxOaRXFQZuygrudxWQEYuyYOPst6AE+QQRmf8zIpub2t HldXKq00paMJQ== Received: from maru.local (unknown [62.232.99.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by extorris.mess.org (Postfix) with ESMTPSA id 071BF4252C; Wed, 29 Jul 2026 16:23:13 +0100 (BST) From: Sean Young To: linux-media@vger.kernel.org, Sean Young , Mauro Carvalho Chehab , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Viktor Prutyanov Cc: stable@vger.kernel.org, Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 07/15] media: meson-ir-tx: Ensure clock is disabled on unbind Date: Wed, 29 Jul 2026 16:22:45 +0100 Message-ID: <0a0066a531aedbcb18620cac5897cb91c78a5188.1785338381.git.sean@mess.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260729_082317_850637_9A43DED3 X-CRM114-Status: GOOD ( 13.02 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org clk_prepare_enable() needs a call to clk_disable_unprepare() on driver unbind. Make it devm managed. Fixes: 49be1c78d575 ("media: rc: introduce Meson IR TX driver") Signed-off-by: Sean Young Reviewed-by: Martin Blumenstingl Cc: stable@vger.kernel.org --- drivers/media/rc/meson-ir-tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/rc/meson-ir-tx.c b/drivers/media/rc/meson-ir-tx.c index fded2c256f2a..e7bb107e6a84 100644 --- a/drivers/media/rc/meson-ir-tx.c +++ b/drivers/media/rc/meson-ir-tx.c @@ -288,8 +288,8 @@ static int meson_irtx_mod_clock_probe(struct meson_irtx *ir, if (!np) return -ENODEV; - clock = devm_clk_get(ir->dev, "xtal"); - if (IS_ERR(clock) || clk_prepare_enable(clock)) + clock = devm_clk_get_enabled(ir->dev, "xtal"); + if (IS_ERR(clock)) return -ENODEV; *clk_nr = IRB_MOD_XTAL3_CLK; -- 2.55.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic