mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 01/12] i2c: meson: use min instead of min_t where min_t isn't needed
Date: Wed, 08 Mar 2017 10:25:57 +0100	[thread overview]
Message-ID: <1488965157.2514.10.camel@baylibre.com> (raw)
In-Reply-To: <c1a3b573-bb03-059a-ee7a-77903d2aebfe@gmail.com>

On Wed, 2017-03-08 at 07:42 +0100, Heiner Kallweit wrote:
> Use min instead of min_t where min_t isn't needed.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> ?drivers/i2c/busses/i2c-meson.c | 10 +++++-----
> ?1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-
> meson.c
> index 73b97c71..40e5da9a 100644
> --- a/drivers/i2c/busses/i2c-meson.c
> +++ b/drivers/i2c/busses/i2c-meson.c
> @@ -156,10 +156,10 @@ static void meson_i2c_get_data(struct meson_i2c
> *i2c, char *buf, int len)
> ?	dev_dbg(i2c->dev, "%s: data %08x %08x len %d\n", __func__,
> ?		rdata0, rdata1, len);
> ?
> -	for (i = 0; i < min_t(int, 4, len); i++)
> +	for (i = 0; i < min(4, len); i++)
> ?		*buf++ = (rdata0 >> i * 8) & 0xff;
> ?
> -	for (i = 4; i < min_t(int, 8, len); i++)
> +	for (i = 4; i < min(8, len); i++)
> ?		*buf++ = (rdata1 >> (i - 4) * 8) & 0xff;
> ?}
> ?
> @@ -168,10 +168,10 @@ static void meson_i2c_put_data(struct meson_i2c
> *i2c, char *buf, int len)
> ?	u32 wdata0 = 0, wdata1 = 0;
> ?	int i;
> ?
> -	for (i = 0; i < min_t(int, 4, len); i++)
> +	for (i = 0; i < min(4, len); i++)
> ?		wdata0 |= *buf++ << (i * 8);
> ?
> -	for (i = 4; i < min_t(int, 8, len); i++)
> +	for (i = 4; i < min(8, len); i++)
> ?		wdata1 |= *buf++ << ((i - 4) * 8);
> ?
> ?	writel(wdata0, i2c->regs + REG_TOK_WDATA0);
> @@ -186,7 +186,7 @@ static void meson_i2c_prepare_xfer(struct
> meson_i2c *i2c)
> ?	bool write = !(i2c->msg->flags & I2C_M_RD);
> ?	int i;
> ?
> -	i2c->count = min_t(int, i2c->msg->len - i2c->pos, 8);
> +	i2c->count = min(i2c->msg->len - i2c->pos, 8);
> ?
> ?	for (i = 0; i < i2c->count - 1; i++)
> ?		meson_i2c_add_token(i2c, TOKEN_DATA);

Since the second argument of min is always a constant, this patch does
not change anything, but it doesn't hurt either. I suppose it is OK

  reply	other threads:[~2017-03-08  9:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08  6:41 [PATCH 00/12] i2c: meson: series with improvements Heiner Kallweit
2017-03-08  6:42 ` [PATCH 01/12] i2c: meson: use min instead of min_t where min_t isn't needed Heiner Kallweit
2017-03-08  9:25   ` Jerome Brunet [this message]
2017-03-08  6:43 ` [PATCH 02/12] i2c: meson: remove member irq from struct meson_i2c Heiner Kallweit
2017-03-08  9:07   ` Jerome Brunet
2017-03-08  6:44 ` [PATCH 03/12] i2c: meson: use i2c core for DT clock-frequency parsing Heiner Kallweit
2017-03-08  9:10   ` Jerome Brunet
2017-03-08  6:44 ` [PATCH 04/12] i2c: meson: use full 12 bits for clock divider Heiner Kallweit
2017-03-08  9:19   ` Jerome Brunet
2017-03-08  6:45 ` [PATCH 05/12] i2c: meson: set clock divider in probe instead of setting it for each transfer Heiner Kallweit
2017-03-08  6:46 ` [PATCH 06/12] i2c: meson: remove variable count from meson_i2c_xfer Heiner Kallweit
2017-03-08  9:28   ` Jerome Brunet
2017-03-08  6:47 ` [PATCH 07/12] i2c: meson: improve interrupt handler and detect spurious interrupts Heiner Kallweit
2017-03-08  9:50   ` Jerome Brunet
2017-03-08 21:02     ` Heiner Kallweit
2017-03-09 20:16       ` Heiner Kallweit
2017-03-08  6:47 ` [PATCH 08/12] i2c: meson: explicitly ignore messages with length zero Heiner Kallweit
     [not found]   ` <CANe6Qb9nKdLnOcwEwuk8NXEB+fxW2S_kkzP+U+qygYhNqz0Y0w@mail.gmail.com>
2017-03-08 22:03     ` Heiner Kallweit
2017-03-08  6:48 ` [PATCH 09/12] i2c: meson: don't create separate token chain just for the stop command Heiner Kallweit
2017-03-08  6:49 ` [PATCH 10/12] i2c: meson: remove meson_i2c_write_tokens Heiner Kallweit
2017-03-08  6:49 ` [PATCH 11/12] i2c: meson: improve and simplify interrupt handler Heiner Kallweit
2017-03-08  6:50 ` [PATCH 12/12] i2c: meson: use state in meson_i2c_prepare_xfer Heiner Kallweit
2017-03-08  9:34 ` [PATCH 00/12] i2c: meson: series with improvements Jerome Brunet
2017-03-08 20:49   ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488965157.2514.10.camel@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®