Re: [PATCH v4 4/7] ASoC: meson: add AUDIN driver

[Jerome Brunet <jbrunet@baylibre.com>]

On Thu 01 Oct 2026 at 16:23, sashiko-bot@kernel.org wrote:


>> diff --git a/sound/soc/meson/audin.c b/sound/soc/meson/audin.c
>> new file mode 100644
>> index 0000000000000..808e7d4fd31a2
>> --- /dev/null
>> +++ b/sound/soc/meson/audin.c
> [ ... ]
>> +static const struct regmap_config audin_regmap_cfg = {
>> +	.reg_bits	= 32,
>> +	.val_bits	= 32,
>> +	.reg_stride	= 4,
>> +	.max_register	= 0x148,
>> +};
>
> [Severity: Medium]
> Will hardware state like the channel mask and endianness be lost across
> system suspend and resume cycles?

It is a good question but I'd consider this a pre-existing issue, if it
is one.

Amlogic audio drivers have seen very little testing, if any, when it
comes to suspend/resume, because the suspend support from the platforms
them self was very limited too. I have no idea if the situation has
improved lately but the subject is definitely not limited to this driver.

IOW, the issue might exist (or not) but I do not think it should be a
blocking point ATM.

>
> ALSA calls the driver's prepare() callback to recover a suspended stream,
> but not hw_params(). Because this regmap lacks a cache configuration, it
> cannot automatically restore the register state configured during hw_params()
> when the system resumes.
>
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20261001-audin-v4-0-2476646118b5@baylibre.com?part=4
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

-- 
Jerome

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic