From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2406FC79FAA for ; Tue, 8 Sep 2026 14:59:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VS/UhXQ3/8e7QcLGpd3MVIEzjykCoxmfvcuXs/8T4sE=; b=ksAPt5KYkauTbi 0rrW5lRJJoMMUH+RsqtOqfGR/WPska8X8LkpuQ4cwOiI4NZ/QxyaLI13da92eTLkvVJQa6wugbCNS mSqBieZy6aNmDv9/dkJOpw+h+laZiDUDqZ6Dy4XjQpWfxQsNHMvLiIWek7wzVHPOxhz/3NxzUZFYX UQZJvYoXheLzeDU0P5pHrHNPAImzLYQlO8yHKcSAS9UoMbRjdmgjUBIr1YrPvg8f7uvcZoxiopzDU Jqot7VHG2CBOK+luwsIxdfs3DkpQLXtzXSbUVNFlFc+WrGHidhE7ZjWIsBFk43FuGmFwva5N92K+k NP/ouY5VmeCayBP8BZXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3xHp-00000009N97-02Hx; Tue, 08 Sep 2026 14:59:01 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3xHG-00000009MaG-46OL for linux-amlogic@bombadil.infradead.org; Tue, 08 Sep 2026 14:58:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=1jTusoWpqoD9KCpjJ6MCY4jjjsYt3moPnSbDwm2nlw4=; b=HJwq3nplRUFrCDpuMkiVd+OKWR erumMMCpXXVkmWNyO4/d3Y764XNHc7FdUMDGBD/OhekDdOMA05uXWVEhCUKdGyJs7nqN0pKmNG1FU r6vBd7r8seHXVFpthUKJH6mzG0wJITzp9B+mATKq+Ez0E6+K4TuVBtEC4+fTFq5PaQI1Em3fME58Q xHO/TABnOCGbFc+4mUO9k6GeeaNzHjsV+cebBMRKRtBqJtk1H2y7svnzSVv4ht1nhprxEf1ArAej+ 6uEvmJX2SFOTXmBQTgchi8sl8vbFYwB7bfzKKn9AHIFkE5zHPHHhoCeBfslRn8/kYj8MOASycVvbw LL/KcGVQ==; Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1x3xHC-0000000HZdP-2YjK for linux-amlogic@lists.infradead.org; Tue, 08 Sep 2026 14:58:24 +0000 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 688Ej0bx230062 for ; Tue, 8 Sep 2026 14:58:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1jTusoWpqoD9KCpjJ6MCY4jjjsYt3moPnSbDwm2nlw4=; b=owMTvjhep613AUYi 4aYU2+30nMpcnpwJO5Rfep6JNhv4IcadNAWpS6ouRx4yDyrjf7QjLPv7rEyeTgqR pkL9wP2yLl90OATvPstL1HAn7ND2AjnYh8YVosI2nkop3fIrIcop4eT/L3x3qHsr QZlfcaHDLqpY9Oq5HSqTJpt56roGtDoNLtaqlZPZP/FFrSW14C4l/0XdUzpbE5LI fzNtGi01D9R+FypsogxfPd8wqyoiLwxOWXAyZAOqCZA8OJKo6KgtN2qs5HI68FI8 JW3OVZyhHFM3zBBvDXvMVzSCiQg8dyEm41TgMo1wm51Z+SNp5lshyAEsq2/X0+zb el0aSQ== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gjb0pakkc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 14:58:20 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-78d25a8ff32so288182137.2 for ; Tue, 08 Sep 2026 07:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788879500; x=1789484300; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1jTusoWpqoD9KCpjJ6MCY4jjjsYt3moPnSbDwm2nlw4=; b=DMsxPtuE3DarJD21ug1ReS1H/g1irKpM3hpuoBPC/gADvHQz89MqYuTC2/GuK5jCdB 9Xlnod1dYyhUR9N/VDUP3ABBqJCMwcPCivSrW6EYTr5SyI4i3UldeaC7+1DdUZYkPWZx 5M0uzFqT0hA7ceA6silKPr0m8YMSQ8D5IKDKim91Izzkh5WWDZV8YPfxfdsGGvdByseL qEBbd/satjFnZZVfNTfU5qG4xkwaaQuNz8fzpPe7llYJuIB/9gxj0GZ6rSE1kASL4ph9 cX00afRg55AViZhbLJH4iwIbHGB7xk4FhNJxRMUiYjHrG976+ZBiFoXLDbcxV2fHPcv0 H9IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788879500; x=1789484300; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1jTusoWpqoD9KCpjJ6MCY4jjjsYt3moPnSbDwm2nlw4=; b=YLN11fOp7BUk1//3Qnu6H7UMMOJFnM+Y5/dgxFmaCzbltxEd3A5hr8wDOeGZ5pM7Hd jCiebPyU9Xs3mNPvuoCzWrerqXB1cM9G2Qz+9JMI9WM9K42ijcrEloTX9fYLWC7LvTIE Eb2p8u46Je1cYe1rtQaaz9Azj/SXfdR/ZT9HXOEu/10WFj+4PfMGxUbeE/r6vZjO6Ox1 SplNj54/ilJ972Efm2kCBpZbH+YjSyi4UKy9LbcrrcyQltlYFIn4qRG5n+FRK1hR+dwX 6LtPRewX2hMEyg+MGTZPhbSLi81bEN0yTJeltITflam8KLBJoHXuq+ngLhKc783HJGZ2 ox8g== X-Forwarded-Encrypted: i=1; AKwUvBx84sxnaZRAndXIfrzM898YBsMTqo2XrjMdvA5CgHlB4ZfOgvZ3CKm63aItr7acrOhpLMoT2vaCrAe1Vz24@lists.infradead.org X-Gm-Message-State: AFuF++mFIyW3wpoUfZtZAJroZP4S5yV99z+7KXhOcG94zEEK2dgnqcUh w80zfXf0viOQ/m+RV1pDCuirxq+rccIn73lbKAepvUMkGk/kUl/98JxclO3PlDn87uQmxGcBsLW reLVQEtiZSf8qbVP7fbsf5lpcGt6WCbaiMF0nxNbbaEh7GfqflvVioYHfB41kLgBxZsfr6VyaEg == X-Gm-Gg: AYBFou32EJlq/obMiCZrS/5vlhfgTF18KBbJ9PPJU4184Av0sVTX5yh1xNhagNHnXEj noTwcjNixz6qJ7WoyCGu81yTGGE9C3t9k6KnCvyUZfGWMPJh/3lZYpR5u0sfMilA+MXw8YZgxXE Nhl5daa3atA9mi8Sy9xr/NOgJdiGhsQ9/fBgPyt0SezibUDBRWejTgI1aHCgA7YEIQpBSfdgPzy Pqq3nlx8fEeJ7Bst1BzViRmnBoaChTzrQhj68b8XNExlm4N0gNaNdmXCCL8df9c3ZtuQxl/RMte Vvo6AqxaAQWD/8qYS0qzQ97r1IeRn6DX0a8xpOn615lFC/rwLgoJV82WzCjmH6AMdYFleTXSFwv YGOK+MWXm7vCGvldRaIz+/PdE8Tke X-Received: by 2002:a05:6102:2ac4:b0:778:30ee:f44b with SMTP id ada2fe7eead31-78a4ab31a99mr9637207137.13.1788879499724; Tue, 08 Sep 2026 07:58:19 -0700 (PDT) X-Received: by 2002:a05:6102:2ac4:b0:778:30ee:f44b with SMTP id ada2fe7eead31-78a4ab31a99mr9637151137.13.1788879499260; Tue, 08 Sep 2026 07:58:19 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:79a2:f118:df09:fe51]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-485958f1493sm25191276f8f.37.2026.09.08.07.58.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 07:58:18 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Sep 2026 16:57:26 +0200 Subject: [PATCH net-next v14 07/10] net: stmmac: qcom-ethqos: fix SGMII loopback not set on resume after speed change MIME-Version: 1.0 Message-Id: <20260908-qcom-sa8255p-emac-v14-7-ec212b747a7d@oss.qualcomm.com> References: <20260908-qcom-sa8255p-emac-v14-0-ec212b747a7d@oss.qualcomm.com> In-Reply-To: <20260908-qcom-sa8255p-emac-v14-0-ec212b747a7d@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Mohd Ayaan Anwar , Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Radu Rendec Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, brgl@kernel.org, Bartosz Golaszewski , Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1420; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=M/9Buofcj2PjilwTJ9Q1IxG9YNjNHQfn3EQa0/hj4g8=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqoCJtPEfTx4lMAuscmYS50twwqIkudyRPZJ+SL 07thj6YQuGJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaqAibQAKCRAFnS7L/zaE w7QzD/4wAkPdm1bk0HVl/ZJF/wSwT+FFKyLR7R6zsVVdqSLVbG98nFldIWBBhPCoHhWaa/nKYQ7 ghiB/rKnjn1NjO607l+C6hKGRIjHhhIQeFTmfH6tkPTUDMYkoj5tNCLhclHbnI47ZcdcDGwFHQH DstjQXudubsIwU81fFgL54Mi6jMYquXGdb233Q6PBWFa7wNd5tnmhtYDwA60Ko43AHhHUJLMA+Y +t8bRqMav1PwRLp9XW6yLafq5BA3uW+VwmeciVdQHu3hIjWaOKOgzjdpcqRXpwyV7ptfQ3PdXdS LvJcTgA9f+1yXNRI0yCdULY+M4Iseb2LqdMy0XCWpnetbRvSjzJEH2OCR3Eu0siJfUwGVZmmlMF HjcMDh1hJuQwJ7Ej+iVTYo3K3KfTB81LP6BtA2WdDxvGSZSDKICJuAuK4z+hdtX3Ozrbsr0vx1D D+sRfyd1DP/QwVh0aGfKZmcUWS/zk5Tb/ZUJFx84TvCDXGRgH0tzsyT5elumuHqG1eDYa5GNtcS cTAGeh/iUjkMo61N5mshpV+kqCyOpFPh9RWH342EmuMli3GbOhyBCiWA3HD6Kun0XJSxeV4KsVO Gz7t4kA9KKjWTOBIGV3ASkOeawOEoSYwCODprNyTMVYyHIqN4Vh9SqwGDUauxzjecZQ9rWXBLTI iIAtQtTgM4Fw7hw== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-ORIG-GUID: oSNvrlJM7Y_tTMNb5JzNxrsniekxlZ0r X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDE2MSBTYWx0ZWRfX5Zpzc3Cnvjdr T/ES7UvYrgW884LmdXZHwaSvPlhr8k7f8h43/vWZ0wKp1pbqG2HZLEpE7qa+Cs6IgSLQIwSeIx2 ssjngl5uiPJXMaLnCB75lHq7Le11fxA= X-Authority-Analysis: v=2.4 cv=HL3z0Itv c=1 sm=1 tr=0 ts=6aa0228c cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=PjAGQVefHaMtIuCO3vkA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-GUID: oSNvrlJM7Y_tTMNb5JzNxrsniekxlZ0r X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDE2MSBTYWx0ZWRfX1P55LRpq9FH0 jNhwOQqwy4hGGnKFjfTcnoBAilZzWM9xUE8mC1k9jqxtWtXpqSr34fL8Wavm0AsRISS8kM1dKZE AT/mldxPU76n8uV3nlWEjmIxlk9cJ/N+NAet+McX9jJve9BYOFenNGqtJj8U83gLy1FlDZ5hZWa vaEzlkpJe6lZoBHg4mmaM9JSkOO3g+Gj7XJCdO+kBj2Aw6ghIraKCwyWkyp4RNzTWmkWrHIoFf8 kU2OnK43HfWHW3fFt1pVvH75s37tS0HZH3HqmtQBa9ZtQD4UlPdlxZsGsIuoj9RgpyKU6+K/nzH +ZflywCfLVGo0O/3wi+P7A/abHZDuOqPcAbQr3jMj33ECBMCqYmxawZcUtn1Zkvy/7ZjhtANxas a4fmiC8qPNiwMAsrAn+b+2/nHdHGswKFBL2fKE9OiYlu32nS0OPMPRIhPY6uvo/UXVXOCNKOneE LpeBYksnLUPE/+BcMJw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 suspectscore=0 impostorscore=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080161 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260908_155823_119885_34984732 X-CRM114-Status: GOOD ( 15.19 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The loopback in the MAC wrapper feeds the TX clock back into the RX path, while the SerDes is being powered up. Without it, dwmac4_dma_reset() polls a clock that never toggles and times out. qcom_ethqos_set_sgmii_loopback() gates this on phy_mode being 2500BASEX. mac_finish() now updates phy_mode to the runtime-resolved interface, any subsequent resume with a 1G SGMII link skips the loopback setup and the DMA reset hangs. Extend the guard to include PHY_INTERFACE_MODE_SGMII. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index fd7414a50eb4e7d4d5adad7e93d49a55500c7f32..e067ceee016217c49d3b3d572fd9f33e562d1a75 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -190,7 +190,8 @@ static void qcom_ethqos_set_sgmii_loopback(struct qcom_ethqos *ethqos, bool enable) { if (!ethqos->needs_sgmii_loopback || - ethqos->phy_mode != PHY_INTERFACE_MODE_2500BASEX) + (ethqos->phy_mode != PHY_INTERFACE_MODE_2500BASEX && + ethqos->phy_mode != PHY_INTERFACE_MODE_SGMII)) return; rgmii_updatel(ethqos, -- 2.47.3 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic