Re: [PATCH 1/6] dt-bindings: sound: amlogic: add schemas for audin components

[Krzysztof Kozlowski <krzk@kernel.org>]

On Sat, Sep 12, 2026 at 12:14:31AM +0200, Valerio Setti wrote:
> Add schemas for "amlogic,meson-gx-audin" and "amlogic,meson-gx-audin-fifo".
> They provide I2S audio input support to the Meson GX platforms (GXBB/GXL).
> 

A nit, subject: drop second/last, redundant "schemas for". The
"dt-bindings" prefix is already stating that these are bindings so
schemas.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23

OTOH, subject prefix is incorrect.

Please use subject prefixes matching the subsystem. You can get them for
example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> Signed-off-by: Valerio Setti <vsetti@baylibre.com>
> ---
>  .../sound/amlogic,meson-gx-audin-fifo.yaml         | 52 ++++++++++++
>  .../bindings/sound/amlogic,meson-gx-audin.yaml     | 96 ++++++++++++++++++++++
>  2 files changed, 148 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/amlogic,meson-gx-audin-fifo.yaml b/Documentation/devicetree/bindings/sound/amlogic,meson-gx-audin-fifo.yaml
> new file mode 100644
> index 000000000000..a01fe22b9786
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/amlogic,meson-gx-audin-fifo.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/amlogic,meson-gx-audin-fifo.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic GX AUDIN FIFO controller
> +
> +maintainers:
> +  - Valerio Setti <vsetti@baylibre.com>
> +
> +description: |-

Drop |-

> +  AUDIN FIFO receives audio data from backend interfaces (ex: I2S, SPDIF),
> +  stores them into a FIFO in a configurable way and then bulk copies all the
> +  data in RAM when the FIFO is full.
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  $nodename:
> +    pattern: "^audio-controller@[0-9a-f]+$"
> +
> +  compatible:
> +    items:
> +      - enum:
> +          - amlogic,meson-gxbb-audin-fifo
> +          - amlogic,meson-gxl-audin-fifo
> +      - const: amlogic,meson-gx-audin-fifo
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#sound-dai-cells":
> +    const: 0
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#sound-dai-cells"
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    audio-controller@80 {
> +      compatible = "amlogic,meson-gxbb-audin-fifo",
> +                   "amlogic,meson-gx-audin-fifo";

What sort of Spc is amlogic,meson-gx? git grep gives me zero (and family
names are not allowed, see writing bindings).

> +      reg = <0x80 0x1c>;

Are you sure a few registers are a separate device? No other resources
here and this is child of audin, so really does not look like a
separate device.


Best regards,
Krzysztof


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic