From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C63F8C98318 for ; Thu, 24 Sep 2026 16:35:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kloljwXkA14R9wP+IOuyOtTjjyTpF73VTkZ8e7HGGb0=; b=Zu88l4IOwsQoEeZ1AZPmYIKsMp 6+yK8s7rQhW54UZKE0G76C8W6cmc3z68JlLGaPCY6ktvRanTR2b/+wx2vhXfn5VtbvqheCkXvRWgu i6Pspu3doDTorhlNKucIWrr8NcJnRp0a9hJoMd1AildpztIEUcOeBMIwtwPKFTMY184No9RyouPXV 9ZNj2M2mMxiSHIHUUTRIsM++p/khOCLXghO0jPhhLv1ZkVhRZNOUTXKIH90m2etwRBsmD8b6wyWYO qTKJHjqhzpBl6G4L7sMcYjgBM9/TUFsjrUSgF//0rbrSeo80u3lIXvg2Mp69Gl48EHIRh6fgJ/csg LjWNgo0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9mPl-0000000Bc4Z-2XzS; Thu, 24 Sep 2026 16:35:17 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9mPk-0000000Bc4L-3BE1; Thu, 24 Sep 2026 16:35:16 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id D54BB601DE; Thu, 24 Sep 2026 16:35:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCC8D1F00893; Thu, 24 Sep 2026 16:35:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790267715; bh=uoAmk3wqtlAFZLLsvBCYCQm3vEyTOG8AHswxcziVCCI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=krgJkDjSbVkzY9W1gQBRw6y5foA5Kp9V4FZ62zmtf4P9B2qV+hCn2agi/dvhvyvc1 RstWYFaXlmNgNSowtUS4whXUuSIo62BXJfUEUnyjKirdlkd0+1nq4iLnPDMi/BO2Md s5yVyQlfJGr8UKi+FWqsiA46ch2VAL+R1kDZ3B3xsoLSyIRsU1LkEsrYNKykrS3Hp7 LqBVM40MlI04fNBqyDzsAT8jnB6E4rLzeamaBj7v7KMm6n2yYaxuWxiQDXj3vTGYCA 2vhOuotbVQUDj+P6wSXsEddyx2MI93uWyKFFQLuPlNZbzSIo+/iYSv+kF4jdg8kTFr Vpva06qLTldUg== Date: Thu, 24 Sep 2026 17:35:10 +0100 From: Conor Dooley To: linux-kernel-dev@aliel.fr Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiner Kallweit , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH 1/3] dt-bindings: pwm: amlogic: Add core clock for T7 Message-ID: <20260924-reprimand-taste-3481319d9e31@spud> References: <20260924-add-t7-sys-pwm-clk-v1-0-05b91e87f0a9@aliel.fr> <20260924-add-t7-sys-pwm-clk-v1-1-05b91e87f0a9@aliel.fr> MIME-Version: 1.0 In-Reply-To: <20260924-add-t7-sys-pwm-clk-v1-1-05b91e87f0a9@aliel.fr> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0005056865745924720==" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org --===============0005056865745924720== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YEpPhNbtW+Xfzqe4" Content-Disposition: inline --YEpPhNbtW+Xfzqe4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 24, 2026 at 05:14:28PM +0200, Ronald Claveau via B4 Relay wrote: > From: Ronald Claveau >=20 > The T7 PWM controller has a system clock (the register access clock) > in addition to the two input clocks of channels A and B. Add it as a > third clock, named "core", for the amlogic,t7-pwm compatible, and > require clock-names for this SoC for clarity. What additional clarity does that actually bring? I think it's kinda less clear, because the git history is required to explain why drivers cannot fetch the existing clocks by name. >=20 > The other compatibles are left unchanged. Add an example showing the > T7 usage with its fallback to amlogic,meson-s4-pwm. >=20 > Signed-off-by: Ronald Claveau > --- > .../devicetree/bindings/pwm/pwm-amlogic.yaml | 37 ++++++++++++++++= +++--- > 1 file changed, 33 insertions(+), 4 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Doc= umentation/devicetree/bindings/pwm/pwm-amlogic.yaml > index c337d85da40f1..9212a40d9fe48 100644 > --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > @@ -62,7 +62,7 @@ properties: > =20 > clock-names: > minItems: 1 > - maxItems: 2 > + maxItems: 3 > =20 > power-domains: > maxItems: 1 > @@ -135,17 +135,38 @@ allOf: > properties: > compatible: > contains: > - enum: > - - amlogic,meson-s4-pwm > + const: amlogic,t7-pwm > then: > properties: > clocks: > items: > - description: input clock of PWM channel A > - description: input clock of PWM channel B > - clock-names: false > + - description: gate clock for the PWM controller > + clock-names: > + items: > + - const: clk_a > + - const: clk_b I'd rather "channel-a" or similar, we try not to state the obvious in the names of clocks etc - of course this is a clock! > + - const: core > required: > - clocks > + - clock-names > + else: > + if: > + properties: > + compatible: > + contains: > + enum: > + - amlogic,meson-s4-pwm > + then: > + properties: > + clocks: > + items: > + - description: input clock of PWM channel A > + - description: input clock of PWM channel B > + clock-names: false Are you sure that the s4-pwm doesn't also have this core clock? Seems likely, no? Cheers, Conor. > + required: > + - clocks > =20 > - if: > properties: > @@ -182,3 +203,11 @@ examples: > clocks =3D <&pwm_src_a>, <&pwm_src_b>; > #pwm-cells =3D <3>; > }; > + - | > + pwm@60000 { > + compatible =3D "amlogic,t7-pwm", "amlogic,meson-s4-pwm"; > + reg =3D <0x60000 0x24>; > + clocks =3D <&clk_a>, <&clk_b>, <&core>; > + clock-names =3D "clk_a", "clk_b", "core"; > + #pwm-cells =3D <3>; > + }; >=20 > --=20 > 2.49.0 >=20 >=20 --YEpPhNbtW+Xfzqe4 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCarVRPgAKCRB4tDGHoIJi 0qrvAQDzOljDwun39UgsyfijL72uq4IJ63XXhGMQL7O1stwipwEA12NojbsOpKfq H2MqdB9c+5gUZXemfAGmrG9+Hcf8lwo= =NsG0 -----END PGP SIGNATURE----- --YEpPhNbtW+Xfzqe4-- --===============0005056865745924720== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============0005056865745924720==--