mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: linux-kernel-dev@aliel.fr
To: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	Conor Dooley <conor.dooley@microchip.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Andi Shyti <andi.shyti@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Beniamino Galvani <b.galvani@gmail.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v8 0/8] Add VIM4 MCU/FAN support
Date: Tue, 4 Aug 2026 10:30:24 +0200	[thread overview]
Message-ID: <42363af0-a2af-4f8b-8ad2-834539c979b0@aliel.fr> (raw)
In-Reply-To: <713c728a-f68f-41fa-a64b-09ccecef9157@oss.qualcomm.com>

On 7/8/26 3:42 PM, Daniel Lezcano wrote:
> On 7/2/26 11:55, Ronald Claveau via B4 Relay wrote:
>> The Khadas VIM4 board features a different MCU variant compared to
>> previous VIM boards.
>> While it shares the same I2C-based communication model,
>> it differs in some ways:
>>
>>    - A distinct register map with its own volatile/writeable register set
>>    - A fan control with 0–100 levels instead of the 0–3 levels previously
> 
> That means for a eg. 100 ms polling, the first one takes 10s to reach
> the max speed, while the second takes 300ms, right ?
> 

Sorry for the delay.
Yes I defined levels 30-100 in the DT as the MCU register description
stated that:
`Note: the parameter value of fan normally open is 0x1E~0x64`

I didn't find any issue with the stress test, but I will address your
concern with a smaller list.

>>    - A fan power supply gated through a regulator
>>
>> This series adds support for this new variant by:
>>
>>    1. Refactoring the khadas-mcu MFD driver to use per-variant data
>>       structures (regmap config, cells, fan platform data),
>>       and adding the khadas,vim4-mcu compatible string.
>>
>>    2. Extending the fan thermal driver to retrieve the fan register
>>       and maximum level from platform_data,
>>       and to optionally manage a power regulator for the fan supply.
> 
> Through which tree do you expect patch 5/8 to go ?
> 

MFD seems a good candidate as this patch depends on it.

-- 
Best regards,
Ronald

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2026-08-04  8:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02  9:55 Ronald Claveau via B4 Relay
2026-07-02  9:55 ` [PATCH v8 1/8] dt-bindings: mfd: khadas: Add new compatible for Khadas VIM4 MCU Ronald Claveau via B4 Relay
2026-07-02  9:55 ` [PATCH v8 2/8] dt-bindings: i2c: amlogic: Add compatible for T7 SOC Ronald Claveau via B4 Relay
2026-07-02  9:55 ` [PATCH v8 3/8] mfd: khadas-mcu: Add per-variant configuration infrastructure and VIM4 support Ronald Claveau via B4 Relay
2026-07-02  9:55 ` [PATCH v8 4/8] mfd: khadas-mcu: Add support for VIM4 MCU variant Ronald Claveau via B4 Relay
2026-07-23 15:48   ` Lee Jones
2026-08-04  8:54     ` linux-kernel-dev
2026-07-02  9:55 ` [PATCH v8 5/8] thermal: khadas-mcu-fan: Add fan config from platform data Add regulator support Ronald Claveau via B4 Relay
2026-07-02  9:55 ` [PATCH v8 6/8] arm64: dts: amlogic: t7: Add i2c pinctrl node Ronald Claveau via B4 Relay
2026-07-02  9:56 ` [PATCH v8 7/8] arm64: dts: amlogic: t7: Add i2c controller node Ronald Claveau via B4 Relay
2026-07-07 19:43   ` Martin Blumenstingl
2026-07-02  9:56 ` [PATCH v8 8/8] arm64: dts: amlogic: t7: khadas-vim4: Add i2c MCU fan node Ronald Claveau via B4 Relay
2026-07-07 19:44   ` Martin Blumenstingl
2026-07-08 13:42 ` [PATCH v8 0/8] Add VIM4 MCU/FAN support Daniel Lezcano
2026-08-04  8:30   ` linux-kernel-dev [this message]
2026-07-16 15:24 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42363af0-a2af-4f8b-8ad2-834539c979b0@aliel.fr \
    --to=linux-kernel-dev@aliel.fr \
    --cc=andi.shyti@kernel.org \
    --cc=b.galvani@gmail.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=daniel.lezcano@kernel.org \
    --cc=daniel.lezcano@oss.qualcomm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®