From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 604D9CD4851 for ; Tue, 19 May 2026 07:33:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/as93H5AXWaEkz4kPV7ecJw4DuFIiayKUKZM6y3na4M=; b=ft60IIBpH3PUoVs5ut/aOYl9iE 6vIjo6Cr4yQduNa/tCsXJ9Ct+L2qo8nsa0btcBLPwSzzliKaFyy/V6LOgp0yqdS2bL87WyGTgBz5A HThGMxjUfP2yLykwiEXyiWpXYNteQXYZ6eHVQKVLDATUYMqcyYs6fcvbMGE7hb5OfpQN5gANFjbc7 l7wdoQRSSfPoq0hN0U298LL0sR5dFlXx3c/hFojSVfLH7RcM/8dSAsXVaoWdYBMaOxzTG/Qw+rHuS Mc2CftJE8ktGUuSThN8XJs8N0thRALgd+SoavYmV3ux1WxEz4gY/szsbyEqg9BI/rw49cQxtRYDNE s9FL38yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPExE-00000000Vxg-0EXb; Tue, 19 May 2026 07:33:28 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPExB-00000000Vvx-1LJ9 for linux-amlogic@lists.infradead.org; Tue, 19 May 2026 07:33:27 +0000 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4891b0786beso22310235e9.1 for ; Tue, 19 May 2026 00:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779176003; x=1779780803; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=CptfMWX/OnKpQAZK1ljSyYDr+otcGVWKuHyIusA7+I4=; b=UqeDWTtyLT88yGGCyyIWWibMKHBrzrXzm/9kwhHdlIw27bVbt1JnVJNrOpGGiGHIQR HAfw1BEvF6SR85W+wJMDQzqi5yza7QFB0oBP3q5q9r3eYQl4NkRAWV1gMEFYp26xseUs VAzEkRZMv6JukWzFhkRuPsosoJISep4e0+hIdxcAI4tdkwW6kmIkXHiugzYTf0ZWVpPX 5xEJJfHuk+bLOIt5P9LyW+S057Wdoy6elseaS+tvLmNv816s31toSbVX/oTYlcvcNKPq zYE00zElTGCU8dPNi8Q4b+vBpjIqwoXTfkvmHfU2B5yMdYjyIvjEVgIZFXKjVJHS8cAC GV/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779176003; x=1779780803; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CptfMWX/OnKpQAZK1ljSyYDr+otcGVWKuHyIusA7+I4=; b=oRqn4B7myHh9wrodiv2MQl4RlxqfDBSeKeXBMQKVMAHhMTvZRBJjuyEwXuISk4R0Bg eI9eOaslyF7Ygcr0cTvgrlDiRUeGzfLlYiVW7CAb+XWqmunryWkx8irSytENl/HwMUI4 oYM75Qnk0UNmsHb9CQk2HSve51bkeQ6F9sIqBND3NaWZ4VECPvK+AckgB73AuFLkrWN9 IFBZazFUnxLB892GMV+jcpN7A/Qs7YDZm7rot+4faTU2kesDpU0hN4bNMt3GvtjeDuif qgsNDibtj/CAyfV9m0wF/mAVjGWz90B4glHKiU2+4zHduitx1IgAruKMRIskotRB/g6X rQyA== X-Forwarded-Encrypted: i=1; AFNElJ9QqpUhksQFWsfhpmRslqrz8dD/9FmHMIUXBxVugPuJiTY/pBV5sZMgVrbJ7rG9DfxdAjFytobKrZe9C9yD@lists.infradead.org X-Gm-Message-State: AOJu0YwmLt/RkZbAYj7kfw7eJ/PS/PWmr2xYxmDoeEs408dpJp6ewoPw fQ1QokwkDIsLwyMF2zzim91HvA3zvDZikrAhtDRd10ZLIACy+LeHbZzfhyvxZbJuLGc= X-Gm-Gg: Acq92OGjxgpZlzp4uNdC9Wf+ctMwabMh3Srq3x6It/pTq9NisTkC2LXx8hiiy7RFvYf ZA4M5l8p4OE7KbdTjgNp3G4r7R7ps5C1o/Sy/nL3F4eqfgHvQtUvBrfncaRIAXFRQCrsuQ39zSK TLfFSEJkg23bCK5QgSnM2/o4BWJgurkULcrnpVEhT/lx4HFFBlL9aCp/lRPyp7jJsPvy6EblkuS 5c3Q5WqPB308Q6qswnSwMpjF5NxVtshoj/812mpOEPWeN6W+NtZaTsdKDOdrFWMtB+iYcvqZCfJ UyRDdawL7wZVUnbAI99I6Q8St0djo0il4rGwF7O7P25IKSzlbp2H7sthKhnv6aClIuO+EknJk5i 1tJfcYfHtZconbXwihdQfu8zuOVFDGqJh7zRr/nKGbe7pCWqshhmlSarvkK6EA/kx45fw4Z2xzp Ut+t601cyP8+x3e6UsIyWGClzdAA6nk2+oL7hoqGuDCBtFtt5/RruqOO63krpWH6CugDgdqN4L/ xRs X-Received: by 2002:a05:600c:a406:b0:48a:9540:1a3a with SMTP id 5b1f17b1804b1-48fe60e56abmr233108995e9.8.1779176003502; Tue, 19 May 2026 00:33:23 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:1d4b:274c:94d:a69f? ([2a01:e0a:106d:1080:1d4b:274c:94d:a69f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe537ccf5sm301918365e9.14.2026.05.19.00.33.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 00:33:23 -0700 (PDT) Message-ID: <59760925-a19d-460e-afc9-015dd210f193@linaro.org> Date: Tue, 19 May 2026 09:33:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH 09/13] drm/meson: dw-hdmi: Use devm_clk_get_enabled() helper To: Jonas Karlman , Kevin Hilman , Heiko Stuebner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerome Brunet , Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20260518194744.2483580-1-jonas@kwiboo.se> <20260518194744.2483580-10-jonas@kwiboo.se> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260518194744.2483580-10-jonas@kwiboo.se> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260519_003325_381553_3D152AD7 X-CRM114-Status: GOOD ( 16.44 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 5/18/26 21:47, Jonas Karlman wrote: > Change to use the devm_clk_get_enabled() helper instead of using an > open-coded variant. > > Signed-off-by: Jonas Karlman > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 48 +++++++++------------------ > 1 file changed, 16 insertions(+), 32 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c > index fcd2426af9fc..d0cf2042d41c 100644 > --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c > @@ -634,29 +634,6 @@ static void meson_dw_hdmi_init(struct meson_dw_hdmi *meson_dw_hdmi) > > } > > -static void meson_disable_clk(void *data) > -{ > - clk_disable_unprepare(data); > -} > - > -static int meson_enable_clk(struct device *dev, char *name) > -{ > - struct clk *clk; > - int ret; > - > - clk = devm_clk_get(dev, name); > - if (IS_ERR(clk)) { > - dev_err(dev, "Unable to get %s pclk\n", name); > - return PTR_ERR(clk); > - } > - > - ret = clk_prepare_enable(clk); > - if (!ret) > - ret = devm_add_action_or_reset(dev, meson_disable_clk, clk); > - > - return ret; > -} > - > static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > void *data) > { > @@ -666,6 +643,7 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > struct drm_device *drm = data; > struct meson_drm *priv = drm->dev_private; > struct dw_hdmi_plat_data *dw_plat_data; > + struct clk *clk; > int irq; > int ret; > > @@ -716,17 +694,23 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > if (IS_ERR(meson_dw_hdmi->hdmitx)) > return PTR_ERR(meson_dw_hdmi->hdmitx); > > - ret = meson_enable_clk(dev, "isfr"); > - if (ret) > - return ret; > + clk = devm_clk_get_enabled(dev, "isfr"); > + if (IS_ERR(clk)) { > + dev_err(dev, "Unable to get isfr pclk\n"); > + return PTR_ERR(clk); > + } > > - ret = meson_enable_clk(dev, "iahb"); > - if (ret) > - return ret; > + clk = devm_clk_get_enabled(dev, "iahb"); > + if (IS_ERR(clk)) { > + dev_err(dev, "Unable to get iahb pclk\n"); > + return PTR_ERR(clk); > + } > > - ret = meson_enable_clk(dev, "venci"); > - if (ret) > - return ret; > + clk = devm_clk_get_enabled(dev, "venci"); > + if (IS_ERR(clk)) { > + dev_err(dev, "Unable to get venci pclk\n"); > + return PTR_ERR(clk); > + } > > dw_plat_data->regm = devm_regmap_init(dev, NULL, meson_dw_hdmi, > &meson_dw_hdmi_regmap_config); Reviewed-by: Neil Armstrong Thanks, Neil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic