From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93FA2CD4F3C for ; Tue, 19 May 2026 07:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L5gdK1TUsfHbCcLp2XrkVOaU89xIVZDs/UdueLvSIOM=; b=4OI3+8wFzoxjk8nHDRy4nr+7oe GJVzOyK2xjj5gyRLjfgGaP4PIWDK9Iu/AAPH09U3yEcASxXzkOQJn2rO+Bk94n7Zk6pI2MmO5tpU/ ZleXk5JiSbaZ13U/yroEdqOa37ppbc1PHYbKlpjthOVAbddm55PjVPskIWklItebio4k9JuaG5rwd gic0oc8ceU+XJb9PQk95RFLycX0Xzn4xzGifWGXj5hYDPw+fp8l6pv12VLSFqjEDeLJAS0K+YPJBj fkSCpJDlwoYBiEfWWYYNhI7mNG7o1f9+u2D2CmqgCUNwzflctPSNMXrxu+A/QDidBaZQCzcJCNEI9 RtRIyGdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPEnl-00000000Txe-0OSU; Tue, 19 May 2026 07:23:41 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPEni-00000000TvY-3ijf for linux-amlogic@lists.infradead.org; Tue, 19 May 2026 07:23:40 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-43d7645adbdso2059818f8f.1 for ; Tue, 19 May 2026 00:23:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779175417; x=1779780217; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=sARt/XEtoBYHi4fyCJzLGB+SNU2tjajyLFXV5tLDUL0=; b=pCYzEu4zEE11B5mER+krfy1JrG8s5xbgYbvnk6zXbwQBgGo4l3NYzMU53BjYPcD/SK 3ZvvZI0ufYQ4bkZEGcImat30P7t6/rS5bNjxG90QbwQr9Q7Madd+HfRgRW8SnmPnh5Kd fBEg+v6fELAbohQYkdJ3fTbkQagRYW5HDu3BNK1hyj60QZDEIuJvOX90skd0Vp/K1Jyl O3b2k3gjPyJJEU4Ze6aZ8dS55C32aiUJXhS1gVP9Z8y7gQxFjotd9cBI9QCNInwj8vkB bIYqpOymcuJvH7+lzf7QaY4mFN7V5u8DPWmcbOYhmoACfiIGZWaWKbABuGnWIkMCW8dW YxJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779175417; x=1779780217; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sARt/XEtoBYHi4fyCJzLGB+SNU2tjajyLFXV5tLDUL0=; b=APxjrr79tKHHG6pFLxqA5OkqNQGyCULaHKolPI2rqGClKIhrtjuaqDesApERIQo5BX ZyYujHXPDMJpUzkG3QG+Lj5EYy47uE2q0zEBaVM68uxZQRSTvj9unz9qnxNizwjEUby2 l7SFq4vcMruUPiLB2BX/0aqslQEcb8oMR5Hz2dGEn3WrZE7DfyymaxHVoeA9At2fv1NB CHOybDLjQScKJPltuib/Ohbl+GlQb1ccbV5/ajW055O9mP6rb2HxpPPVJ6Y1vYmlcNvn Ogg904jPMP4UU8tP76jxLijaWTW7I8rky/qZstQSKBnxb6iyp6dSzYXNh6pQWUv3AOLF VHBw== X-Forwarded-Encrypted: i=1; AFNElJ80GLQPOF34eD0vDZ8INDrwQ9DrqaAogIuvBkOYL+kfDckvYeKObezS8s99i/E6VXZqFyZw9+2sZNCrvuRz@lists.infradead.org X-Gm-Message-State: AOJu0YxXc3tQiWPK7u/LXC0pBG8bNVeBhgfn9MTp38/gllojdc0ncSF2 GqwkuKfo5yIPP+YXbRh5SkiW/H06wx0yuNs1krD7pe2LCshi8Vux3JBXY4/AuapoO5I= X-Gm-Gg: Acq92OFC/GGAWyFb4b3QqjyvWlFcheE235wWh9xwYgLqqHtqZICCZ7H9HPZTC1AuQR8 fluS4svV5YLQqBYXxTBP1ZJIfy/NX2/urR5JUG1SDFQ/XSOr36md/uawglA5FaWixh0jFOkLPIC B4Gdgkjnt/dklVqyljue1aZsYGMhTlAmQW1lQfe/AJNv2ouhg1XJ9ZlxL8405OrY1B/g8xK4cXI jsLbKEn0gWiZJ+waLed2VMIcDoFllGLCT36efyt9aBQpv0IrKmN9NjtSAcIDpuxnYvaT2DtfjKW 1qifwDzn5xubL7ir9iE6NemVHmzjPP/ObxnhL8USgqchl/flF/n3EE8cCtPY6mxRLgMYU+lIznd 3yRX1KJhVY4rSeCu0mgQAE82ICs7iw0KUermqBfWRhUUynjAMNsJqDgEkQvBt7ybTJczxOQwnwq pG2fZ95h2CkYRXyrNRcJOB79rHvBpsCkArtu+Ui2WtOmum1C10b0fYiEYCxjMn9ICMkmx+i17yf spJjQCBj+UjfXU= X-Received: by 2002:a05:6000:40df:b0:45d:b14b:2409 with SMTP id ffacd0b85a97d-45e5c35dd7bmr29424483f8f.2.1779175416876; Tue, 19 May 2026 00:23:36 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:1d4b:274c:94d:a69f? ([2a01:e0a:106d:1080:1d4b:274c:94d:a69f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a5653sm43847302f8f.35.2026.05.19.00.23.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 00:23:36 -0700 (PDT) Message-ID: <6db86d54-b463-49bb-ae7f-35c694e624bc@linaro.org> Date: Tue, 19 May 2026 09:23:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH 02/13] drm/meson: dw-hdmi: Protect from possible NULL pointer dereference To: Jonas Karlman , Kevin Hilman , Heiko Stuebner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerome Brunet , Martin Blumenstingl , Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20260518194744.2483580-1-jonas@kwiboo.se> <20260518194744.2483580-3-jonas@kwiboo.se> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260518194744.2483580-3-jonas@kwiboo.se> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260519_002338_958351_D4029913 X-CRM114-Status: GOOD ( 18.81 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 5/18/26 21:47, Jonas Karlman wrote: > The IRQ handler can be called at any time after the call to > devm_request_threaded_irq() completes, even before dw_hdmi->bridge has > been assigned later in meson_dw_hdmi_bind(). > > Protect from a possible NULL pointer dereference in IRQ handler by only > calling drm_helper_hpd_irq_event() when bridge has been assigned. > > Fixes: e67f6037ae1b ("drm/meson: split out encoder from meson_dw_hdmi") > Signed-off-by: Jonas Karlman > --- > I only observed this NULL pointer dereference one time, without being > able to reliably re-create a similar timing scenario. I still think this > is an issue that possible could happen and likely should be fixed. > > Note that patches later in this series will fully replace this change. > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c > index 993f6d5d4b29..eafe7daf6ff1 100644 > --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c > @@ -520,7 +520,8 @@ static irqreturn_t dw_hdmi_top_thread_irq(int irq, void *dev_id) > u32 stat = dw_hdmi->irq_stat; > > /* HPD Events */ > - if (stat & (HDMITX_TOP_INTR_HPD_RISE | HDMITX_TOP_INTR_HPD_FALL)) { > + if (stat & (HDMITX_TOP_INTR_HPD_RISE | HDMITX_TOP_INTR_HPD_FALL) && > + dw_hdmi->bridge) { > bool hpd_connected = false; > > if (stat & HDMITX_TOP_INTR_HPD_RISE) Reviewed-by: Neil Armstrong Thanks, Neil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic