From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Nick Xie <nick@khadas.com>,
neil.armstrong@linaro.org, khilman@baylibre.com,
jbrunet@baylibre.com, jic23@kernel.org, dlechner@baylibre.com,
andy@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
conor+dt@kernel.org, linux-iio@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: iio: adc: amlogic,meson-saradc: add S4 compatible
Date: Mon, 23 Mar 2026 22:39:40 +0100 [thread overview]
Message-ID: <CAFBinCARQWQCjDFVyy3XOsae00KhcO2qpgLjH_r85cVxST6xtw@mail.gmail.com> (raw)
In-Reply-To: <20260323-saffron-cobra-of-perfection-731c8d@quoll>
On Mon, Mar 23, 2026 at 8:53 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Mar 23, 2026 at 09:34:05AM +0800, Nick Xie wrote:
> > Add the compatible string for the SARADC (Successive Approximation
> > Register ADC) IP block found in the Amlogic Meson S4 SoC.
> >
> > There are no known differences between the SARADC on S4 and the one
> > on G12A. Therefore, it uses "amlogic,meson-g12a-saradc" as a proper
> > specific fallback.
>
> You should explain here why you are adding that comment.
What do you think about:
Also add a comment indicating that "amlogic,meson-saradc" must not be
used for new devices. It's a made up compatible string that does not
correspond to a specific hardware generation and is not used to match
any driver. For old devices we keep it as it's part of the ABI.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-03-23 21:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 1:34 [PATCH v2 0/4] iio: adc: meson-saradc: add support for Meson S4 Nick Xie
2026-03-23 1:34 ` [PATCH v2 1/4] dt-bindings: iio: adc: amlogic,meson-saradc: add S4 compatible Nick Xie
2026-03-23 7:53 ` Krzysztof Kozlowski
2026-03-23 21:39 ` Martin Blumenstingl [this message]
2026-03-23 1:34 ` [PATCH v2 2/4] iio: adc: meson-saradc: add support for Meson S4 Nick Xie
2026-03-23 7:54 ` Krzysztof Kozlowski
2026-03-23 20:05 ` Jonathan Cameron
2026-03-24 7:07 ` Krzysztof Kozlowski
2026-03-24 9:06 ` Jonathan Cameron
2026-03-23 1:34 ` [PATCH v2 3/4] arm64: dts: amlogic: meson-s4: add internal SARADC controller Nick Xie
2026-03-23 1:34 ` [PATCH v2 4/4] arm64: dts: amlogic: meson-s4-s905y4-khadas-vim1s: add Function key support Nick Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCARQWQCjDFVyy3XOsae00KhcO2qpgLjH_r85cVxST6xtw@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=jic23@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nick@khadas.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®