From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3938C5DF7D for ; Fri, 21 Aug 2026 10:22:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=rOoDKZOboMwmXE4ZBpXaY+wRoTSKxBiHmcAdHeAlgKQ=; b=X3w+5dAZfJyHfFgKMUW0pp91hQ wC2rFgVI8Ry9JRjjAd/gismR1JXJES7J6Qgh4U+QphioxvGJcAAV2JJK9JDhFhOjSi66TMkY9G0/O g0e8WJfArwRqqfVLFrS6GABzWH0OV/u9Ym+8Y/D9na9SMEvmSnFavlk8TGcyntN6JgfJI8lasHRGj 2zkqaX+R/V85K0p6uJ6Lbnydw/Pb/Klf0MhE95rWOx3UjvJTDGa4OhZ0OoQzlxZ3yAOM0LYqCuIb7 NhMBxZXPm7tIvcO68IbAYOloP92KS5cPBO/PPgV9Z1i+PLUHHaRzYQfrL1Rtz0fstvnMGfVGyh37N lbsjf2lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wxMOC-0000000D5UV-1Ed8; Fri, 21 Aug 2026 10:22:20 +0000 Received: from mail-vk1-f179.google.com ([209.85.221.179]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wxMOA-0000000D5Tt-07Px for linux-amlogic@lists.infradead.org; Fri, 21 Aug 2026 10:22:19 +0000 Received: by mail-vk1-f179.google.com with SMTP id 71dfb90a1353d-5c2ae02f69eso704960e0c.2 for ; Fri, 21 Aug 2026 03:22:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787307736; x=1787912536; h=content-type:cc:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NZ9qFWwtyy0CyLFBazZArycje1mFKlJigB1GC39CAP0=; b=gdGNxn7Kz12N0JqamcWcZlYrZQg52jujnkgRa0YWywH7hOez1tQLIUpvW+NL/RrQDo KtG3+3YGUVlJDDfSXczqXxx5QuD33P5ONVC8NwgxUHEaH/inNXoADQqN+uGtwWXULRhL U3km0aO65B4zkRxShZfoZHnTLnxqpum8gmqStp4nrJJGoXhGu6djbf1osyqx/ka+D4Bf 0GHBzWtRgPCMb/u/CS4t721/fd5Mhp2i7WTgPJQOs3HIkWOmoWtnUQr3NMIdbbzG1/Sg yd5bSaK6COUewfurvsiDwJeheeZoyuOBXb9/8wus8bQsHQ0Vt3tfm4D+QDD2u/XgaGpL mvkQ== X-Forwarded-Encrypted: i=1; AHgh+Rp1kTs8IFldmLucNyby/zYtaLYCE7YQBGXG8RzvAzpWukURWl0PPG9Lafn9SXRL/XOj6cIsGKPG0ryl4I3h@lists.infradead.org X-Gm-Message-State: AFuF++nfAuqS6fxDrGuZERY117jewOAkteYNZtMmAn6lFzW+zNbt4m+2 /P4sj4/9WMrqs+K816i671fI5pcRI8LfMfZdmTVwJo6F3Q7jzYfbbqK8RudX/3mo X-Gm-Gg: AR+sD12GeBuA5rTFEH1uARhgni2POR0j+sLJBxGmxVnNgvoQPBvg3HVrdSF3awgdDTg sfsnmlLAjzf+8Fotx8ju6z6efYsNE1Lhs/AzTGmQXS2+DcUL/Ju69yRYwG7eH9cXG3LRiVOme2k +zcMo6D1UseXYQ394csljF8GHbsNI9K6ASnip4R6GIkcGmAT++Mkh5zdPrTL/qUFIREvH7vGRcc gSgAhz1p0hUl4oENCqjtygtRKBXpeO1RDUHAA97DZbGaMDRpO7aW+AwtrPDL5pOkTiKUjB9u9Rc OaGbhr70/TYFbqA83VHF3aDLZbRwk5Pac3TOEbpl6PeAM+khAnIBoLOD+KzTZNEU0+wUECqYZKD qSl9D/2sPH9r7rPZVA2EoNV+g1OCXdo4YhKrp4RPI8UJ/Ah21RXFe0AqTay5I9SpyH5bAGWpC0r Err56z8Ln1G8VszMj57vJE+akKp4Vd9mU97DE19X4qTcG1XI7gME/QQ8v8YyAiwKrhw6AwK/YxR thLdtkH1UXdQ9f7ElYQAiDb73if2Q== X-Received: by 2002:a05:6122:d8f:b0:5c5:d7aa:13ec with SMTP id 71dfb90a1353d-5c5ff3afbb1mr2132587e0c.1.1787307736578; Fri, 21 Aug 2026 03:22:16 -0700 (PDT) Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com. [209.85.221.178]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5c5fbdb21d6sm3239592e0c.0.2026.08.21.03.22.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Aug 2026 03:22:16 -0700 (PDT) Received: by mail-vk1-f178.google.com with SMTP id 71dfb90a1353d-5bf8a2932a3so551467e0c.1 for ; Fri, 21 Aug 2026 03:22:16 -0700 (PDT) X-Forwarded-Encrypted: i=1; AHgh+RooHnUfQbrHTaE4aPx9ocJj9PqBHdbX8fPId3iNJTSPGXEJlyMePFH0PCmOYwvRua4vv25Q74McQwYbrLLe@lists.infradead.org X-Received: by 2002:a05:6122:330d:b0:5bd:fb78:5461 with SMTP id 71dfb90a1353d-5c5fedcae2emt4672086e0c.0.1787307416387; Fri, 21 Aug 2026 03:16:56 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Geert Uytterhoeven Date: Fri, 21 Aug 2026 12:16:44 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AcwNN1XMP476J77X05DStUZ6YHTKoquM1cTbXZSuVIS6ygsja8ReRo486qzyWdY Message-ID: Subject: Re: [PATCH treewide 0/5] clk: Make sure clk_init_data is fully initialized (part 1) Cc: Tero Kristo , Stephen Boyd , Brian Masney , Jerome Brunet , Nobuhiro Iwamatsu , Nuno Sa , Guenter Roeck , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , Andy Shevchenko , Sunny Luo , Xianwei Zhao , Mark Brown , Kees Cook , Kevin Hilman , Mathieu Dubois-Briand , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, linux@analog.com, linux-iio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260821_032218_077158_D7F62A45 X-CRM114-Status: GOOD ( 26.36 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, 19 Aug 2026 at 21:05, Geert Uytterhoeven wrote: > The clk_init_data structure contains three mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. When commit > fc0c209c147f35ed ("clk: Allow parents to be specified without string > names") added the last two methods, this was done in a > backwards-compatible way, using a priority-based scheme: > - .name, .ops, .num_parents, and .flags must always be initialized, > - if .num_parents is non-zero, .parent_names must be initialized, > - if .parent_names is NULL, .parent_data must be initialized, > - if .parent_data is NULL, .parent_hws must be initialized > and valid. > > However, not initializing all members may cause subtle issues, which are > only exposed when CONFIG_INIT_STACK_ALL_PATTERN or > CONFIG_INIT_STACK_NONE is enabled. > > Hence this series makes sure all members are fully initialized, to fix > such bugs, and to avoid future breakage when converting drivers to a > different method for specifying the parents. > > This (small) series is part 1, and fixes all cases that I identified to > be real bugs: > - The first patch fixes a crash I saw on BeagleBone Black, > - The other patches are only compile-tested. > All patches in this series can be applied independently. > > Part 2 will be much larger (touching 185 files), and will fix the > remaining cases that are currently harmless. FTR, I split part two in 13 subparts, per subsystem: - "[PATCH 0/2] ARM/soc: Make sure clk_init_data is fully initialized" https://lore.kernel.org/cover.1787239869.git.geert+renesas@glider.be> - "[PATCH 0/3] ASoC: Make sure clk_init_data is fully initialized" https://lore.kernel.org/cover.1787239902.git.geert+renesas@glider.be> - "[PATCH 00/45] clk: Make sure clk_init_data is fully initialized (part two)" https://lore.kernel.org/cover.1787239813.git.geert+renesas@glider.be> - "[PATCH 0/2] drm: Make sure clk_init_data is fully initialized" https://lore.kernel.org/cover.1787239944.git.geert+renesas@glider.be> - "[PATCH] i2c: bcm2835: Make sure clk_init_data is fully initialized" https://lore.kernel.org/9f82f37e6d6c069cd44326bcd5e5a2a8069a13a9.1787239980.git.geert+renesas@glider.be> - "[PATCH 0/2] iio: Make sure clk_init_data is fully initialized" https://lore.kernel.org/cover.1787240005.git.geert+renesas@glider.be> - "[PATCH 0/3] media: Make sure clk_init_data is fully initialized" https://lore.kernel.org/cover.1787240035.git.geert+renesas@glider.be> - "[PATCH] MIPS: Alchemy: clock: Make sure clk_init_data is fully" https://lore.kernel.org/3610b51df642abb1fbb39f5bd93fddea43f8f164.1787240060.git.geert+renesas@glider.be> - "[PATCH 0/2] mmc: Make sure clk_init_data is fully initialized" https://lore.kernel.org/cover.1787240090.git.geert+renesas@glider.be> - "[PATCH net-next 0/3] net: Make sure clk_init_data is fully initialized" https://lore.kernel.org/cover.1787240118.git.geert+renesas@glider.be> - "[PATCH] peci: controller: aspeed: Make sure clk_init_data is fully" https://lore.kernel.org/48aa77c45e109f78ccd806bc3b7bf380c5bc5e71.1787240145.git.geert+renesas@glider.be> - "[PATCH 0/2] phy: Make sure clk_init_data is fully initialized" https://lore.kernel.org/cover.1787240165.git.geert+renesas@glider.be> - "[PATCH 0/5] rtc: Make sure clk_init_data is fully initialized" https://lore.kernel.org/cover.1787241693.git.geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic