RE: [PATCH treewide 2/5] clk: visconti: Make sure clk_init_data is fully initialized

From: <nobuhiro.iwamatsu.x90@mail.toshiba>
To: <geert+renesas@glider.be>, <kristo@kernel.org>,
	<sboyd@kernel.org>, <bmasney+clk@redhat.com>,
	<jbrunet+clk@baylibre.com>, <nuno.sa@analog.com>,
	<linux@roeck-us.net>, <Michael.Hennerich@analog.com>,
	<antoniu.miclaus@analog.com>, <jic23@kernel.org>,
	<dlechner@baylibre.com>, <andy@kernel.org>,
	<sunny.luo@amlogic.com>, <xianwei.zhao@amlogic.com>,
	<broonie@kernel.org>, <kees@kernel.org>, <khilman@baylibre.com>,
	<mathieu.dubois-briand@bootlin.com>
Cc: <linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-hwmon@vger.kernel.org>, <linux@analog.com>,
	<linux-iio@vger.kernel.org>, <linux-amlogic@lists.infradead.org>,
	<linux-spi@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH treewide 2/5] clk: visconti: Make sure clk_init_data is fully initialized
Date: Thu, 20 Aug 2026 02:03:15 +0000	[thread overview]
Message-ID: <TY7PR01MB1481812D226130989DCE5FC1BCDA42@TY7PR01MB14818.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <42dd7be99acbbea1343e2fcc0ba4ffb91f8517ca.1787165329.git.geert+renesas@glider.be>

> -----Original Message-----
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> Sent: Thursday, August 20, 2026 4:05 AM
> To: Tero Kristo <kristo@kernel.org>; Stephen Boyd <sboyd@kernel.org>; Brian
> Masney <bmasney+clk@redhat.com>; Jerome Brunet
> <jbrunet+clk@baylibre.com>; iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○Ｃ
> ＰＴ) <nobuhiro.iwamatsu.x90@mail.toshiba>; Nuno Sa
> <nuno.sa@analog.com>; Guenter Roeck <linux@roeck-us.net>; Michael
> Hennerich <Michael.Hennerich@analog.com>; Antoniu Miclaus
> <antoniu.miclaus@analog.com>; Jonathan Cameron <jic23@kernel.org>;
> David Lechner <dlechner@baylibre.com>; Andy Shevchenko
> <andy@kernel.org>; Sunny Luo <sunny.luo@amlogic.com>; Xianwei Zhao
> <xianwei.zhao@amlogic.com>; Mark Brown <broonie@kernel.org>; Kees
> Cook <kees@kernel.org>; Kevin Hilman <khilman@baylibre.com>; Mathieu
> Dubois-Briand <mathieu.dubois-briand@bootlin.com>
> Cc: linux-omap@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-hwmon@vger.kernel.org; linux@analog.com; linux-iio@vger.kernel.org;
> linux-amlogic@lists.infradead.org; linux-spi@vger.kernel.org;
> linux-clk@vger.kernel.org; linux-kernel@vger.kernel.org; Geert Uytterhoeven
> <geert+renesas@glider.be>
> Subject: [PATCH treewide 2/5] clk: visconti: Make sure clk_init_data is fully
> initialized
> 
> The clk_init_data structure contains several mutually-exclusive members for
> different methods to specify the possible parents of a clock, prompting drivers
> to initialize only the members they need.  However, not initializing all members
> may cause subtle issues, which are only exposed when
> CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is
> enabled.
> 
> visconti_clk_register_gate() fills in init.parent_data, and assumes that
> init.parent_names is NULL.  However, the latter in uninitialized, and thus may
> cause a crash.
> 
> Make sure all members are fully initialized, to fix such bugs, and to avoid future
> breakage when converting drivers to a different method for specifying the
> parents.
> 
> Fixes: b4cbe606dc3674b2 ("clk: visconti: Add support common clock driver
> and reset driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>

Best regards,
  Nobuhiro


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic