From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71F54C9830D for ; Fri, 25 Sep 2026 14:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sBgizsZ2R0HO88AhczQ4dc6l5V1idvYSnHhBMIRGa74=; b=wdcNAs461wm80F krDoGgYs2FNdrQRlPHNrtL5dcp/U0w/K2XDORMMld3RUSoOoN9DxoZh3zv1bdtEQs7wbaMCimr/H7 908gq5Q1t1npwy07aSq5UrBT12tHqWkocjVW4USaZCJFkBbn+VxnWoM7HJxycMZMxVpA4aOiZjD4n T3Ow0UwoYoT0FtFIqFxTckpevBOJHc4Yfrnfw5HvrJTIsyXUVrn0JJK+W9wFPMaSq4Ae8bdF2Vrm+ +49aZPzCxZnLvmjUlaq+/wGM7vwBuhFcCodza9+FiWNpmxJy+L/hhC6V7gEcvbzqRsMAKinm2fJkQ +OezuxZwSBO8+wgHrmnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xA6zh-0000000DbFV-1oQs; Fri, 25 Sep 2026 14:33:45 +0000 Received: from courrier.aliel.fr ([2a01:4f9:c011:1c83::1]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xA6ze-0000000DbEa-07Vk; Fri, 25 Sep 2026 14:33:44 +0000 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aliel.fr; s=courrier-s1; t=1790346812; bh=9jqyIRV/pOYj50TCwmyP6yS9VVMyAsAlhPgldRTFX2k=; h=Date:From:Subject:To:Cc:References:In-Reply-To; b=D8kZzq91ojMHy1q3+FkGTAj2eKm1J5aSPaflO0zmCg8BH1ETab4I0pA1MHP/6hknr w8df/Xgj5owDwM7Bt0wQUyuhFiRb7Ey7YCUsfm9h98W92rQHetD2TSOdhxK+4pH9oM PXN3yM78+mOOZe5WoU6qFy2gJzsNYQP0iVk6nSaM= Date: Fri, 25 Sep 2026 16:32:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta From: linux-kernel-dev@aliel.fr Subject: Re: [PATCH 1/3] dt-bindings: pwm: amlogic: Add core clock for T7 To: Conor Dooley Cc: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiner Kallweit , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org References: <20260924-add-t7-sys-pwm-clk-v1-0-05b91e87f0a9@aliel.fr> <20260924-add-t7-sys-pwm-clk-v1-1-05b91e87f0a9@aliel.fr> <20260924-reprimand-taste-3481319d9e31@spud> Content-Language: en-US In-Reply-To: <20260924-reprimand-taste-3481319d9e31@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260925_073342_524549_6E7FE390 X-CRM114-Status: GOOD ( 20.02 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 9/24/26 6:35 PM, Conor Dooley wrote: > On Thu, Sep 24, 2026 at 05:14:28PM +0200, Ronald Claveau via B4 Relay wrote: >> From: Ronald Claveau >> >> The T7 PWM controller has a system clock (the register access clock) >> in addition to the two input clocks of channels A and B. Add it as a >> third clock, named "core", for the amlogic,t7-pwm compatible, and >> require clock-names for this SoC for clarity. > > What additional clarity does that actually bring? I think it's kinda > less clear, because the git history is required to explain why drivers > cannot fetch the existing clocks by name. > Right it's not clear, I will rephrase this. >> >> The other compatibles are left unchanged. Add an example showing the >> T7 usage with its fallback to amlogic,meson-s4-pwm. >> >> Signed-off-by: Ronald Claveau >> --- >> .../devicetree/bindings/pwm/pwm-amlogic.yaml | 37 +++++++++++++++++++--- >> 1 file changed, 33 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> index c337d85da40f1..9212a40d9fe48 100644 >> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> @@ -62,7 +62,7 @@ properties: >> >> clock-names: >> minItems: 1 >> - maxItems: 2 >> + maxItems: 3 >> >> power-domains: >> maxItems: 1 >> @@ -135,17 +135,38 @@ allOf: >> properties: >> compatible: >> contains: >> - enum: >> - - amlogic,meson-s4-pwm >> + const: amlogic,t7-pwm >> then: >> properties: >> clocks: >> items: >> - description: input clock of PWM channel A >> - description: input clock of PWM channel B >> - clock-names: false >> + - description: gate clock for the PWM controller >> + clock-names: >> + items: >> + - const: clk_a >> + - const: clk_b > > I'd rather "channel-a" or similar, we try not to state the obvious in > the names of clocks etc - of course this is a clock! > Thanks for the suggestion, I didn't want to add "clk_chan_a", I will go with "channel-a" and "channel-b". >> + - const: core >> required: >> - clocks >> + - clock-names >> + else: >> + if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - amlogic,meson-s4-pwm >> + then: >> + properties: >> + clocks: >> + items: >> + - description: input clock of PWM channel A >> + - description: input clock of PWM channel B >> + clock-names: false > > Are you sure that the s4-pwm doesn't also have this core clock? Seems > likely, no? > You right, S4, A1, C3 and T7 have this clock, but S4 and A1 clock driver declare them with "CLK_IGNORE_UNUSED" flag. I will make a new proposal on V2. > Cheers, > Conor. > >> + required: >> + - clocks >> >> - if: >> properties: >> @@ -182,3 +203,11 @@ examples: >> clocks = <&pwm_src_a>, <&pwm_src_b>; >> #pwm-cells = <3>; >> }; >> + - | >> + pwm@60000 { >> + compatible = "amlogic,t7-pwm", "amlogic,meson-s4-pwm"; >> + reg = <0x60000 0x24>; >> + clocks = <&clk_a>, <&clk_b>, <&core>; >> + clock-names = "clk_a", "clk_b", "core"; >> + #pwm-cells = <3>; >> + }; >> >> -- >> 2.49.0 >> >> -- Best regards, Ronald _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic