From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A2B8FE51F7 for ; Fri, 24 Apr 2026 10:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8Li1OV/clBWnLOXCKGMVsERR1hAHQkzJ+tAouu+rcg8=; b=vG335l3x6NBAbGnpXo+R3fIoV6 W8hDdV4I6CSZFKKH3MYKbs5zG/wuB6sAyJrlDdkCpYP6n8Es6ei6mV+pcfizzKSi5Gu1kbXnmXXp6 v2N1G+Wfh1V+pGqjA84Gqb4U+jzUqXMWxsspfH6TiNUK5nEzxJc95SIxF686RXLu6dag4CWdb7yKa l/DOlxd1zuBELOiKO5cnzSzIOQiUDnVRnn5CzEtPuC7zbvSiqhyTbUxx4fWZ/tPYJKxlIkJZZNzLX zDDSpgQsmXGkvPEX7+J8vgwNqUMitbqBJx4JC/Umz7F5DZGWyVpA6kYmh589oR8lj9i4CCphvNXG6 PnY4wnMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGDLA-0000000Cypb-20Va; Fri, 24 Apr 2026 10:00:52 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGDL7-0000000Cyow-30uL for linux-amlogic@lists.infradead.org; Fri, 24 Apr 2026 10:00:50 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4891f625344so62885475e9.0 for ; Fri, 24 Apr 2026 03:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777024848; x=1777629648; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=9cwRtmDAbT4Y+He6JfFqenlNmTZcScEAW3BnQ0sfKIA=; b=TOLh01tPXelqQouGs8k/4ZCzoKmx5DX/uB/MJXRKLaNdtkj5lSqNx1uD/osmyb60PB Y3cmu3nrNr5T5Qu/huACskq2xEjbfINsoLIacFop3dBtlnqcx3arFhFPLIzE/woAzFMi 9gPl2Qg+/ZRBOIB5Wn3/5nmuXgZDnuLwyR+JR5WZNW3PvUaR3jh1NqF1A25D3Cd4p7Gm Twlk2OBYrHSm+fZVUdF3JyxAKvjXU538UhRQJN0rO6Xt/o0CTASyz5uSceJtgwYH273e cqsivncNb/m2iYZyeLw2DgSFK6pw1wsgTn8TNLkK6OUYPs6U7xYNen795ArV62eAUDpc zSLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777024848; x=1777629648; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9cwRtmDAbT4Y+He6JfFqenlNmTZcScEAW3BnQ0sfKIA=; b=o5gTK/nEkwjmMdLzKwwQxpq2Gyf2wDURSOazkLQC9Ve7W5/FgtVDTc6tYpJsmNgctn d3EAKMcTEg/Eq3yjI44RN3RHSrdnH456RvQkQD4X/KcSRqbp2320zNJBiAcbqde0Ja35 W2dVv/MpKlxc30yp/SdZskS5jfGxqFy6pC1q5uWioqQ4VX22qR2N8I8q+M5lXvrhTCEy 2aQ9jfAAk9KSYlhqk6hhcgQryamKvQyyykt+z0cAgKWVAucPz3cU7ZeWsX+KTs1ZD1nK /aJ0woJRq2EJeoChZezO0M0kBIqBHl/np4Mj4WmX17bJ1v0gZRoJiRBzQCGKfwkgSCNT z8dA== X-Gm-Message-State: AOJu0Yw2Ckkcx3EZXEUt0IZMyR3oUTfaQ96FyJUrs/4tEvE+djOlT448 7ngEOjJnGRNUZlV2HjWRwERE6Wga/ZjbouQch+67XrQIFWGQxGG+J8pYnwQF/6S0AO8= X-Gm-Gg: AeBDieux053KVtw4Ii24Kmxw016+rsx3SMUxd9h52jfnN2/UhIkNalxBkvGjnBhkL5P JuoNsnHIr5N7rLwHZ0nFoATkAJyuuqvgOlt6CGcrs1oidZUgfpwe/Kjv/1qAdqunC2JVgTNr7ni yIauSQRvt7b55fI8jvogfnPGMfTZnl51y4Tv4y0+A+r1mwTZn7GHOevkMA4jnESPk7uXchyrEyE UhVV7ruWdKKH6JkZrXjGqN5WYhLYfWvMLKv82yc7R5dlFkeEacCeGITif22ACpr83ZWij5qGPbq BfmuCLe3wUZGYkhfjJcScKCpfOitFhVdjmdI9jXnxjDce9ra//HVmLCL+VmMjtCRRbPsZfWZRtg 6m7FedFgALN1mEA0YNxy8HHib9kXa74gonsOdcc4kVYWQzQ/pRIu0XDCPlkEeJj/045mOHtbMub I4HG4/iWLTVxmEI9kaoaJ7UdqOY8U9OSBgDW9ulW/FQck7rIIYQBSyV/TCPjN463Bo+IyGQxHE/ /2ytT6d01r+HDTUt+g9mZsUOsqx X-Received: by 2002:a05:600c:1d05:b0:489:1baf:8c03 with SMTP id 5b1f17b1804b1-4891baf8d2cmr288416295e9.11.1777024847607; Fri, 24 Apr 2026 03:00:47 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:79e1:f56b:445c:ca9c? ([2a01:e0a:106d:1080:79e1:f56b:445c:ca9c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb7a0b60sm169961765e9.17.2026.04.24.03.00.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 03:00:47 -0700 (PDT) Message-ID: Date: Fri, 24 Apr 2026 12:00:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH v4 5/8] thermal: khadas-mcu-fan: Add fan config from platform data Add regulator support To: linux-kernel-dev@aliel.fr, Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andi Shyti , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Beniamino Galvani , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Liam Girdwood , Mark Brown Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org References: <20260421-add-mcu-fan-khadas-vim4-v4-0-447114a28f2d@aliel.fr> <20260421-add-mcu-fan-khadas-vim4-v4-5-447114a28f2d@aliel.fr> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260421-add-mcu-fan-khadas-vim4-v4-5-447114a28f2d@aliel.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260424_030049_807172_F386E5A2 X-CRM114-Status: GOOD ( 21.17 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 4/21/26 13:49, Ronald Claveau via B4 Relay wrote: > From: Ronald Claveau > > Replace the hardcoded MAX_LEVEL constant and fan register > with values read from platform_data (fan_reg, max_level), > as new MCUs need different values. > > Optionally acquire and enable a "fan" regulator supply > at probe time and on resume, > so boards that gate fan power through a regulator are handled. > > Signed-off-by: Ronald Claveau > --- > drivers/thermal/khadas_mcu_fan.c | 49 +++++++++++++++++++++++++++++++++++----- > 1 file changed, 43 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/khadas_mcu_fan.c b/drivers/thermal/khadas_mcu_fan.c > index d35e5313bea41..24559bf65de46 100644 > --- a/drivers/thermal/khadas_mcu_fan.c > +++ b/drivers/thermal/khadas_mcu_fan.c > @@ -13,13 +13,15 @@ > #include > #include > #include > - > -#define MAX_LEVEL 3 > +#include > > struct khadas_mcu_fan_ctx { > struct khadas_mcu *mcu; > + unsigned int fan_reg; > unsigned int level; > + unsigned int max_level; > struct thermal_cooling_device *cdev; > + struct regulator *power; > }; > > static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx, > @@ -27,8 +29,7 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx, > { > int ret; > > - ret = regmap_write(ctx->mcu->regmap, KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG, > - level); > + ret = regmap_write(ctx->mcu->regmap, ctx->fan_reg, level); > if (ret) > return ret; > > @@ -40,7 +41,9 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx, > static int khadas_mcu_fan_get_max_state(struct thermal_cooling_device *cdev, > unsigned long *state) > { > - *state = MAX_LEVEL; > + struct khadas_mcu_fan_ctx *ctx = cdev->devdata; > + > + *state = ctx->max_level; > > return 0; > } > @@ -61,7 +64,7 @@ khadas_mcu_fan_set_cur_state(struct thermal_cooling_device *cdev, > { > struct khadas_mcu_fan_ctx *ctx = cdev->devdata; > > - if (state > MAX_LEVEL) > + if (state > ctx->max_level) > return -EINVAL; > > if (state == ctx->level) > @@ -83,11 +86,32 @@ static int khadas_mcu_fan_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct khadas_mcu_fan_ctx *ctx; > int ret; > + const struct khadas_mcu_fan_pdata *pdata = dev_get_platdata(&pdev->dev); Move this on top to respect reverse christmas ordering. > > ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); > if (!ctx) > return -ENOMEM; > + > ctx->mcu = mcu; > + ctx->fan_reg = pdata->fan_reg; > + ctx->max_level = pdata->max_level; > + > + ctx->power = devm_regulator_get_optional(dev->parent, "fan"); > + if (IS_ERR(ctx->power)) { > + if (PTR_ERR(ctx->power) == -ENODEV) > + ctx->power = NULL; > + else > + return PTR_ERR(ctx->power); > + } > + > + if (ctx->power) { > + ret = regulator_enable(ctx->power); > + if (ret) { > + dev_err(dev, "Failed to enable fan power supply: %d\n", ret); > + return ret; > + } > + } Or you can request with devm_regulator_get(dev->parent, "fan"); which will return a dummy regulator, and then you can just call regulator_enable & disable and remove all those checks. > + > platform_set_drvdata(pdev, ctx); > > cdev = devm_thermal_of_cooling_device_register(dev->parent, > @@ -124,12 +148,25 @@ static int khadas_mcu_fan_suspend(struct device *dev) > > ctx->level = level_save; > > + if (ctx->power) { > + ret = regulator_disable(ctx->power); > + if (ret) > + return ret; > + } if (ctx->power) return regulator_disable(ctx->power); > + > return 0; > } > > static int khadas_mcu_fan_resume(struct device *dev) > { > struct khadas_mcu_fan_ctx *ctx = dev_get_drvdata(dev); > + int ret; > + > + if (ctx->power) { > + ret = regulator_enable(ctx->power); > + if (ret) > + return ret; > + } > > return khadas_mcu_fan_set_level(ctx, ctx->level); > } > Thanks, Neil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic