From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1960CFE51FA for ; Fri, 24 Apr 2026 09:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zC3na0u9liKndcQbGTnYe38DUwtxuEYFiq0vQp7bhws=; b=ht1KFo3ru8VuWvLtfda600G2xY ixr0mHFKqz/Zrb6xtYEahrwZSL7Wid9yAbfJWNXte0IiHAR0gVqNLUIyqGK9lV0lPL6F7wAjIf8lr EFrgcfoEJSbfMdKQkNKWDqEoHsHON705M9uRKF2aJhO9YZGaMO3gDGN6thbyOcbYq+lRjgJN9zx2j anP/XCg5Z9gtrWsRAr84X3GwHQL/mRYGkwm2EXPqUeIAU1B/Oyp0CaotqlPiE9vrGngJXEShoLYu0 FBEnXET2CpWlYMX8Ls2KV9hloM6eYqk5anvESExPDO10lRKITXcORXixfQnSDHQdOTAjDlfPo/+oi wdnKplkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGD8c-0000000CxKz-1fMh; Fri, 24 Apr 2026 09:47:54 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGD8a-0000000CxK0-3hRm for linux-amlogic@lists.infradead.org; Fri, 24 Apr 2026 09:47:54 +0000 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4838c15e3cbso71339405e9.3 for ; Fri, 24 Apr 2026 02:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777024071; x=1777628871; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=zyyE/r/iA1MwYNHXAS7P+Cj4G1v9/C9w7YzUp4f7iBc=; b=maTCA5TUp8xzhVshCkccW3aTMn6hawPk9SRweNWfcKDWAjlEiRh6p9KJ43Pw2yIsLo WcTsPgvUf1A7LOF3j9RRYTJ9z3QWhoXjbNoeq1DP7Y15LVvUR+Gk+qQLPYVi/goLXrwq HXefUIA1u7HqmhTPc4+mKmuzEPkqT68PMzuWVQEIjb+d4JiE7kgyJd/Rqj1wknEDvq0R Yf8G2ZXas2pFimnwNMlQiL0lszaW7Nr7EtYvJlIHTshq5DUr/hlNF1tCbgsiyOnwSs2F I7Ua4DwRQB888/xwdFJ2yX9I2VO3rghk5bcyS1TX1RkyR0D5rciDGaEY4uj/mCRNZyNN MQKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777024071; x=1777628871; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zyyE/r/iA1MwYNHXAS7P+Cj4G1v9/C9w7YzUp4f7iBc=; b=Pzgi0VNGlUYcpkwxdmZIIUbZHOy29QYWZoein9b3ZZcI7UNzyxs2RSrPlCn2dyaaAe +kQfUqfzmJ7ySXwhXDu/W/L1JfItgfwLbcIb7UG+uifHI9jYPVb7kU8LsTfTYgyMeQKn 9azKGMfrtAoAvZxuespzoQWZH57eb/TrBlFuJ8Kw2zXtp10MXIa6AmsfPXAmVNEJomyI c36lvXBf4ygxIOEs1+vvUjDFVrOqKMNSnOLwKrg2cO/fBysBTW2/qp0rQ9c/7FMpjbdO Pey+5qsovKpan8Wg3fYEtZP40f1GVFc/t6c3dZ+7UCj0SI1iV6tmscZrBX6xacBw2fZt eIfQ== X-Forwarded-Encrypted: i=1; AFNElJ/UmSGQSHyRAKFJgGsOZS5CnaVtYlCpQuW4ejMYIDIPS7VNKp83htX4zdO1ySt60X9CIA8lkIbLQPnLPmgO@lists.infradead.org X-Gm-Message-State: AOJu0Yy4/stbWSZpK4lOlFhvHn/61sfZbfIqTbCgFgAQkf7d4T+RW3RY RiX7ShXhUHNfjjXBkglM+7s9iIYxWH2RFeZHMENBx3Ojw9trtgvVSeZxel2It1+jpuo= X-Gm-Gg: AeBDieun157TUD9JBTiKir/e5Jv1r31TId1m8MoHRyKlYtKOaNOF7Kne3m1X6KzeqC8 /oDwCy5IXyEKOHr3SAjOpNvGK16pGect8dMY9iCBDkIRrHRDQMKY4aNQl6T0yG68AHIJliTHTP1 KHVqjTXjhIzmudFwdEJ+zy0yESVNzG5vjyeHTMqI/LFfgiug+hc8HkIOm7pNIjN0i9PJGiwtWnY AEs65ByRhQ72su5AxmjqavW9Y/KZEz/PmWIsepUrvVDbdNn2kzLCkCnWoQ//oqL9ZCzmeMoL4/X oy/e4+Hc7sNkTHX6WZLC0hFcUfTj3A6mqXqhas46uEhfwBMLUCmicYiLoEpDWr7OGJ9JYYFrb4I uJE38D8i/6Y9Yp7+5uY3CW+eeE+cFI6MZhuok+ppczBLSbJoi0iwXPSXbgSal84BqUfN+sWaKno ZviNT5SdSn71P8tQdPDMAMKeejUc81uY/yPUTldNnXdzmIkDS27oLy2HEfVxWFIN2tcWM2Xqa7H 0x9xkfJ9t2+4n+RAw== X-Received: by 2002:a05:600c:c4a2:b0:488:c078:bfda with SMTP id 5b1f17b1804b1-488fb78eebdmr426779015e9.26.1777024070744; Fri, 24 Apr 2026 02:47:50 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:79e1:f56b:445c:ca9c? ([2a01:e0a:106d:1080:79e1:f56b:445c:ca9c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb75ab25sm179552435e9.11.2026.04.24.02.47.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 02:47:50 -0700 (PDT) Message-ID: Date: Fri, 24 Apr 2026 11:47:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH v4 3/8] firmware: meson: sm: Add thermal calibration SMC call To: linux-kernel-dev@aliel.fr, Guillaume La Roque , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20260423-add-thermal-t7-vim4-v4-0-d4c1528d5044@aliel.fr> <20260423-add-thermal-t7-vim4-v4-3-d4c1528d5044@aliel.fr> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260423-add-thermal-t7-vim4-v4-3-d4c1528d5044@aliel.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260424_024752_952426_059AFF9C X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 4/23/26 18:07, Ronald Claveau via B4 Relay wrote: > From: Ronald Claveau > > Add SM_THERMAL_CALIB_READ at SMC ID 0x82000047 in the command > table and implement meson_sm_get_thermal_calib(), which forwards the > tsensor_id argument to the secure monitor and returns the calibration data. > > Also realign the CMD() column to improve readability. > > Signed-off-by: Ronald Claveau > --- > drivers/firmware/meson/meson_sm.c | 29 ++++++++++++++++++++++++----- > 1 file changed, 24 insertions(+), 5 deletions(-) > > diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/meson_sm.c > index 3ab67aaa9e5da..4e57986724212 100644 > --- a/drivers/firmware/meson/meson_sm.c > +++ b/drivers/firmware/meson/meson_sm.c > @@ -41,12 +41,13 @@ static const struct meson_sm_chip gxbb_chip = { > .cmd_shmem_in_base = 0x82000020, > .cmd_shmem_out_base = 0x82000021, > .cmd = { > - CMD(SM_EFUSE_READ, 0x82000030), > - CMD(SM_EFUSE_WRITE, 0x82000031), > + CMD(SM_EFUSE_READ, 0x82000030), > + CMD(SM_EFUSE_WRITE, 0x82000031), > CMD(SM_EFUSE_USER_MAX, 0x82000033), > - CMD(SM_GET_CHIP_ID, 0x82000044), > - CMD(SM_A1_PWRC_SET, 0x82000093), > - CMD(SM_A1_PWRC_GET, 0x82000095), > + CMD(SM_GET_CHIP_ID, 0x82000044), > + CMD(SM_THERMAL_CALIB_READ, 0x82000047), > + CMD(SM_A1_PWRC_SET, 0x82000093), > + CMD(SM_A1_PWRC_GET, 0x82000095), > { /* sentinel */ }, > }, > }; > @@ -245,6 +246,24 @@ struct meson_sm_firmware *meson_sm_get(struct device_node *sm_node) > } > EXPORT_SYMBOL_GPL(meson_sm_get); > > +/** > + * > + * meson_sm_get_thermal_calib - Read thermal sensor calibration data. > + * @fw: Pointer to secure-monitor firmware. > + * @trim_info: Pointer to store the returned calibration data. > + * @tsensor_id: Sensor index to identify which sensor's calibration data > + * to retrieve > + * > + * Return: 0 on success, negative error code on failure. > + */ > +int meson_sm_get_thermal_calib(struct meson_sm_firmware *fw, u32 *trim_info, > + u32 tsensor_id) > +{ > + return meson_sm_call(fw, SM_THERMAL_CALIB_READ, trim_info, tsensor_id, > + 0, 0, 0, 0); > +} > +EXPORT_SYMBOL_GPL(meson_sm_get_thermal_calib); > + > #define SM_CHIP_ID_LENGTH 119 > #define SM_CHIP_ID_OFFSET 4 > #define SM_CHIP_ID_SIZE 12 > Reviewed-by: Neil Armstrong Thanks, Neil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic