From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBov1q/yMiKtweXlUbf49YkzhWCW3TKqLyUzVuHso0kPxQKjk/oPZ31xcV1CL6T/HmHsqlwao ARC-Seal: i=1; a=rsa-sha256; t=1516333005; cv=none; d=google.com; s=arc-20160816; b=cd8BLZLq5yHILlqF92BgU0+sWvWUbbxrjcTu5SHXtTN30A4oX+4nva7f+eyVXiMjM3 LhXqDSWXQQy2Qa6Q4tQK2BKdElY1uA565M1gNsmWEnAVnZAhd4bgs9wl+4NgwaEkWJcD q1Zq2QbwwIFvx2oC0VC/6+hzZONSKSGbaUvN41UbkxBlLCCRpwYASOEEzAjqWoCAspFL Q3OSo59dtsMeclfF9/pMMu2XIp5KFUGGRn0fdJIXL6CBRx3TSNHzVBqN32yBVQu109ps 8+mbDphVC/4JZ1LWynQqLlNs+k/siCwXmZqME7nZdo8OXEfnnu1BZdZnSzR/q0Wrbp7i fvww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:content-id:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:arc-authentication-results; bh=r4uWeIV8gg9Vd1fNPnYMUGV28R+qcL6cJ3vbmhWCmU4=; b=v3DyxERCBdI7U5r/2hPNbNaBRBUs4ff3tR9pTrAVvfy25wRzjCShak5wJ8DHft4lcE 9z1JWyvbSDi2O1yuqKS71oMWOzDBtVS2wtCCznEi1bPiOh6EJdMHhbX5G9Cda1jimzGv nX+0yyi1sbGnXzJGkGDZldlu1Hepnv833zrYjyBEazW1cnWWEdlA4oqOuTf37HrTbJyn lXVHlfNfgUgrfT3/KcRLCm5r1qV5xcbczr4wE3l+Nzd1B88+xdJSwO6sP9gJk8UCywmu kv+cAMvtEGSUvM1fBZ1GOo/CSgxKY284ehaEiYiEwm+3RiY51mDdggplBft0CBoTPRGG X16g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of andreas.dilger@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=andreas.dilger@intel.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of andreas.dilger@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=andreas.dilger@intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,380,1511856000"; d="scan'208";a="11759615" From: "Dilger, Andreas" To: Fabian Huegel CC: "Drokin, Oleg" , James Simmons , "Hammond, John" , "Greg Kroah-Hartman" , "devel@driverdev.osuosl.org" , Ben Evans , NeilBrown , Lustre Development List , Linux Kernel Mailing List , "linux-kernel@i4.cs.fau.de" , Christoph Volkert Subject: Re: [PATCH 6/8] staging: lustre: Fix overlong lines Thread-Topic: [PATCH 6/8] staging: lustre: Fix overlong lines Thread-Index: AQHTiwAg/T94fQ/Vd0a4ZwJqdCJkz6NvcBcAgAutdgA= Date: Fri, 19 Jan 2018 03:36:43 +0000 Message-ID: <00C20AD1-618E-4F27-8DA1-4D6C4339CFFA@intel.com> References: <1515691022-22729-1-git-send-email-fabian_huegel@web.de> <1515691022-22729-7-git-send-email-fabian_huegel@web.de> In-Reply-To: <1515691022-22729-7-git-send-email-fabian_huegel@web.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.28.49] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589317288598754575?= X-GMAIL-MSGID: =?utf-8?q?1589990398211893724?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Jan 11, 2018, at 10:17, Fabian Huegel wrote: >=20 > Fixed four lines that went over the 80 character limit > to reduce checkpatch warnings. >=20 > Signed-off-by: Fabian Huegel > Signed-off-by: Christoph Volkert > --- > drivers/staging/lustre/lustre/include/obd_class.h | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/= staging/lustre/lustre/include/obd_class.h > index d195866..06f825b 100644 > --- a/drivers/staging/lustre/lustre/include/obd_class.h > +++ b/drivers/staging/lustre/lustre/include/obd_class.h > @@ -850,7 +850,9 @@ static inline int obd_pool_del(struct obd_device *obd= , char *poolname) > return rc; > } >=20 > -static inline int obd_pool_add(struct obd_device *obd, char *poolname, c= har *ostname) > +static inline int obd_pool_add(struct obd_device *obd, > + char *poolname, > + char *ostname) This only needs a single field moved onto the next line, like: +static inline int obd_pool_add(struct obd_device *obd, char *poolname, + char *ostname) > @@ -861,7 +863,9 @@ static inline int obd_pool_add(struct obd_device *obd= , char *poolname, char *ost > return rc; > } >=20 > -static inline int obd_pool_rem(struct obd_device *obd, char *poolname, c= har *ostname) > +static inline int obd_pool_rem(struct obd_device *obd, > + char *poolname, > + char *ostname) Same. > @@ -997,7 +1001,8 @@ static inline int obd_statfs(const struct lu_env *en= v, struct obd_export *exp, > spin_unlock(&obd->obd_osfs_lock); > } > } else { > - CDEBUG(D_SUPER, "%s: use %p cache blocks %llu/%llu objects %llu/%llu\n= ", > + CDEBUG(D_SUPER, > + "%s: use %p cache blocks %llu/%llu objects %llu/%llu\n", > obd->obd_name, &obd->obd_osfs, > obd->obd_osfs.os_bavail, obd->obd_osfs.os_blocks, > obd->obd_osfs.os_ffree, obd->obd_osfs.os_files); > @@ -1579,7 +1584,8 @@ int class_procfs_init(void); > int class_procfs_clean(void); >=20 > /* prng.c */ > -#define ll_generate_random_uuid(uuid_out) get_random_bytes(uuid_out, siz= eof(class_uuid_t)) > +#define ll_generate_random_uuid(uuid_out) \ > + get_random_bytes(uuid_out, sizeof(class_uuid_t)) This looks like it would be better to replace ll_generate_random_uuid() callers with generate_random_uuid(). Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation