From: Finn Thain <fthain@telegraphics.com.au>
To: "David S. Miller" <davem@davemloft.net>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Chris Zankel <chris@zankel.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 5/7] net/sonic: Remove explicit memory barriers
Date: Sun, 16 Feb 2020 08:03:32 +1100 [thread overview]
Message-ID: <0124da144de7ddce8d1fe6d4fd72a17c343a5f04.1581800613.git.fthain@telegraphics.com.au> (raw)
In-Reply-To: <cover.1581800613.git.fthain@telegraphics.com.au>
The explicit memory barriers are redundant now that proper locking and
MMIO accessors have been employed.
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
drivers/net/ethernet/natsemi/sonic.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/natsemi/sonic.c b/drivers/net/ethernet/natsemi/sonic.c
index 1d6de6706875..508c6a80fc6e 100644
--- a/drivers/net/ethernet/natsemi/sonic.c
+++ b/drivers/net/ethernet/natsemi/sonic.c
@@ -311,12 +311,10 @@ static int sonic_send_packet(struct sk_buff *skb, struct net_device *dev)
sonic_tda_put(dev, entry, SONIC_TD_LINK,
sonic_tda_get(dev, entry, SONIC_TD_LINK) | SONIC_EOL);
- wmb();
lp->tx_len[entry] = length;
lp->tx_laddr[entry] = laddr;
lp->tx_skb[entry] = skb;
- wmb();
sonic_tda_put(dev, lp->eol_tx, SONIC_TD_LINK,
sonic_tda_get(dev, lp->eol_tx, SONIC_TD_LINK) & ~SONIC_EOL);
lp->eol_tx = entry;
--
2.24.1
next prev parent reply other threads:[~2020-02-15 21:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 21:03 [PATCH net-next 0/7] Improvements for SONIC ethernet drivers Finn Thain
2020-02-15 21:03 ` [PATCH net-next 2/7] net/sonic: Refactor duplicated code Finn Thain
2020-02-15 21:03 ` [PATCH net-next 7/7] net/macsonic: Remove interrupt handler wrapper Finn Thain
2020-02-15 21:03 ` [PATCH net-next 6/7] net/sonic: Start packet transmission immediately Finn Thain
2020-02-15 21:03 ` [PATCH net-next 1/7] net/sonic: Remove obsolete comment Finn Thain
2020-02-15 21:03 ` Finn Thain [this message]
2020-02-15 21:03 ` [PATCH net-next 3/7] net/sonic: Remove redundant next_tx variable Finn Thain
2020-02-15 21:03 ` [PATCH net-next 4/7] net/sonic: Remove redundant netif_start_queue() call Finn Thain
2020-02-17 3:49 ` [PATCH net-next 0/7] Improvements for SONIC ethernet drivers David Miller
-- strict thread matches above, loose matches on Subject: below --
2020-02-10 21:18 Finn Thain
2020-02-10 21:18 ` [PATCH net-next 5/7] net/sonic: Remove explicit memory barriers Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0124da144de7ddce8d1fe6d4fd72a17c343a5f04.1581800613.git.fthain@telegraphics.com.au \
--to=fthain@telegraphics.com.au \
--cc=chris@zankel.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®