From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E67913655D5 for ; Fri, 22 May 2026 07:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779435306; cv=none; b=nEOCcmCwdH9EGzm3z8XGBMFciPJ7aXgX+Wmozj5cbfO2tHvMk8+lNni6YYraplacVFbRRnQ8lsdQbKS26RpYidF2f5CSIBzuiVkSQBkYFa8KDPkXGgSu7elgNwfiYW9oMH2sisyuEWzuRPvtcq0s/mvpRwZQOmTWat3rn139rqU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779435306; c=relaxed/simple; bh=7Tp8QR8ezREidBdZtgOBqXf3WM+ajNf36iDwZT850qg=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=Zp/WW/+bWOENcfzjCGqegoPGfxbYoZkdUDSq0BSybXGGRV4KC1ZRDC4gSJ8+WSuxnLvBRAnKYv6pwKXlwWXW5FTpWdjW7hz9lphAmcxblAlDcwH5+iLth94E7NTFjObOsiK002rp/puaXsA2Yv4bgfAJpi+Mv6NN/xr4dmHvGyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JfqXL8ZI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bYWRMKCd; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JfqXL8ZI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bYWRMKCd" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64M3PrrQ399102 for ; Fri, 22 May 2026 07:35:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2b+Kij9t1IVCxFpBqd1qEHIqo7GSLvjCvGFJYZ65lN0=; b=JfqXL8ZIUCe2Ii7p nwcC5qhqYp/OKR5a6KsdZICVLwTzqXeqTFKJIl2XWyrDe4BgDqGltFdpklJxJ4q8 bwpw3iUQk1aVO0QoIS3sUbEZfHdoARUfJqJGdNNKaTFDml2M9PTCULj3Pxi62qhQ 5fexdklrqG2E4O/OzjG4iuPeRL1OBdDrc192ghJ6g8LGKBOXKalRW4sk5aQwv+/n MybrvN1Pt44DJOsBJzj+kqOGaZEtVBpPfbie6vXxU+amSObaIfhLXVbwoge0+UtO o30L4OTNUk55Uoo1Lj8GiRyGxrOc650G9wG8Bl4zVVQgvXhCoHxfp3UDF3rFqhN6 LY8L8g== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ea5p9u00g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 07:35:04 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-367bb9caa54so6320520a91.2 for ; Fri, 22 May 2026 00:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779435303; x=1780040103; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:cc:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=2b+Kij9t1IVCxFpBqd1qEHIqo7GSLvjCvGFJYZ65lN0=; b=bYWRMKCd0+fuB016zPpJUBJKPoanbg46b6zs02eT8j/8dJzV2LFGLyfosetExKYvf5 ftFQDFr6wzGOoeyZO2+IWgU739ZK2h33KA/S/LTzZiJFwQ3+pqRNeB7zBZQAdMdNXDh2 nDoqfPCPimyEBvYBRRickieH7tc2497a7XEmz/RBrQ5YOm3bT6/cz/MkU88+KQzJo1Le vEM846dZOnIzjlmWZWqOvR19GRHnjcCbxJJEShvg5KVeHNK0Q6PYfjZWK6V0TTAkvqas Ft6qc37k3OYgHVUToZKWouDaaWnqqtJXjGg+IQzjpH6a+gc4avCyKimtCYPjlyLCig2k HUfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779435303; x=1780040103; h=content-transfer-encoding:in-reply-to:cc:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2b+Kij9t1IVCxFpBqd1qEHIqo7GSLvjCvGFJYZ65lN0=; b=HPOLFveLk1hVxhOKLYq7HxvWkh2qKxnmvhx0844iuEo07ZqKhyExnu/EjlV1N3UqiE 4PJhW05RxYoHYxVaxOZt0IMhz4D7P9qqFo55DAxgV+cROpkOSKTMdbNT6XYfcZO2U3ND 804YNAkMq5rzbDsipaR2P0i5hrkohSx+mf8IReVnSyCPvj82S0bRoD5Fqjp88TcosYO7 V7BdEoLpwn6kk+Pw0rXUKGf/mpZuouHaTMaU60+FDavLXov3kK40dydw7gncuf5pX/xG txVmjwyXpDqjckqqGYvF5WPFIMGvu+GdNZoH3j8GfAWhePSwRIdCUm+fDza9mMeazqag 6NQQ== X-Forwarded-Encrypted: i=1; AFNElJ9HF//14GOT0fVAd+knUWCbqil+h7LBalpBbjt5oa+wvG9/4PYez7ZLcrax+LTNePgbYsUl/laqqQ9tZfA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyf3Qsk91Odsx6e0IuUMKtDD+k5tgdwP5h5qPSCPu+xk9XQe/vM Sb/LgdKxN3T97DqZUBje0I8PUkX0zF5T6gQuozPp2h4FBnHvZgTEba+mMlToRJRhTcQH4jV4Oci 2HCnQP133ELX8AbYy23Bj5QaL470m4Ia5aa3da9CUV7PzJHtvOZ+4CSQhLddJmAZvXfQ= X-Gm-Gg: Acq92OEPbS6++c7sIafYC9GmR8iy2G0Npf3r/O1w/gBE+jBnSq0a8lNQT8lQJeBMw8L mbPBMK+1fLbC2N5l/hCVwfI4Jf5JepGArlM7KxNWyfF0uvQzF8qMKGTHnjhaxhPbUp72twE7YAH C1t8Ft3gSAOex+ZzNdl4bAPIGAJdkW42kXSDgi/OM59wvvCWTsav4cYj/FAjIPl+ZYMRSA0oP08 rp8hKsmWIkpSBtQsFX+e2w4Ac0/APSUkQDwu2+nz+tqX7yxsFXFaSsx7fkmuR2zrdmdWw5cMfui LQYME2rhmAdpnwdD3PkTxjcQEpzaVoDnzAkGenqEaq+WgLoBq2LFRpY/QoYVwMcgjLA3t3I4ETt 3nqnfWm/dFhhop0FYbjNF3qv4vBC4rhTnT58TWEHU+JxouidcJIuVp13jGalfQNMZ15yA9vwcFG ERnLJFa8QquGMHSquo X-Received: by 2002:a17:90b:1b47:b0:366:3517:1aa2 with SMTP id 98e67ed59e1d1-36a671e9069mr2466554a91.0.1779435303367; Fri, 22 May 2026 00:35:03 -0700 (PDT) X-Received: by 2002:a17:90b:1b47:b0:366:3517:1aa2 with SMTP id 98e67ed59e1d1-36a671e9069mr2466542a91.0.1779435302884; Fri, 22 May 2026 00:35:02 -0700 (PDT) Received: from [10.133.33.160] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a67c4afc6sm579351a91.5.2026.05.22.00.34.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 00:35:02 -0700 (PDT) Message-ID: <01407473-1fa6-45ca-83c7-090c0c935684@oss.qualcomm.com> Date: Fri, 22 May 2026 15:34:56 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/5] misc: fastrpc: Fail Audio PD init when reserved memory is missing To: Dmitry Baryshkov References: <20260515124217.20723-1-jianping.li@oss.qualcomm.com> <20260515124217.20723-4-jianping.li@oss.qualcomm.com> <5rpyaoyx3dsf3c7llnt57uukeaef2qgget42itfc45tura5esy@b4cwvazm42uo> Content-Language: en-US From: Jianping Li Cc: srini@kernel.org, amahesh@qti.qualcomm.com, arnd@arndb.de, gregkh@linuxfoundation.org, abelvesa@kernel.org, jorge.ramirez-ortiz@linaro.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ekansh Gupta , stable@kernel.org, quic_chennak@quicinc.com In-Reply-To: <5rpyaoyx3dsf3c7llnt57uukeaef2qgget42itfc45tura5esy@b4cwvazm42uo> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=DKm/JSNb c=1 sm=1 tr=0 ts=6a100728 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=uBSpvLV6fhDO0Xk4A2gA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: 07Ty-gmMYVwQm1XTLkT0sdEq4MpiQNKy X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDA3MyBTYWx0ZWRfX7QD+tVums++Q jh+sLQTDyInl8cTKaEMRNr9dqE2WvYyOhMlNH4dl8RSeMGNp0gkZNW5h45cyVeFCHYVb7toGlTX eGuejQn9NLTC3zEtmRIUMf0NmxzO+OaqLHt5/4ctiMLPCJcGf7gRD9oYpYVKHuSKLZQPLPTrLZ2 ZpaW+P9ga2cHmnJTxqqM6JuXVve1YA6VtPk6ywFyUQvO0bwq4yNisDb9AvWc8FHGTz1nQqjTuab pmuFxpe3twQwAMWJ6ExjnKlkRtAH9HoSsXWWIfZWEYvVvypPGeS2i8r5W9IjVs9QFGG/oD7j53h AFrnUW8+2UH6LMOdE5PUMswk/GRwbo5YkCfNw7vh9+jFiImCV4x5miibFdiqkYy/0Kil4xxj29s 7NrA+o5iyY5EmOXfSfFEzUx9gIOwHrwiZTC2iTuBYK7ILzqnBr9ZzjPrODK/jhApk1orYyfwfyr zWmnTQ0FUFMuPUS/LKQ== X-Proofpoint-ORIG-GUID: 07Ty-gmMYVwQm1XTLkT0sdEq4MpiQNKy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220073 On 5/15/2026 9:37 PM, Dmitry Baryshkov wrote: > On Fri, May 15, 2026 at 08:42:15PM +0800, Jianping Li wrote: >> Audio PD static process creation assumes that a reserved-memory >> region is defined in DT and exposed via cctx->remote_heap. >> >> If reserved-memory is missing or incomplete, the driver may pass >> invalid address/size information to the DSP, leading to undefined >> behavior or crashes. >> >> Add explicit validation for remote_heap presence and size before >> sending the memory to DSP, and fail early if the configuration is >> invalid. >> >> Fixes: 0871561055e66 ("misc: fastrpc: Add support for audiopd") >> Cc: stable@kernel.org >> Signed-off-by: Jianping Li >> --- >> drivers/misc/fastrpc.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c >> index 3c7c3b410d7d..a0337cce77f3 100644 >> --- a/drivers/misc/fastrpc.c >> +++ b/drivers/misc/fastrpc.c >> @@ -1363,6 +1363,12 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl, >> args[1].length = inbuf.namelen; >> args[1].fd = -1; >> >> + if (!fl->cctx->remote_heap || >> + !fl->cctx->remote_heap->dma_addr || >> + !fl->cctx->remote_heap->size) { > I guess that !dma_addr || !size should fail much earlier than here. ACK > >> + err = -ENOMEM; >> + goto err; >> + } >> pages[0].addr = fl->cctx->remote_heap->dma_addr; >> pages[0].size = fl->cctx->remote_heap->size; >> >> -- >> 2.43.0 >>