mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Meghana Madhyastha <meghana.madhyastha@gmail.com>
To: "Lee Jones" <lee.jones@linaro.org>,
	"Daniel Thompson" <daniel.thompson@linaro.org>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Daniel Vetter" <daniel.vetter@intel.com>,
	"Sean Paul" <seanpaul@chromium.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH v18 05/10] video: backlight: Add devres versions of of_find_backlight
Date: Mon, 22 Jan 2018 14:52:44 +0000	[thread overview]
Message-ID: <021f8fecfa3f374dc5dcb70fb07a6f6b019bea7b.1516632388.git.meghana.madhyastha@gmail.com> (raw)
In-Reply-To: <cover.1516632387.git.meghana.madhyastha@gmail.com>

Add devm_of_find_backlight and the corresponding release
function because some drivers use devres versions of functions
for acquiring device resources.

Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
---
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Sean Paul<seanpaul@chromium.org>

 drivers/video/backlight/backlight.c | 30 ++++++++++++++++++++++++++++++
 include/linux/backlight.h           |  7 +++++++
 2 files changed, 37 insertions(+)

diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
index 553bf5c48..deb824bef 100644
--- a/drivers/video/backlight/backlight.c
+++ b/drivers/video/backlight/backlight.c
@@ -623,6 +623,36 @@ struct backlight_device *of_find_backlight(struct device *dev)
 }
 EXPORT_SYMBOL(of_find_backlight);
 
+static void devm_backlight_release(void *data)
+{
+	backlight_put(data);
+}
+
+/**
+ * devm_of_find_backlight - Resource-managed of_find_backlight()
+ * @dev: Device
+ *
+ * Device managed version of of_find_backlight().
+ * The reference on the backlight device is automatically
+ * dropped on driver detach.
+ */
+struct backlight_device *devm_of_find_backlight(struct device *dev)
+{
+	struct backlight_device *bd;
+	int ret;
+
+	bd = of_find_backlight(dev);
+	if (IS_ERR_OR_NULL(bd))
+		return bd;
+	ret = devm_add_action(dev, devm_backlight_release, bd);
+	if (ret) {
+		backlight_put(bd);
+		return ERR_PTR(ret);
+	}
+	return bd;
+}
+EXPORT_SYMBOL(devm_of_find_backlight);
+
 static void __exit backlight_class_exit(void)
 {
 	class_destroy(backlight_class);
diff --git a/include/linux/backlight.h b/include/linux/backlight.h
index ddc9bade4..2baab6f38 100644
--- a/include/linux/backlight.h
+++ b/include/linux/backlight.h
@@ -217,11 +217,18 @@ of_find_backlight_by_node(struct device_node *node)
 
 #if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)
 struct backlight_device *of_find_backlight(struct device *dev);
+struct backlight_device *devm_of_find_backlight(struct device *dev);
 #else
 static inline struct backlight_device *of_find_backlight(struct device *dev)
 {
 	return NULL;
 }
+
+static inline struct backlight_device *
+devm_of_find_backlight(struct device *dev)
+{
+	return NULL;
+}
 #endif
 
 #endif
-- 
2.11.0

  parent reply	other threads:[~2018-01-22 14:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 14:48 [PATCH v18 00/10] Add backlight helper functions Meghana Madhyastha
2018-01-22 14:49 ` [PATCH v18 01/10] video: backlight: Add helpers to enable and disable backlight Meghana Madhyastha
2018-01-23 10:00   ` Daniel Thompson
2018-01-23 14:47     ` Noralf Trønnes
2018-01-22 14:50 ` [PATCH v18 02/10] drm/tinydrm: Convert tinydrm_enable/disable_backlight to backlight_enable/disable Meghana Madhyastha
2018-01-22 14:51 ` [PATCH v18 03/10] video: backlight: Add of_find_backlight helper in backlight.c Meghana Madhyastha
2018-01-28 17:15   ` Andy Shevchenko
2018-01-22 14:51 ` [PATCH v18 04/10] drm/tinydrm: Replace tinydrm_of_find_backlight with of_find_backlight Meghana Madhyastha
2018-01-22 14:52 ` Meghana Madhyastha [this message]
2018-01-22 14:53 ` [PATCH v18 06/10] drm/tinydrm: Call devres version of of_find_backlight Meghana Madhyastha
2018-01-22 14:54 ` [PATCH v18 07/10] drm/panel: Use backlight_enable/disable helpers Meghana Madhyastha
2018-01-23 14:19   ` Noralf Trønnes
2018-01-22 14:54 ` [PATCH v18 08/10] drm/omapdrm: " Meghana Madhyastha
2018-01-23 14:20   ` Noralf Trønnes
2018-01-22 14:55 ` [PATCH v18 09/10] drm/panel: Use of_find_backlight helper Meghana Madhyastha
2018-01-23 14:24   ` Noralf Trønnes
2018-01-22 14:56 ` [PATCH v18 10/10] drm/omapdrm: " Meghana Madhyastha
2018-01-23 14:37   ` Noralf Trønnes
2018-01-23 16:55     ` Meghana Madhyastha
2018-01-23 17:41       ` Noralf Trønnes
2018-01-23 17:43         ` Noralf Trønnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=021f8fecfa3f374dc5dcb70fb07a6f6b019bea7b.1516632388.git.meghana.madhyastha@gmail.com \
    --to=meghana.madhyastha@gmail.com \
    --cc=daniel.thompson@linaro.org \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noralf@tronnes.org \
    --cc=seanpaul@chromium.org \
    --cc=thierry.reding@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®