From: Zefir Kurtisi <zefir.kurtisi@neratec.com>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
"David S. Miller" <davem@davemloft.net>,
Fugang Duan <fugang.duan@nxp.com>,
Troy Kisky <troy.kisky@boundarydevices.com>,
Andrew Lunn <andrew@lunn.ch>, Eric Nelson <eric@nelint.com>,
Philippe Reynes <tremyfr@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
netdev@vger.kernel.org
Cc: Chris Healy <cphealy@gmail.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch net / RFC] net: fec: increase frame size limitation to actually available buffer
Date: Wed, 30 Nov 2016 17:05:09 +0100 [thread overview]
Message-ID: <05a7c0a7-b680-af75-963b-5cddeda7f2c4@neratec.com> (raw)
In-Reply-To: <1480444528-30054-1-git-send-email-nikita.yoush@cogentembedded.com>
On 11/29/2016 07:35 PM, Nikita Yushchenko wrote:
> Fec driver uses Rx buffers of 2k, but programs hardware to limit
> incoming frames to 1522 bytes. This raises issues when FEC device
> is used with DSA (since DSA tag can make frame larger), and also
> disallows manual sending and receiving larger frames.
>
> This patch removes the limitation, allowing Rx size up to entire buffer.
> At the same time possible Tx size is increased as well, because hardware
> uses the same register field to limit Rx and Tx.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> ---
I recently did similar changes to the freescale/gianfar to prevent fragmentation
of (E)DSA frames [1].
With the fragmentation kicking in, I noticed a bug in the scatter-gather logic
which caused the frame-size of fragmented frames to be reported wrong [2]. Not
sure if the fec driver has SG capabilities and if this issue also applies, you
might want to double-check.
Cheers,
Zefir
[1] http://marc.info/?l=linux-netdev&m=147187438313519&w=2
[2] http://marc.info/?l=linux-netdev&m=147187430213484&w=2
prev parent reply other threads:[~2016-11-30 16:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 18:35 Nikita Yushchenko
2016-11-30 2:37 ` Andy Duan
2016-11-30 6:36 ` Nikita Yushchenko
2016-11-30 7:25 ` Toshiaki Makita
2016-11-30 14:58 ` DSA vs envelope frames Nikita Yushchenko
2016-11-30 15:10 ` Andrew Lunn
2016-12-01 3:26 ` Florian Fainelli
2016-12-01 12:46 ` Toshiaki Makita
2016-11-30 7:35 ` [patch net / RFC] net: fec: increase frame size limitation to actually available buffer Andy Duan
2016-11-30 16:05 ` Zefir Kurtisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05a7c0a7-b680-af75-963b-5cddeda7f2c4@neratec.com \
--to=zefir.kurtisi@neratec.com \
--cc=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=eric@nelint.com \
--cc=fabio.estevam@nxp.com \
--cc=fugang.duan@nxp.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=tremyfr@gmail.com \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®