mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fan Wu <12321260@zju.edu.cn>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Fan Wu <fanwu01@zju.edu.cn>,
	jirislaby@kernel.org, broonie@kernel.org, zhao.xicheng@vivo.com,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] tty: serial: max3100: shut down timer before freeing port
Date: Tue, 4 Aug 2026 17:15:50 +0800	[thread overview]
Message-ID: <0FEECD29-C7BE-4D4D-8441-3F8BA3C55902@zju.edu.cn> (raw)
In-Reply-To: <2026080353-bats-jailhouse-804f@gregkh>

Hi Greg,

Sorry, I don't have MAX3100 hardware, so I have not tested this on
hardware.

You're right about the extra state. I'll rework the cleanup to use the
existing startup/unwind state instead of adding irq_registered, then
send v3 after rebuilding it.

Thanks,
Fan

> On Aug 3, 2026, at 20:56, Greg KH <gregkh@linuxfoundation.org> wrote:

> LLMs _love_ to use boolean flags to attempt to figure things out that
> they can't seem to determine.  Are you _SURE_ this really is needed?
> How about unwinding things better so it's not required?  You are just
> adding another "state" to the device, adding to the complexity overall,
> which is generally not a good idea.
> 
> And do you have this hardware to test this with?
> 
> thanks,
> 
> greg k-h


  reply	other threads:[~2026-08-04  9:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21  3:56 [PATCH] tty: serial: max3100: drain async producers in remove() to fix timer UAF Fan Wu
2026-07-30 14:39 ` Greg KH
2026-07-31  2:46   ` Fan Wu
2026-08-01  6:12   ` [PATCH v2] tty: serial: max3100: shut down timer before freeing port Fan Wu
2026-08-03 12:56     ` Greg KH
2026-08-04  9:15       ` Fan Wu [this message]
2026-08-05  0:40       ` [PATCH v3] " Fan Wu
2026-09-23  9:50         ` Greg KH
2026-09-27  5:59           ` [PATCH v4] " Fan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0FEECD29-C7BE-4D4D-8441-3F8BA3C55902@zju.edu.cn \
    --to=12321260@zju.edu.cn \
    --cc=broonie@kernel.org \
    --cc=fanwu01@zju.edu.cn \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=zhao.xicheng@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®