From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABE04C0018C for ; Wed, 16 Dec 2020 11:59:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69FA0233A1 for ; Wed, 16 Dec 2020 11:59:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725864AbgLPL71 (ORCPT ); Wed, 16 Dec 2020 06:59:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725710AbgLPL71 (ORCPT ); Wed, 16 Dec 2020 06:59:27 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE7D9C06179C for ; Wed, 16 Dec 2020 03:58:46 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kpVS2-0002sK-N3; Wed, 16 Dec 2020 12:58:38 +0100 Message-ID: <0b69e6e96bfeb0410da7ca572cd4b78fffce91c2.camel@pengutronix.de> Subject: Re: [PATCH v2 1/1] phy: fsl-imx8-mipi-dphy: Hook into runtime pm From: Lucas Stach To: Guido =?ISO-8859-1?Q?G=FCnther?= , Kishon Vijay Abraham I , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Robert Chiras , Sam Ravnborg , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Wed, 16 Dec 2020 12:58:36 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.2 (3.38.2-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guido, Am Mittwoch, dem 16.12.2020 um 12:27 +0100 schrieb Guido Günther: This allows us to shut down the mipi power domain on the imx8. The alternative would be to drop the dphy from the mipi power domain in the SOCs device tree and only have the DSI host controller visible there but since the PD is mostly about the PHY that would defeat it's purpose. Adding RPM support is exactly the right course of action. This allows to shut off the power domain hen blanking the LCD panel: pm_genpd_summary before: domain status slaves     /device runtime status ---------------------------------------------------------------------- mipi on     /devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy unsupported     /devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_dsi suspended after: mipi off-0     /devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy suspended     /devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_dsi suspended Signed-off-by: Guido Günther ---  .../phy/freescale/phy-fsl-imx8-mipi-dphy.c | 22 ++++++++++++++++++-  1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c index a95572b397ca..34e2d801e520 100644 --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c @@ -14,6 +14,7 @@  #include  #include  #include +#include  #include    /* DPHY registers */ @@ -93,6 +94,7 @@ struct mixel_dphy_cfg {  };    struct mixel_dphy_priv { + struct device *dev;   struct mixel_dphy_cfg cfg;   struct regmap *regmap;   struct clk *phy_ref_clk; @@ -382,6 +384,7 @@ static int mixel_dphy_power_on(struct phy *phy)   ret = clk_prepare_enable(priv->phy_ref_clk);   if (ret < 0)   return ret; + pm_runtime_get_sync(priv->dev); This call can fail and will leave you with an elevated rpm refcount. Better use the new pm_runtime_resume_and_get to avoid this issue?  Nitpick: I would add a blank line before the call. Regards, Lucas     phy_write(phy, PWR_ON, DPHY_PD_PLL);   ret = regmap_read_poll_timeout(priv->regmap, DPHY_LOCK, locked, @@ -395,6 +398,7 @@ static int mixel_dphy_power_on(struct phy *phy)     return 0;  clock_disable: + pm_runtime_put(priv->dev);   clk_disable_unprepare(priv->phy_ref_clk);   return ret;  } @@ -406,6 +410,7 @@ static int mixel_dphy_power_off(struct phy *phy)   phy_write(phy, PWR_OFF, DPHY_PD_PLL);   phy_write(phy, PWR_OFF, DPHY_PD_DPHY);   + pm_runtime_put(priv->dev);   clk_disable_unprepare(priv->phy_ref_clk);     return 0; @@ -467,6 +472,7 @@ static int mixel_dphy_probe(struct platform_device *pdev)   dev_dbg(dev, "phy_ref clock rate: %lu\n",   clk_get_rate(priv->phy_ref_clk));   + priv->dev = dev;   dev_set_drvdata(dev, priv);     phy = devm_phy_create(dev, np, &mixel_dphy_phy_ops); @@ -477,12 +483,26 @@ static int mixel_dphy_probe(struct platform_device *pdev)   phy_set_drvdata(phy, priv);     phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); + if (IS_ERR(phy_provider)) + return PTR_ERR(phy_provider);   - return PTR_ERR_OR_ZERO(phy_provider); + pm_runtime_enable(dev); + + return 0; +} + +static int mixel_dphy_remove(struct platform_device *pdev) +{ + struct mixel_dphy_priv *priv = platform_get_drvdata(pdev); + + pm_runtime_disable(priv->dev); + + return 0;  }    static struct platform_driver mixel_dphy_driver = {   .probe = mixel_dphy_probe, + .remove = mixel_dphy_remove,   .driver = {   .name = "mixel-mipi-dphy",   .of_match_table = mixel_dphy_of_match,