From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
Andrea Gelmini <andrea.gelmini@gelma.net>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
"Noam Camus" <noamc@ezchip.com>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: ARC-setup: Use seq_putc() in show_cpuinfo()
Date: Mon, 17 Oct 2016 10:23:39 -0700 [thread overview]
Message-ID: <10542905-ebe1-49f5-190b-3783137e7854@synopsys.com> (raw)
In-Reply-To: <d8738585-21f3-8691-4c53-bfbafef925be@users.sourceforge.net>
On 10/17/2016 10:19 AM, SF Markus Elfring wrote:
>>> A single character (line break) should be put into a sequence.
>>> Thus use the corresponding function "seq_putc".
>> Perhaps reword the changelog to say that seqc_putc is more efficient than
>> seqc_printf to output a single char.
>> I mean _printf is not wrong but not as efficient ?
> I came along source files for a few other software modules with similar
> change possibilities.
> Unfortunately, the corresponding developers are not convinced yet
> to replace a call of the function "seq_printf" at the end by
> a "seq_putc" because of software efficiency reasons.
I was ambivalent so far - but not anymore :-)
what is the objection - can you point me to a few links where people don't think
this is not a good idea.
> Do you find this update suggestion acceptable to some degree
> for the function "setup"?
>
> Regards,
> Markus
>
next prev parent reply other threads:[~2016-10-17 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 19:56 [PATCH] " SF Markus Elfring
2016-10-17 16:25 ` Vineet Gupta
2016-10-17 17:19 ` SF Markus Elfring
2016-10-17 17:23 ` Vineet Gupta [this message]
2016-10-17 17:39 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10542905-ebe1-49f5-190b-3783137e7854@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=andrea.gelmini@gelma.net \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=noamc@ezchip.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®