From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
To: Xen-devel <xen-devel@lists.xensource.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kurt.hackel@oracle.com,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Keir Fraser <keir.fraser@eu.citrix.com>,
Glauber de Oliveira Costa <gcosta@redhat.com>,
Avi Kivity <avi@redhat.com>, Zach Brown <zach.brown@oracle.com>,
the arch/x86 maintainers <x86@kernel.org>,
Chris Mason <chris.mason@oracle.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Subject: [PATCH 1/5] x86/pvclock: make sure rdtsc doesn't speculate out of region
Date: Mon, 5 Oct 2009 17:50:07 -0700 [thread overview]
Message-ID: <1254790211-15416-2-git-send-email-jeremy.fitzhardinge@citrix.com> (raw)
In-Reply-To: <1254790211-15416-1-git-send-email-jeremy.fitzhardinge@citrix.com>
rdtsc is not necessarily ordered with surrounding instructions so we
need to make sure that it doesn't get sampled out of order with
respect to reading the time_info.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
---
arch/x86/kernel/pvclock.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/pvclock.c b/arch/x86/kernel/pvclock.c
index 03801f2..963f349 100644
--- a/arch/x86/kernel/pvclock.c
+++ b/arch/x86/kernel/pvclock.c
@@ -117,10 +117,10 @@ cycle_t pvclock_clocksource_read(struct pvclock_vcpu_time_info *src)
do {
version = pvclock_get_time_values(&shadow, src);
- barrier();
+ rdtsc_barrier();
offset = pvclock_get_nsec_offset(&shadow);
ret = shadow.system_timestamp + offset;
- barrier();
+ rdtsc_barrier();
} while (version != src->version);
return ret;
--
1.6.2.5
next prev parent reply other threads:[~2009-10-06 0:50 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 0:50 [PATCH RFC] Extending pvclock down to usermode for vsyscall Jeremy Fitzhardinge
2009-10-06 0:50 ` Jeremy Fitzhardinge [this message]
2009-10-06 0:50 ` [PATCH 2/5] x86/pvclock: no need to use strong read barriers in pvclock_get_time_values Jeremy Fitzhardinge
2009-10-06 0:50 ` [PATCH 3/5] x86/pvclock: add vsyscall implementation Jeremy Fitzhardinge
2009-10-06 9:04 ` Avi Kivity
2009-10-06 14:19 ` Dan Magenheimer
2009-10-06 15:11 ` Avi Kivity
2009-10-06 18:46 ` [Xen-devel] " Jeremy Fitzhardinge
2009-10-07 10:25 ` Avi Kivity
2009-10-07 19:29 ` Jeremy Fitzhardinge
2009-10-07 20:09 ` Avi Kivity
2009-10-07 21:19 ` Jeremy Fitzhardinge
2009-10-07 21:37 ` Avi Kivity
2009-10-07 21:51 ` Jeremy Fitzhardinge
2009-10-07 21:53 ` Avi Kivity
2009-10-07 20:48 ` Dan Magenheimer
2009-10-07 21:08 ` Avi Kivity
2009-10-07 22:36 ` Dan Magenheimer
2009-10-10 0:24 ` Jeremy Fitzhardinge
2009-10-10 18:10 ` Avi Kivity
2009-10-12 18:20 ` Jeremy Fitzhardinge
2009-10-12 18:29 ` Avi Kivity
2009-10-12 19:13 ` Jeremy Fitzhardinge
2009-10-13 6:39 ` Avi Kivity
2009-10-13 20:00 ` Jeremy Fitzhardinge
2009-10-14 12:32 ` Avi Kivity
2009-10-15 19:17 ` Jeremy Fitzhardinge
2009-10-27 17:29 ` Dan Magenheimer
2009-10-27 18:20 ` Jeremy Fitzhardinge
2009-10-28 5:52 ` Avi Kivity
2009-10-28 9:29 ` Glauber Costa
2009-10-28 9:34 ` Avi Kivity
2009-10-28 17:47 ` Jeremy Fitzhardinge
2009-10-29 12:13 ` Avi Kivity
2009-10-29 13:03 ` Chris Mason
2009-10-29 14:46 ` Dan Magenheimer
2009-10-29 15:07 ` Avi Kivity
2009-10-29 15:55 ` Dan Magenheimer
2009-10-29 16:15 ` Dan Magenheimer
2009-11-01 9:28 ` Avi Kivity
2009-11-02 15:28 ` Dan Magenheimer
2009-11-02 15:41 ` Avi Kivity
2009-11-01 9:32 ` Avi Kivity
2009-11-02 15:46 ` Dan Magenheimer
2009-11-03 5:12 ` Avi Kivity
2009-11-04 20:30 ` Dan Magenheimer
2009-11-05 6:47 ` Avi Kivity
2009-11-05 14:52 ` Dan Magenheimer
2009-11-05 15:07 ` Keir Fraser
2009-11-04 21:19 ` john stultz
2009-11-04 21:28 ` Dan Magenheimer
2009-11-05 0:02 ` john stultz
2009-11-05 0:45 ` Dan Magenheimer
2009-10-06 0:50 ` [PATCH 4/5] x86/fixmap: add a predicate for usermode fixmaps Jeremy Fitzhardinge
2009-10-06 10:23 ` [Xen-devel] " Jan Beulich
2009-10-06 18:47 ` Jeremy Fitzhardinge
2009-10-06 0:50 ` [PATCH 5/5] xen/time: add pvclock_clocksource_vread support Jeremy Fitzhardinge
2009-10-06 10:28 ` [Xen-devel] " Jan Beulich
2009-10-06 18:48 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254790211-15416-2-git-send-email-jeremy.fitzhardinge@citrix.com \
--to=jeremy.fitzhardinge@citrix.com \
--cc=avi@redhat.com \
--cc=chris.mason@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=gcosta@redhat.com \
--cc=keir.fraser@eu.citrix.com \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®