mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joerg Roedel <joerg.roedel@amd.com>
To: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Cc: Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 5/7] x86/amd-iommu: Add function to commit domain changes
Date: Thu, 11 Feb 2010 15:33:15 +0100	[thread overview]
Message-ID: <1265898797-32183-6-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1265898797-32183-1-git-send-email-joerg.roedel@amd.com>

This patch adds the function iommu_update_domain() which
makes sure that the hardware caches are in sync with the
software changes. This function is used in the iommu-api
path.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 arch/x86/kernel/amd_iommu.c |   15 +++++++++------
 1 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index bda00f0..4063f55 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -761,6 +761,13 @@ static void iommu_update_domain_dte(struct protection_domain *domain)
 	domain->flush.dte = false;
 }
 
+static void iommu_update_domain(struct protection_domain *domain)
+{
+	iommu_update_domain_dte(domain);
+	iommu_update_domain_tlb(domain, false);
+	iommu_flush_complete(domain);
+}
+
 /****************************************************************************
  *
  * The functions below are used the create the page table mappings for
@@ -899,8 +906,6 @@ static int iommu_map_page(struct protection_domain *dom,
 
 	*pte = __pte;
 
-	iommu_update_domain_dte(dom);
-
 	return 0;
 }
 
@@ -2495,8 +2500,7 @@ static int amd_iommu_map_range(struct iommu_domain *dom,
 	if (unlikely(amd_iommu_np_cache))
 		update_flush_info_tlb(domain, iova, iova + size);
 
-	iommu_update_domain_tlb(domain, true);
-	iommu_flush_complete(domain);
+	iommu_update_domain(domain);
 
 	return 0;
 }
@@ -2517,8 +2521,7 @@ static void amd_iommu_unmap_range(struct iommu_domain *dom,
 
 	update_flush_info_tlb(domain, iova, iova + size);
 
-	iommu_update_domain_tlb(domain, true);
-	iommu_flush_complete(domain);
+	iommu_update_domain(domain);
 }
 
 static phys_addr_t amd_iommu_iova_to_phys(struct iommu_domain *dom,
-- 
1.6.6



  parent reply	other threads:[~2010-02-11 14:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-11 14:33 [PATCH 0/7] amd iommu smart tlb flushing Joerg Roedel
2010-02-11 14:33 ` [PATCH 1/7] x86/amd-iommu: Add flush_info to protection domains Joerg Roedel
2010-02-11 16:40   ` Don Dutile
2010-02-11 16:45     ` Joerg Roedel
2010-02-11 14:33 ` [PATCH 2/7] x86/amd-iommu: Introduce iommu_update_domain_tlb function Joerg Roedel
2010-02-11 14:33 ` [PATCH 3/7] x86/amd-iommu: Move dte udpate flag into flush_info structure Joerg Roedel
2010-02-11 14:33 ` [PATCH 4/7] x86/amd-iommu: Move functions to get rid of forward declarations Joerg Roedel
2010-02-11 14:33 ` Joerg Roedel [this message]
2010-02-11 14:33 ` [PATCH 6/7] x86/amd-iommu: Introduce iommu_update_dma_ops_domain() Joerg Roedel
2010-02-11 14:33 ` [PATCH 7/7] x86/amd-iommu: Reimplement iommu_flush_tlb_pde using iommu_update_domain_tlb Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1265898797-32183-6-git-send-email-joerg.roedel@amd.com \
    --to=joerg.roedel@amd.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®