mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
	josh@joshtriplett.org, dvhltc@us.ibm.com, niv@us.ibm.com,
	tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org,
	Valdis.Kletnieks@vt.edu, dhowells@redhat.com,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 1/2] rcu: fix holdoff for accelerated GPs for last non-dynticked CPU
Date: Sat, 27 Feb 2010 14:53:07 -0800	[thread overview]
Message-ID: <1267311188-16603-1-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100227225240.GA16515@linux.vnet.ibm.com>

Make the holdoff only happen when the full number of attempts have been
made.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
 kernel/rcutree_plugin.h |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h
index 464ad2c..79b53bd 100644
--- a/kernel/rcutree_plugin.h
+++ b/kernel/rcutree_plugin.h
@@ -1010,6 +1010,10 @@ int rcu_needs_cpu(int cpu)
 	int c = 0;
 	int thatcpu;
 
+	/* Check for being in the holdoff period. */
+	if (per_cpu(rcu_dyntick_holdoff, cpu) == jiffies)
+		return rcu_needs_cpu_quick_check(cpu);
+
 	/* Don't bother unless we are the last non-dyntick-idle CPU. */
 	for_each_cpu_not(thatcpu, nohz_cpu_mask)
 		if (thatcpu != cpu) {
@@ -1041,10 +1045,8 @@ int rcu_needs_cpu(int cpu)
 	}
 
 	/* If RCU callbacks are still pending, RCU still needs this CPU. */
-	if (c) {
+	if (c)
 		raise_softirq(RCU_SOFTIRQ);
-		per_cpu(rcu_dyntick_holdoff, cpu) = jiffies;
-	}
 	return c;
 }
 
-- 
1.6.6


  reply	other threads:[~2010-02-27 22:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-27 22:52 [PATCH tip/core/rcu 0/2] more lockdep-RCU and RCU_FAST_NO_HZ fixes Paul E. McKenney
2010-02-27 22:53 ` Paul E. McKenney [this message]
2010-02-28  8:59   ` [tip:core/rcu] rcu: Fix holdoff for accelerated GPs for last non-dynticked CPU tip-bot for Paul E. McKenney
2010-03-16 11:00     ` Ingo Molnar
2010-03-16 11:03       ` Ingo Molnar
2010-03-16 11:51         ` Ingo Molnar
2010-03-16 12:15           ` Ingo Molnar
2010-03-16 13:30             ` Paul E. McKenney
2010-03-17 17:53         ` Ingo Molnar
2010-03-17 19:22           ` Paul E. McKenney
2010-03-17 19:35             ` Ingo Molnar
2010-02-27 22:53 ` [PATCH tip/core/rcu 2/2] rcu: make task_subsys_state() RCU-lockdep checks handle boot-time use Paul E. McKenney
2010-02-28  8:59   ` [tip:core/rcu] rcu: Make " tip-bot for Paul E. McKenney
2010-03-01 19:47     ` Paul Menage
2010-02-28  8:55 ` [PATCH tip/core/rcu 0/2] more lockdep-RCU and RCU_FAST_NO_HZ fixes Ingo Molnar
2010-02-28 16:32   ` Paul E. McKenney
2010-03-01  8:33     ` [tip:core/rcu] sched, rcu: Fix rcu_dereference() for RCU-lockdep tip-bot for Paul E. McKenney
2010-03-01 12:10     ` [PATCH tip/core/rcu 0/2] more lockdep-RCU and RCU_FAST_NO_HZ fixes Ingo Molnar
2010-03-01 16:08       ` Paul E. McKenney
2010-03-01 17:58         ` Peter Zijlstra
2010-03-01 18:50           ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1267311188-16603-1-git-send-email-paulmck@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=dvhltc@us.ibm.com \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mingo@elte.hu \
    --cc=niv@us.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®