mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tony Luck <tony.luck@gmail.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Patrick Mochel <mochel@digitalimplant.org>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] kill include/linux/platform.h
Date: Mon, 3 Oct 2005 12:01:08 -0700	[thread overview]
Message-ID: <12c511ca0510031201x1f66300bucaff6410e7b675bb@mail.gmail.com> (raw)
In-Reply-To: <20051001233414.GG4212@stusta.de>

> --- linux-2.6.14-rc2-mm2-full/arch/ia64/kernel/setup.c.old      2005-10-02 01:09:11.000000000 +0200
> +++ linux-2.6.14-rc2-mm2-full/arch/ia64/kernel/setup.c  2005-10-02 01:09:15.000000000 +0200
> @@ -41,7 +41,6 @@
>  #include <linux/serial_core.h>
>  #include <linux/efi.h>
>  #include <linux/initrd.h>
> -#include <linux/platform.h>
>  #include <linux/pm.h>
>
>  #include <asm/ia32.h>

NAK.  Without <linux/platform.h> ia64 doesn't compile:

  CC      arch/ia64/kernel/setup.o
arch/ia64/kernel/setup.c: In function `cpu_init':
arch/ia64/kernel/setup.c:855: error: `default_idle' undeclared (first
use in this function)
arch/ia64/kernel/setup.c:855: error: (Each undeclared identifier is
reported only once
arch/ia64/kernel/setup.c:855: error: for each function it appears in.)
make[1]: *** [arch/ia64/kernel/setup.o] Error 1
make: *** [arch/ia64/kernel] Error 2

So you will need to add a:

extern void default_idle(void );

some place in setup.c to fix this.

-Tony

  reply	other threads:[~2005-10-03 19:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-02 20:52 2.6: is include/linux/platform.h a dead header? Adrian Bunk
     [not found] ` <Pine.LNX.4.50.0509291106520.29808-100000@monsoon.he.net>
2005-10-01 23:34   ` [2.6 patch] kill include/linux/platform.h Adrian Bunk
2005-10-03 19:01     ` Tony Luck [this message]
2005-10-03 19:03       ` Adrian Bunk
2005-10-03 21:07         ` Tony Luck
2005-10-03 21:50           ` Adrian Bunk
2005-10-10 18:23             ` Andrew Morton
2005-11-03 18:23               ` Adrian Bunk
2005-11-08 19:46                 ` Patrick Mochel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12c511ca0510031201x1f66300bucaff6410e7b675bb@mail.gmail.com \
    --to=tony.luck@gmail.com \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@digitalimplant.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®