mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sohil Mehta <sohil.mehta@intel.com>
To: "Chang S. Bae" <chang.seok.bae@intel.com>, <kvm@vger.kernel.org>,
	<x86@kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H . Peter Anvin" <hpa@zytor.com>, Xin Li <xin@zytor.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	"Tom Lendacky" <thomas.lendacky@amd.com>,
	Nikunj A Dadhania <nikunj@amd.com>,
	Shivansh Dhiman <shivansh.dhiman@amd.com>,
	David Woodhouse <dwmw@amazon.co.uk>,
	Chao Gao <chao.gao@intel.com>,
	Binbin Wu <binbin.wu@linux.intel.com>,
	Zhao Liu <zhao1.liu@intel.com>, Yosry Ahmed <yosry@kernel.org>,
	David Matlack <dmatlack@google.com>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v10 00/28] KVM: Enable FRED support with KVM VMX
Date: Wed, 18 Nov 2026 02:01:37 -0800	[thread overview]
Message-ID: <12f686a4-a9f8-4347-a7f4-c0f893addfb9@intel.com> (raw)
In-Reply-To: <609c2e22-db8f-417a-93b6-c4fcafe79bc1@intel.com>

On 10/30/2026 1:53 PM, Chang S. Bae wrote:
> On 9/11/2026 2:36 PM, Sohil Mehta wrote:
>>
>> Patch structure
>> ---------------
> 
> So I'm more interested in how those pieces could be organized to make
> easier to follow, review, and integrate going forward.

Thanks! This is good feedback. I've been thinking about splitting and
making this easier to review as well.

> 
>> Patches   1-6: Enable the VMX controls and export the host stacks
> 
> These seem to be preparatory changes for supporting the state and
> extending event delivery later in this series.
> 
> Would it make sense to put the x86 core preparation up front rather than
> having it in the middle of the KVM changes?
> 

Sure, I can move the x86 preparatory changes to the front of the series.

Actually, some of the x86 patches are good cleanups independent of the
FRED KVM support. I am thinking of posting them separately and maybe
those can be merged sooner to reduce the load on this series.

As you suggested below, it would be great if we can separate out the
nested VMX support as well. But there are issues (like the one discussed
in patch 19) that link the L1 guest support with the nested support.

I believe if we separate out the secondary VM-exit controls
infrastructure (L1 and nested - independent of FRED) then it will get
rid of the dependency.

Here's the rough structure I am working towards:

Part 1) Core x86 prep (3 patches)
Part 2) Secondary VM-exit control infra (3-4 patches)
Part 3) FRED guest support (16–18 patches)
Part 4) Nested FRED support (5-7 patches)

Parts 1 and 2 are independent of each other and can be posted and
reviewed in parallel. The selftests can be posted with the relevant
parts if appropriate.

>> Patches  7-19: Virtualize the FRED context and advertise it to userspace
> 
> I think there are a few sub-groups here:
>  (1) patch07-10: Support FRED state context switching
>  (2) patch11-14: Extend event delivery
>  (3) patch15-17: Handle CR4
>  (4) patch18-19: Advertise the feature, etc.
> 


> At glance, (2) looks a little difficult to follow. Patch 13/14 in
> particular appear to mix the FRED support itself with some preparatory
> changes. IIUC, the code is saying everything outside of the
> is_fred_enabled() path has no functional change.
> 

Sure, I'll try to incorporate this.

> Perhaps, the changes outside of is_fred_enabled() could be separated
> out. That would make the actual is_fred_enabled() path easier to follow.
> Also, the part introduces the ABI immediately after adding
> is_fred_enabled(), before showing up the callsite of is_fred_enabled().
> This flow is a bit abrupt.
> 

Yes, I have identified a couple of simplifications to make the flow easier.

> For example, extending kvm_requeue_exception() alone could be one step.
> The next step could add the code under is_fred_enabled(), initially with
> is_fred_enabled() as a placeholder that simply returns false. I think
> that would better highlight which parts are actually FRED-specific and
> why this dynamic check is needed.
> 

I am not sure if the is_fred_enabled() false placeholder would buy us
anything. is_fred_enabled() is expected to be false until the feature is
advertised to guest. But I get the gist - Separating the non
FRED-specific parts would make it easier to follow the FRED-specific ones.

>> Patches 20-25: Extend FRED virtualization to nested VMX
> 
> Since nVMX support comes after exposing the feature, does that also mean
> the series could be partitioned into two parts, one up through the
> advertisement (and tests) and another for nVMX support? Splitting up a
> complex series like this may make review and integration easier going
> forward.
> 

Yes, I am working towards making this possible.

> Thanks,
> Chang


      reply	other threads:[~2026-11-18 10:01 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 21:36 Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 01/28] KVM: VMX: Enable support for secondary VM exit controls Sohil Mehta
2026-10-22  9:27   ` Binbin Wu
2026-10-23  2:09     ` Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 02/28] KVM: VMX: Initialize VM entry/exit FRED controls in vmcs_config Sohil Mehta
2026-10-22  9:48   ` Binbin Wu
2026-10-23  3:10     ` Sohil Mehta
2026-10-26  5:00       ` Sohil Mehta
2026-10-27  1:25         ` Binbin Wu
2026-09-11 21:36 ` [PATCH v10 03/28] KVM: VMX: Disable FRED if FRED consistency checks fail Sohil Mehta
2026-10-22 10:19   ` Binbin Wu
2026-10-23  3:13     ` Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 04/28] x86/cea: Prefix event stack names with ESTACK_ Sohil Mehta
2026-10-23  5:58   ` Binbin Wu
2026-09-11 21:36 ` [PATCH v10 05/28] x86/cea: Use array indexing to simplify exception stack access Sohil Mehta
2026-10-23  6:07   ` Binbin Wu
2026-10-27 21:15     ` Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 06/28] x86/fred: Export this_cpu_fred_rsp() for KVM usage Sohil Mehta
2026-10-23  6:49   ` Binbin Wu
2026-10-28  0:44     ` Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 07/28] KVM: VMX: Initialize VMCS FRED fields Sohil Mehta
2026-10-23  7:19   ` Binbin Wu
2026-10-29  0:13     ` Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 08/28] KVM: VMX: Set FRED MSR intercepts Sohil Mehta
2026-10-23  8:07   ` Binbin Wu
2026-10-29  2:42     ` Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 09/28] KVM: VMX: Save/restore guest FRED RSP0 Sohil Mehta
2026-09-14  7:04   ` Binbin Wu
2026-09-14 16:14     ` Edgecombe, Rick P
2026-09-15  8:43       ` Binbin Wu
2026-09-11 21:36 ` [PATCH v10 10/28] KVM: VMX: Add support for saving and restoring FRED MSRs Sohil Mehta
2026-10-23  8:59   ` Binbin Wu
2026-10-29  6:18     ` Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 11/28] KVM: x86: Add a helper to detect if FRED is enabled for a vCPU Sohil Mehta
2026-10-23  9:21   ` Binbin Wu
2026-11-04 20:01     ` Sohil Mehta
2026-11-05  5:16       ` Binbin Wu
2026-11-06  4:05         ` Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 12/28] KVM: x86: Add a new save/restore flag for FRED metadata Sohil Mehta
2026-10-29  3:10   ` Binbin Wu
2026-11-05  1:06     ` Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 13/28] KVM: VMX: Virtualize FRED nested exception tracking Sohil Mehta
2026-10-29  8:41   ` Binbin Wu
2026-11-06 19:51     ` Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 14/28] KVM: VMX: Virtualize FRED event_data Sohil Mehta
2026-10-29 10:55   ` Binbin Wu
2026-11-06 21:28     ` Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 15/28] KVM: x86: Include CR4.FRED in the emulator CR4 write mask Sohil Mehta
2026-10-30  6:26   ` Binbin Wu
2026-11-07  1:49     ` Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 16/28] KVM: x86: Mark CR4.FRED as not reserved Sohil Mehta
2026-10-30  6:42   ` Binbin Wu
2026-11-07  2:58     ` Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 17/28] KVM: x86: Handle CR4.FRED when emulating RSM Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 18/28] KVM: VMX: Dump FRED context in dump_vmcs() Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 19/28] KVM: x86: Advertise support for FRED Sohil Mehta
2026-11-02  7:32   ` Binbin Wu
2026-11-18  8:29     ` Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 20/28] KVM: nVMX: Enable support for secondary VM exit controls Sohil Mehta
2026-11-02  8:29   ` Binbin Wu
2026-09-11 21:36 ` [PATCH v10 21/28] KVM: nVMX: Handle FRED VMCS fields in nested VMX context Sohil Mehta
2026-11-04  6:43   ` Binbin Wu
2026-11-18  8:36     ` Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 22/28] KVM: nVMX: Restrict event data VMCS fields to FRED-supported hosts Sohil Mehta
2026-11-04  6:57   ` Binbin Wu
2026-11-04 13:32     ` Chao Gao
2026-09-11 21:36 ` [PATCH v10 23/28] KVM: nVMX: Shadow ORIGINAL_EVENT_DATA and INJECTED_EVENT_DATA fields Sohil Mehta
2026-11-04  7:10   ` Binbin Wu
2026-09-11 21:36 ` [PATCH v10 24/28] KVM: nVMX: Validate FRED-related VMCS fields Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 25/28] KVM: nVMX: Enable VMX FRED controls Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 26/28] KVM: selftests: Add FRED MSRs to msrs_test Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 27/28] KVM: selftests: Add a new VM guest mode to run user level code Sohil Mehta
2026-09-11 21:36 ` [PATCH v10 28/28] KVM: selftests: Add fred exception tests Sohil Mehta
2026-09-15  6:03 ` [PATCH v10 00/28] KVM: Enable FRED support with KVM VMX Xin Li
2026-10-24 22:59   ` H. Peter Anvin
2026-10-26 16:04     ` Sean Christopherson
2026-10-26 17:22       ` Sohil Mehta
2026-10-26 22:22         ` Sohil Mehta
2026-10-27 17:43       ` Sohil Mehta
2026-09-15 10:00 ` [EXTERNAL] " David Woodhouse
2026-09-24 11:14 ` Shivansh Dhiman
2026-09-24 14:13   ` David Woodhouse
2026-09-25 12:06     ` Shivansh Dhiman
2026-10-28  5:48       ` H. Peter Anvin
2026-10-19 20:46 ` Dave Hansen
2026-10-19 22:19   ` Sohil Mehta
2026-10-30 20:53 ` Chang S. Bae
2026-11-18 10:01   ` Sohil Mehta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12f686a4-a9f8-4347-a7f4-c0f893addfb9@intel.com \
    --to=sohil.mehta@intel.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=binbin.wu@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=chang.seok.bae@intel.com \
    --cc=chao.gao@intel.com \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=dmatlack@google.com \
    --cc=dwmw@amazon.co.uk \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=nikunj@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=seanjc@google.com \
    --cc=shivansh.dhiman@amd.com \
    --cc=skhan@linuxfoundation.org \
    --cc=tglx@kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    --cc=xin@zytor.com \
    --cc=yosry@kernel.org \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®