From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Frysinger <vapier@gentoo.org>,
<linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<drivers@analog.com>, Lars-Peter Clausen <lars@metafoo.de>,
<stable@kernel.org>
Subject: [PATCH v2 2/7] firmware: Sigma: Skip header during CRC generation
Date: Mon, 28 Nov 2011 09:44:15 +0100 [thread overview]
Message-ID: <1322469860-8210-2-git-send-email-lars@metafoo.de> (raw)
In-Reply-To: <1322469860-8210-1-git-send-email-lars@metafoo.de>
The firmware header is not part of the CRC, so skip it. Otherwise the firmware
will be rejected due to non-matching CRCs.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: stable@kernel.org
---
drivers/firmware/sigma.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/firmware/sigma.c b/drivers/firmware/sigma.c
index c780baa..36265de 100644
--- a/drivers/firmware/sigma.c
+++ b/drivers/firmware/sigma.c
@@ -130,7 +130,8 @@ int process_sigma_firmware(struct i2c_client *client, const char *name)
if (memcmp(ssfw_head->magic, SIGMA_MAGIC, ARRAY_SIZE(ssfw_head->magic)))
goto done;
- crc = crc32(0, fw->data, fw->size);
+ crc = crc32(0, fw->data + sizeof(*ssfw_head),
+ fw->size - sizeof(*ssfw_head));
pr_debug("%s: crc=%x\n", __func__, crc);
if (crc != ssfw_head->crc)
goto done;
--
1.7.7.3
next prev parent reply other threads:[~2011-11-28 8:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 8:44 [PATCH v2 1/7] firmware: Sigma: Prevent out of bounds memory access Lars-Peter Clausen
2011-11-28 8:44 ` Lars-Peter Clausen [this message]
2011-11-29 5:12 ` [PATCH v2 2/7] firmware: Sigma: Skip header during CRC generation Mike Frysinger
2011-11-28 8:44 ` [PATCH v2 3/7] firmware: Sigma: Fix endianess issues Lars-Peter Clausen
2011-11-28 8:44 ` [PATCH v2 4/7] ASoC: Move SigmaDSP firmware loader to ASoC Lars-Peter Clausen
2011-11-28 8:44 ` [PATCH v2 5/7] ASoC: SigmaDSP: Provide diagnostic error messages Lars-Peter Clausen
2011-11-29 5:12 ` Mike Frysinger
2011-11-28 8:44 ` [PATCH v2 6/7] ASoC: SigmaDSP: Move private structs and functions to C file Lars-Peter Clausen
2011-11-28 8:44 ` [PATCH v2 7/7] ASoC: SigmaDSP: Add regmap support Lars-Peter Clausen
2011-11-29 5:17 ` Mike Frysinger
2011-11-29 5:12 ` [PATCH v2 1/7] firmware: Sigma: Prevent out of bounds memory access Mike Frysinger
2011-11-29 10:12 ` Mark Brown
2011-11-29 10:18 ` [alsa-devel] " Lars-Peter Clausen
2011-11-29 12:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322469860-8210-2-git-send-email-lars@metafoo.de \
--to=lars@metafoo.de \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=drivers@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=stable@kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®