mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suresh Siddha <suresh.b.siddha@intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: NeilBrown <neilb@suse.de>,
	james.t.kukunas@linux.intel.com,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch] x86, avx: don't use avx instructions with "noxsave" boot param
Date: Tue, 31 Jul 2012 09:27:01 -0700	[thread overview]
Message-ID: <1343752022.3696.602.camel@sbsiddha-desk.sc.intel.com> (raw)
In-Reply-To: <7b101443-b8d7-4474-ab54-03692d232469@email.android.com>

On Mon, 2012-07-30 at 21:33 -0700, H. Peter Anvin wrote:
> I'm wondering if we shouldn't just kill the affected CPUID bits if osxsave is off...

Yes, I considered clearing AVX bit (and any future xsave feature bits)
as part of the parsing "noxsave" parameter in x86_xsave_setup().

But thought checking for osxsave was more explicit and there are not
many places using avx code. Also, this follows the SDM guidelines and
sets a nice precedent for someone (app's) to follow in future.

I am ok either way!

thanks,
suresh




  reply	other threads:[~2012-07-31 16:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30 22:46 Suresh Siddha
2012-07-31  4:20 ` NeilBrown
2012-07-31  4:33   ` H. Peter Anvin
2012-07-31 16:27     ` Suresh Siddha [this message]
2012-07-31 16:43       ` H. Peter Anvin
2012-07-31 17:29         ` Suresh Siddha
2012-08-01 10:42           ` NeilBrown
2012-08-08 22:25           ` [tip:x86/urgent] x86, avx: don't use avx instructions with " noxsave" " tip-bot for Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343752022.3696.602.camel@sbsiddha-desk.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=hpa@zytor.com \
    --cc=james.t.kukunas@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®