From: Artem Bityutskiy <dedekind1@gmail.com>
To: Huang Shijie <shijie8@gmail.com>
Cc: Huang Shijie <b32955@freescale.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/4] Export the ecc step size to user applications
Date: Thu, 16 May 2013 10:19:37 +0300 [thread overview]
Message-ID: <1368688777.15764.175.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <CAMiH66GygmwvfZrwys7RoeoY4Q_fFkfbiZF_pJN4RxQBPaz0fw@mail.gmail.com>
On Wed, 2013-05-15 at 22:19 +0800, Huang Shijie wrote:
> ok. can i send a separate patch to fix it?
> or a new version patch set？
>
Just a follow-up patch. I would like to let this patch-set sit in the
mailing list for some time before I pick it, in case someone wants to
comment.
Also, surely the things you expose are the real ECC step and ECC
strength? I think the datasheet ones in your other patch-set should be
named differently to make sure the reader of the code understands that
they are only the recommended datasheet values, not necessarily the
values which are actually in use.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2013-05-16 7:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 8:46 Huang Shijie
2013-05-15 8:46 ` [PATCH v2 1/4] mtd: add a new field to mtd_info{} Huang Shijie
2013-05-15 8:46 ` [PATCH v2 2/4] mtd: add a new sys node to show the ecc step size Huang Shijie
2013-08-10 7:15 ` Brian Norris
2013-05-15 8:46 ` [PATCH v2 3/4] mtd: set the ecc step size for master/slave mtd_info Huang Shijie
2013-05-15 8:46 ` [PATCH v2 4/4] mtd: gpmi: update the ecc step size for mtd_info{} Huang Shijie
2013-08-10 7:41 ` Brian Norris
2013-08-10 7:53 ` Brian Norris
2013-08-11 15:07 ` Huang Shijie
2013-05-15 12:07 ` [PATCH v2 0/4] Export the ecc step size to user applications Artem Bityutskiy
2013-05-16 4:09 ` [PATCH v2 append] mtd: update the ABI document about the ecc step Huang Shijie
2013-08-10 8:20 ` Brian Norris
[not found] ` <CAMiH66GygmwvfZrwys7RoeoY4Q_fFkfbiZF_pJN4RxQBPaz0fw@mail.gmail.com>
2013-05-16 7:19 ` Artem Bityutskiy [this message]
2013-05-16 8:10 ` [PATCH v2 0/4] Export the ecc step size to user applications Huang Shijie
2013-08-08 8:37 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368688777.15764.175.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®