From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: broonie@kernel.org
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net, sameo@linux.intel.com, lee.jones@linaro.org,
lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: [PATCH 5/8] regulator: arizona-micsupp: Add processing of init_data from device tree
Date: Tue, 18 Mar 2014 10:49:14 +0000 [thread overview]
Message-ID: <1395139757-6907-6-git-send-email-ckeepax@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1395139757-6907-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
Documentation/devicetree/bindings/mfd/arizona.txt | 6 ++-
drivers/regulator/arizona-micsupp.c | 47 +++++++++++++++++++--
2 files changed, 47 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
index d78f1aa..88c1c0f 100644
--- a/Documentation/devicetree/bindings/mfd/arizona.txt
+++ b/Documentation/devicetree/bindings/mfd/arizona.txt
@@ -44,9 +44,11 @@ Optional properties:
- wlf,ldo1 : Initial data for the LDO1 regulator, as covered in
Documentation/devicetree/bindings/regulator/regulator.txt
+ - wlf,micvdd : Initial data for the MICVDD regulator, as covered in
+ Documentation/devicetree/bindings/regulator/regulator.txt
- - DCVDD-supply : Power supply, only needs to be specified if DCVDD is being
- externally supplied. As covered in
+ - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
+ they are being externally supplied. As covered in
Documentation/devicetree/bindings/regulator/regulator.txt
Example:
diff --git a/drivers/regulator/arizona-micsupp.c b/drivers/regulator/arizona-micsupp.c
index 034ece7..1d5bd8d 100644
--- a/drivers/regulator/arizona-micsupp.c
+++ b/drivers/regulator/arizona-micsupp.c
@@ -19,6 +19,7 @@
#include <linux/platform_device.h>
#include <linux/regulator/driver.h>
#include <linux/regulator/machine.h>
+#include <linux/regulator/of_regulator.h>
#include <linux/gpio.h>
#include <linux/slab.h>
#include <linux/workqueue.h>
@@ -195,6 +196,44 @@ static const struct regulator_init_data arizona_micsupp_ext_default = {
.num_consumer_supplies = 1,
};
+#ifdef CONFIG_OF
+static int arizona_micsupp_get_pdata(struct arizona *arizona,
+ struct regulator_config *config)
+{
+ struct arizona_pdata *pdata = &arizona->pdata;
+ struct arizona_micsupp *micsupp = config->driver_data;
+ struct device_node *np_init, *np_micvdd;
+
+ np_init = of_get_child_by_name(arizona->dev->of_node, "wlf,micvdd");
+ np_micvdd = of_parse_phandle(arizona->dev->of_node, "MICVDD-supply", 0);
+
+ if (np_init) {
+ config->of_node = np_init;
+
+ pdata->micvdd = of_get_regulator_init_data(arizona->dev,
+ np_init);
+
+ if (!np_micvdd) {
+ pdata->micvdd->consumer_supplies = &micsupp->supply;
+ pdata->micvdd->num_consumer_supplies = 1;
+ }
+
+ config->init_data = pdata->micvdd;
+ }
+
+ return 0;
+}
+#else
+static inline int arizona_micsupp_get_pdata(struct arizona *arizona,
+ struct regulator_config *config)
+{
+ if (arizona->pdata.micvdd)
+ config->init_data = arizona->pdata.micvdd;
+
+ return 0;
+}
+#endif
+
static int arizona_micsupp_probe(struct platform_device *pdev)
{
struct arizona *arizona = dev_get_drvdata(pdev->dev.parent);
@@ -235,11 +274,11 @@ static int arizona_micsupp_probe(struct platform_device *pdev)
config.dev = arizona->dev;
config.driver_data = micsupp;
config.regmap = arizona->regmap;
+ config.init_data = &micsupp->init_data;
- if (arizona->pdata.micvdd)
- config.init_data = arizona->pdata.micvdd;
- else
- config.init_data = &micsupp->init_data;
+ ret = arizona_micsupp_get_pdata(arizona, &config);
+ if (ret < 0)
+ return ret;
/* Default to regulated mode until the API supports bypass */
regmap_update_bits(arizona->regmap, ARIZONA_MIC_CHARGE_PUMP_1,
--
1.7.2.5
next prev parent reply other threads:[~2014-03-18 10:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 10:49 [PATCH 0/8] Arizona regulator updates Charles Keepax
2014-03-18 10:49 ` [PATCH 1/8] arizona: Correct small errors in the DT binding documentation Charles Keepax
2014-03-18 10:49 ` [PATCH 2/8] mfd: arizona: Factor out read of device tree GPIOs Charles Keepax
2014-03-18 10:49 ` [PATCH 3/8] regulator: arizona-ldo1: Move setup processing from arizona-core Charles Keepax
2014-03-18 11:10 ` Mark Brown
2014-03-18 14:11 ` Charles Keepax
2014-03-18 10:49 ` [PATCH 4/8] regulator: arizona-ldo1: Add processing of init_data from device tree Charles Keepax
2014-03-18 11:15 ` Mark Brown
2014-03-18 16:07 ` Charles Keepax
2014-03-18 16:19 ` Mark Brown
2014-03-18 10:49 ` Charles Keepax [this message]
2014-03-18 10:49 ` [PATCH 6/8] mfd: arizona: Add MICVDD to mapped regulators Charles Keepax
2014-03-18 10:49 ` [PATCH 7/8] mfd: wm8997: Add registers for high power mode Charles Keepax
2014-03-18 10:49 ` [PATCH 8/8] regulator: arizona-ldo1: Correct default regulator init_data Charles Keepax
2014-03-18 11:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395139757-6907-6-git-send-email-ckeepax@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=broonie@kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®