mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Jiri Olsa <jolsa@redhat.com>
Subject: [PATCH 3/4] tools lib traceevent: Fix backward compatibility macros for pevent filter enums
Date: Wed, 23 Apr 2014 13:31:21 +0200	[thread overview]
Message-ID: <1398252682-17185-4-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1398252682-17185-1-git-send-email-jolsa@redhat.com>

From: Steven Rostedt <rostedt@goodmis.org>

The return value for pevent_filter_match() is suppose to return FILTER_NONE
if the event doesn't have a filter, and FILTER_NOEXIST if there is no filter
at all. But the change 41e12e580a7 "tools lib traceevent: Refactor
pevent_filter_match() to get rid of die()" replaced the return value
with PEVENT_ERRNO__* values and added "backward compatibility" macros
that used the old names. Unfortunately, the NOEXIST and NONE macros were
swapped, and this broke users that use the old return names.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/20140421222346.0351ced4@gandalf.local.home
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
 tools/lib/traceevent/event-parse.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h
index 791c539..feab942 100644
--- a/tools/lib/traceevent/event-parse.h
+++ b/tools/lib/traceevent/event-parse.h
@@ -876,8 +876,8 @@ struct event_filter {
 struct event_filter *pevent_filter_alloc(struct pevent *pevent);
 
 /* for backward compatibility */
-#define FILTER_NONE		PEVENT_ERRNO__FILTER_NOT_FOUND
-#define FILTER_NOEXIST		PEVENT_ERRNO__NO_FILTER
+#define FILTER_NONE		PEVENT_ERRNO__NO_FILTER
+#define FILTER_NOEXIST		PEVENT_ERRNO__FILTER_NOT_FOUND
 #define FILTER_MISS		PEVENT_ERRNO__FILTER_MISS
 #define FILTER_MATCH		PEVENT_ERRNO__FILTER_MATCH
 
-- 
1.8.3.1


  parent reply	other threads:[~2014-04-23 11:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23 11:31 [GIT PULL 0/4] perf/urgent fixes Jiri Olsa
2014-04-23 11:31 ` [PATCH 1/4] perf tests x86: Fix memory leak in sample_ustack() Jiri Olsa
2014-04-23 11:31 ` [PATCH 2/4] perf tools: Disable libdw unwind for all but x86 arch Jiri Olsa
2014-04-23 11:31 ` Jiri Olsa [this message]
2014-04-23 11:31 ` [PATCH 4/4] tools lib traceevent: Fix memory leak in pretty_print() Jiri Olsa
2014-04-23 13:09 ` [GIT PULL 0/4] perf/urgent fixes Ingo Molnar
2014-04-23 13:14 ` Ingo Molnar
2014-04-23 13:49   ` Jiri Olsa
2014-04-24  6:36     ` Ingo Molnar
2014-04-24 11:47       ` Jiri Olsa
2014-04-25  8:12         ` Ingo Molnar
2014-04-23 14:53   ` Jiri Olsa
2014-04-24  6:47     ` Ingo Molnar
2014-04-24 11:43       ` Jiri Olsa
2014-04-25 17:50     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398252682-17185-4-git-send-email-jolsa@redhat.com \
    --to=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®