mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Felipe Balbi <balbi@ti.com>
Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	Pavankumar Kondeti <pkondeti@codeaurora.org>
Subject: [PATCH v7 18/20] usb: phy: msm: Handle disconnect events
Date: Thu, 24 Apr 2014 18:48:13 +0300	[thread overview]
Message-ID: <1398354495-20782-19-git-send-email-iivanov@mm-sol.com> (raw)
In-Reply-To: <1398354495-20782-1-git-send-email-iivanov@mm-sol.com>

From: "Ivan T. Ivanov" <iivanov@mm-sol.com>

Put the transceiver in non-driving mode. Otherwise host
may not detect soft-disconnection.

Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
Cc: Pavankumar Kondeti <pkondeti@codeaurora.org>
---
 drivers/usb/phy/phy-msm-usb.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index 1554f69..602e6c8 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -235,6 +235,23 @@ static void ulpi_init(struct msm_otg *motg)
 	}
 }

+static int msm_phy_notify_disconnect(struct usb_phy *phy,
+				   enum usb_device_speed speed)
+{
+	int val;
+
+	/*
+	 * Put the transceiver in non-driving mode. Otherwise host
+	 * may not detect soft-disconnection.
+	 */
+	val = ulpi_read(phy, ULPI_FUNC_CTRL);
+	val &= ~ULPI_FUNC_CTRL_OPMODE_MASK;
+	val |= ULPI_FUNC_CTRL_OPMODE_NONDRIVING;
+	ulpi_write(phy, val, ULPI_FUNC_CTRL);
+
+	return 0;
+}
+
 static int msm_otg_link_clk_reset(struct msm_otg *motg, bool assert)
 {
 	int ret;
@@ -1631,6 +1648,7 @@ static int msm_otg_probe(struct platform_device *pdev)

 	phy->init = msm_phy_init;
 	phy->set_power = msm_otg_set_power;
+	phy->notify_disconnect = msm_phy_notify_disconnect;

 	phy->io_ops = &msm_otg_io_ops;

--
1.8.3.2


  parent reply	other threads:[~2014-04-24 15:52 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1398354495-20782-1-git-send-email-iivanov@mm-sol.com>
2014-04-24 15:47 ` [PATCH v7 01/20] usb: phy: msm: Make driver selectable on ARCH_QCOM Ivan T. Ivanov
2014-04-24 15:47 ` [PATCH v7 02/20] usb: phy: msm: Remove __init macro from driver probe method Ivan T. Ivanov
2014-04-24 15:47 ` [PATCH v7 03/20] usb: phy: msm: Move global regulators variables to driver state Ivan T. Ivanov
2014-04-24 15:47 ` [PATCH v7 04/20] usb: phy: msm: Enable deferred driver probing Ivan T. Ivanov
2014-04-24 15:48 ` [PATCH v7 05/20] usb: phy: msm: Migrate to Managed Device Resource allocation Ivan T. Ivanov
2014-04-24 16:49   ` Fabio Estevam
2014-04-25 20:53     ` Felipe Balbi
2014-04-28  7:18       ` Ivan T. Ivanov
2014-04-24 15:48 ` [PATCH v7 06/20] usb: phy: msm: Remove unnecessarily check for valid regulators Ivan T. Ivanov
2014-04-24 15:48 ` [PATCH v7 07/20] usb: phy: msm: Fix checkpatch.pl warnings Ivan T. Ivanov
2014-04-24 15:48 ` [PATCH v7 08/20] usb: phy: msm: Replace custom enum usb_mode_type with enum usb_dr_mode Ivan T. Ivanov
2014-04-24 15:48 ` [PATCH v7 09/20] usb: phy: msm: Remove unused pclk_src_name Ivan T. Ivanov
2014-04-24 15:48 ` [PATCH v7 10/20] usb: phy: msm: Remove HSUSB prefix from regulator names Ivan T. Ivanov
2014-04-24 15:48 ` [PATCH v7 11/20] usb: phy: msm: Properly check result from platform_get_irq() Ivan T. Ivanov
2014-04-24 15:48 ` [PATCH v7 12/20] usb: phy: msm: Add device tree support and binding information Ivan T. Ivanov
2014-04-24 15:48 ` [PATCH v7 13/20] usb: phy: msm: Use reset framework for LINK and PHY resets Ivan T. Ivanov
2014-04-24 15:48 ` [PATCH v7 14/20] usb: phy: msm: Add support for secondary PHY control Ivan T. Ivanov
2014-04-24 15:48 ` [PATCH v7 15/20] usb: phy: msm: Correct USB PHY Reset sequence for newer platform Ivan T. Ivanov
2014-04-24 15:48 ` [PATCH v7 16/20] usb: phy: msm: Fix PTS definitions for MSM USB controller Ivan T. Ivanov
2014-04-30 16:27   ` Felipe Balbi
2014-04-30 18:07     ` Bird, Tim
2014-04-30 20:12       ` Felipe Balbi
2014-05-02  5:49     ` Ivan T. Ivanov
2014-05-02 14:23       ` Felipe Balbi
2014-04-24 15:48 ` [PATCH v7 17/20] usb: phy: msm: Select secondary PHY via TCSR Ivan T. Ivanov
2014-04-24 15:48 ` Ivan T. Ivanov [this message]
2014-04-24 15:48 ` [PATCH v7 19/20] usb: phy: msm: Vote for corner of VDD CX instead of voltage of VDD CX Ivan T. Ivanov
2014-04-24 15:48 ` [PATCH v7 20/20] usb: phy: msm: Use usb_add_phy_dev() to register device Ivan T. Ivanov
2014-04-24 17:06   ` Sergei Shtylyov
2014-04-25 20:53     ` Felipe Balbi
2014-04-28  7:19       ` Ivan T. Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398354495-20782-19-git-send-email-iivanov@mm-sol.com \
    --to=iivanov@mm-sol.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pkondeti@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®