From: Matt Fleming <matt.fleming@intel.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Kweh Hock Leong <hock.leong.kweh@intel.com>,
Ming Lei <ming.lei@canonical.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>, <linux-efi@vger.kernel.org>,
Ong Boon Leong <boon.leong.ong@intel.com>
Subject: Re: [PATCH v2 1/3] firmware loader: Introduce new API - request_firmware_abort()
Date: Mon, 3 Nov 2014 12:07:20 +0000 [thread overview]
Message-ID: <1415016440.7122.891.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20141103101558.GA11739@khazad-dum.debian.net>
On Mon, 2014-11-03 at 08:15 -0200, Henrique de Moraes Holschuh wrote:
> On Mon, 03 Nov 2014, Kweh Hock Leong wrote:
> > Note for people who use request_firmware_nowait():
> > You are required to do your own synchronization after you call
> > request_firmware_abort() in order to continue unloading the
> > module. The example synchronization code shows below:
> >
> > while (THIS_MODULE && module_refcount(THIS_MODULE))
> > msleep(20);
>
> This is _so_ asking for people to get it wrong, it is not funny :-(
Yeah. How about we make request_firmware_abort() synchronous so that
drivers don't have to perform these reference counting games?
next prev parent reply other threads:[~2014-11-03 12:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 3:07 [PATCH v2 0/3] Enable user helper interface for efi capsule update Kweh Hock Leong
2014-11-03 3:07 ` [PATCH v2 1/3] firmware loader: Introduce new API - request_firmware_abort() Kweh Hock Leong
2014-11-03 10:15 ` Henrique de Moraes Holschuh
2014-11-03 12:07 ` Matt Fleming [this message]
2014-11-08 19:06 ` Greg Kroah-Hartman
2014-11-13 2:51 ` Kweh, Hock Leong
2014-11-17 15:12 ` Matt Fleming
2014-11-18 6:31 ` Kweh, Hock Leong
2014-11-19 2:05 ` Greg Kroah-Hartman
2014-11-03 3:07 ` [PATCH v2 2/3] firmware loader: fix hung task warning dump Kweh Hock Leong
2014-11-08 19:07 ` Greg Kroah-Hartman
2014-11-03 3:07 ` [PATCH v2 3/3] efi: Capsule update with user helper interface Kweh Hock Leong
2014-11-04 4:32 ` Greg Kroah-Hartman
2014-11-04 5:20 ` Andy Lutomirski
2014-11-04 6:04 ` Kweh, Hock Leong
2014-11-04 6:32 ` Andy Lutomirski
2014-11-04 8:03 ` Kweh, Hock Leong
2014-11-04 14:18 ` Matt Fleming
2014-11-04 14:57 ` Andy Lutomirski
2014-11-04 15:40 ` Greg KH
2014-11-04 16:35 ` Andy Lutomirski
2014-11-06 12:53 ` Kweh, Hock Leong
2014-11-06 16:52 ` Andy Lutomirski
2014-11-10 8:31 ` Kweh, Hock Leong
2014-11-10 19:31 ` Andy Lutomirski
2014-11-08 13:05 ` Matt Fleming
2014-11-08 15:54 ` Andy Lutomirski
2015-02-27 5:06 ` Roy Franz
2015-02-27 11:35 ` Kweh, Hock Leong
2014-11-03 19:33 ` [PATCH v2 0/3] Enable user helper interface for efi capsule update Andy Lutomirski
2014-11-03 21:27 ` Greg Kroah-Hartman
2014-11-03 21:32 ` Andy Lutomirski
2014-11-03 23:02 ` Greg Kroah-Hartman
2014-11-03 23:08 ` Andy Lutomirski
2014-11-04 0:38 ` Greg Kroah-Hartman
2014-11-04 1:14 ` Andy Lutomirski
2014-11-04 14:07 ` Matt Fleming
2014-11-05 9:52 ` Kweh, Hock Leong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415016440.7122.891.camel@mfleming-mobl1.ger.corp.intel.com \
--to=matt.fleming@intel.com \
--cc=boon.leong.ong@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hmh@hmh.eng.br \
--cc=hock.leong.kweh@intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®