From: Sachin Shukla <sachin.s5@samsung.com>
To: Timur Tabi <timur@tabi.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
sachiniiitm@gmail.com
Cc: ravikant.s2@samsung.com, p.shailesh@samsung.com,
ashish.kalra@samsung.com, vidushi.koul@samsung.com
Subject: [PATCH] Video: fbdev: Remove impossible condition.
Date: Fri, 11 Nov 2016 17:54:50 +0530 [thread overview]
Message-ID: <1478867090-2108-1-git-send-email-sachin.s5@samsung.com> (raw)
From: "Sachin Shukla" <sachin.s5@samsung.com>
xoffset and yoffset of struct fb_var_screeninfo are unsigned and so
they can never be less than 0.
Signed-off-by: Sachin Shukla <sachin.s5@samsung.com>
---
drivers/video/fbdev/amifb.c | 8 +++-----
drivers/video/fbdev/fsl-diu-fb.c | 9 +--------
2 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/drivers/video/fbdev/amifb.c b/drivers/video/fbdev/amifb.c
index 1d702e1..cc11c60 100644
--- a/drivers/video/fbdev/amifb.c
+++ b/drivers/video/fbdev/amifb.c
@@ -1484,13 +1484,11 @@ static int ami_decode_var(struct fb_var_screeninfo *var, struct amifb_par *par,
par->xoffset = var->xoffset;
par->yoffset = var->yoffset;
if (par->vmode & FB_VMODE_YWRAP) {
- if (par->xoffset || par->yoffset < 0 ||
- par->yoffset >= par->vyres)
+ if (par->yoffset >= par->vyres)
par->xoffset = par->yoffset = 0;
} else {
- if (par->xoffset < 0 ||
- par->xoffset > upx(16 << maxfmode, par->vxres - par->xres) ||
- par->yoffset < 0 || par->yoffset > par->vyres - par->yres)
+ if (par->xoffset > upx(16 << maxfmode, par->vxres - par->xres) ||
+ par->yoffset > par->vyres - par->yres)
par->xoffset = par->yoffset = 0;
}
} else
diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
index fe00a07..c48a59e 100644
--- a/drivers/video/fbdev/fsl-diu-fb.c
+++ b/drivers/video/fbdev/fsl-diu-fb.c
@@ -703,12 +703,6 @@ static int fsl_diu_check_var(struct fb_var_screeninfo *var,
if (var->yres_virtual < var->yres)
var->yres_virtual = var->yres;
- if (var->xoffset < 0)
- var->xoffset = 0;
-
- if (var->yoffset < 0)
- var->yoffset = 0;
-
if (var->xoffset + info->var.xres > info->var.xres_virtual)
var->xoffset = info->var.xres_virtual - info->var.xres;
@@ -1254,8 +1248,7 @@ static int fsl_diu_pan_display(struct fb_var_screeninfo *var,
(info->var.yoffset == var->yoffset))
return 0; /* No change, do nothing */
- if (var->xoffset < 0 || var->yoffset < 0
- || var->xoffset + info->var.xres > info->var.xres_virtual
+ if (var->xoffset + info->var.xres > info->var.xres_virtual
|| var->yoffset + info->var.yres > info->var.yres_virtual)
return -EINVAL;
--
1.7.9.5
next reply other threads:[~2016-11-11 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 12:24 Sachin Shukla [this message]
2016-11-11 14:49 ` Timur Tabi
[not found] ` <CGME20170208153734epcas5p1f56516b023b93b77f4bc43d1ac997769@epcas5p1.samsung.com>
2017-02-08 15:37 ` Bartlomiej Zolnierkiewicz
-- strict thread matches above, loose matches on Subject: below --
2016-11-11 11:46 Shailendra Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478867090-2108-1-git-send-email-sachin.s5@samsung.com \
--to=sachin.s5@samsung.com \
--cc=ashish.kalra@samsung.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.shailesh@samsung.com \
--cc=ravikant.s2@samsung.com \
--cc=sachiniiitm@gmail.com \
--cc=timur@tabi.org \
--cc=tomi.valkeinen@ti.com \
--cc=vidushi.koul@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®