From: Yang Zhang <yang.zhang.wz@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, wanpeng.li@hotmail.com, mst@redhat.com,
pbonzini@redhat.com, tglx@linutronix.de, rkrcmar@redhat.com,
dmatlack@google.com, agraf@suse.de, peterz@infradead.org,
linux-doc@vger.kernel.org, Yang Zhang <yang.zhang.wz@gmail.com>,
Quan Xu <quan.xu0@gmail.com>, Ingo Molnar <mingo@redhat.com>
Subject: [RFC PATCH v2 7/7] sched/idle: update poll time when wakeup from idle
Date: Tue, 29 Aug 2017 11:46:41 +0000 [thread overview]
Message-ID: <1504007201-12904-8-git-send-email-yang.zhang.wz@gmail.com> (raw)
In-Reply-To: <1504007201-12904-1-git-send-email-yang.zhang.wz@gmail.com>
In ttwu_do_wakeup, it will update avg_idle when wakeup from idle. Here
we just reuse this logic to update the poll time. It may be a little
late to update the poll in ttwu_do_wakeup, but the test result shows no
obvious performance gap compare with updating poll in irq handler.
one problem is that idle_stamp only used when using CFS scheduler. But
it is ok since it is the default policy for scheduler and only consider
it should enough.
Signed-off-by: Yang Zhang <yang.zhang.wz@gmail.com>
Signed-off-by: Quan Xu <quan.xu0@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org
---
include/linux/sched/idle.h | 4 ++++
kernel/sched/core.c | 4 ++++
kernel/sched/idle.c | 7 +++++++
3 files changed, 15 insertions(+)
diff --git a/include/linux/sched/idle.h b/include/linux/sched/idle.h
index 5ca63eb..6e0554d 100644
--- a/include/linux/sched/idle.h
+++ b/include/linux/sched/idle.h
@@ -12,6 +12,10 @@ enum cpu_idle_type {
extern void wake_up_if_idle(int cpu);
+#if defined(CONFIG_SMP) && defined(CONFIG_PARAVIRT)
+extern void update_poll_duration(unsigned long idle_duration);
+#endif
+
/*
* Idle thread specific functions to determine the need_resched
* polling state.
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 0869b20..25be9a3 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1678,6 +1678,10 @@ static void ttwu_do_wakeup(struct rq *rq, struct task_struct *p, int wake_flags,
if (rq->avg_idle > max)
rq->avg_idle = max;
+#if defined(CONFIG_PARAVIRT)
+ update_poll_duration(rq->avg_idle);
+#endif
+
rq->idle_stamp = 0;
}
#endif
diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c
index b374744..7eb8559 100644
--- a/kernel/sched/idle.c
+++ b/kernel/sched/idle.c
@@ -101,6 +101,13 @@ void __cpuidle default_idle_call(void)
}
}
+#if defined(CONFIG_SMP) && defined(CONFIG_PARAVIRT)
+void update_poll_duration(unsigned long idle_duration)
+{
+ paravirt_idle_update_poll_duration(idle_duration);
+}
+#endif
+
static int call_cpuidle(struct cpuidle_driver *drv, struct cpuidle_device *dev,
int next_state)
{
--
1.8.3.1
next prev parent reply other threads:[~2017-08-29 11:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 11:46 [RFC PATCH v2 0/7] x86/idle: add halt poll support Yang Zhang
2017-08-29 11:46 ` [RFC PATCH v2 1/7] x86/paravirt: Add pv_idle_ops to paravirt ops Yang Zhang
2017-08-29 13:55 ` Konrad Rzeszutek Wilk
2017-08-30 7:33 ` Juergen Gross
2017-09-01 6:50 ` Yang Zhang
2017-08-29 11:46 ` [RFC PATCH v2 2/7] KVM guest: register kvm_idle_poll for pv_idle_ops Yang Zhang
2017-08-29 11:46 ` [RFC PATCH v2 3/7] sched/idle: Add poll before enter real idle path Yang Zhang
2017-08-29 12:45 ` Peter Zijlstra
2017-09-01 5:57 ` Quan Xu
2017-09-14 8:41 ` Quan Xu
2017-09-14 9:18 ` Borislav Petkov
2017-08-29 14:39 ` Borislav Petkov
2017-09-01 6:49 ` Quan Xu
2017-09-29 10:39 ` Quan Xu
2017-08-29 11:46 ` [RFC PATCH v2 4/7] x86/paravirt: Add update in x86/paravirt pv_idle_ops Yang Zhang
2017-08-29 11:46 ` [RFC PATCH v2 5/7] Documentation: Add three sysctls for smart idle poll Yang Zhang
2017-08-29 17:20 ` Luis R. Rodriguez
2017-08-29 11:46 ` [RFC PATCH v2 6/7] KVM guest: introduce smart idle poll algorithm Yang Zhang
2017-08-29 11:46 ` Yang Zhang [this message]
2017-08-29 12:46 ` [RFC PATCH v2 7/7] sched/idle: update poll time when wakeup from idle Peter Zijlstra
2017-09-01 7:30 ` Yang Zhang
2017-09-29 10:29 ` Quan Xu
2017-08-29 11:58 ` [RFC PATCH v2 0/7] x86/idle: add halt poll support Alexander Graf
2017-09-01 6:21 ` Yang Zhang
2017-08-29 13:03 ` Andi Kleen
2017-08-29 14:02 ` Wanpeng Li
2017-08-29 14:27 ` Konrad Rzeszutek Wilk
2017-08-29 14:36 ` Michael S. Tsirkin
2017-09-01 6:32 ` Yang Zhang
2017-09-01 6:52 ` Wanpeng Li
2017-09-01 6:44 ` Yang Zhang
2017-09-01 6:58 ` Wanpeng Li
2017-09-01 7:53 ` Yang Zhang
2017-08-29 14:56 ` Michael S. Tsirkin
2017-09-13 11:56 ` Yang Zhang
2017-09-14 8:36 ` Quan Xu
2017-09-14 9:19 ` Wanpeng Li
2017-09-14 9:40 ` Quan Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504007201-12904-8-git-send-email-yang.zhang.wz@gmail.com \
--to=yang.zhang.wz@gmail.com \
--cc=agraf@suse.de \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=quan.xu0@gmail.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®