mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "François Roux" <franzelfranzel@gmail.com>
Cc: Diederik de Haas <diederik@cknow-tech.com>,
	Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
	linux-wireless@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: nl80211: don't WARN on a missing self-managed regdom
Date: Wed, 07 Oct 2026 16:55:09 +0200	[thread overview]
Message-ID: <16aa99921c4e92e8d4da3c84aacbec2e673666aa.camel@sipsolutions.net> (raw)
In-Reply-To: <20261006161744.3804-1-franzelfranzel@gmail.com> (sfid-20261006_181759_239008_AC7457D2)

On Tue, 2026-10-06 at 18:17 +0200, François Roux wrote:
> nl80211_get_reg_do() has a WARN_ON() for a self-managed wiphy without a
> private regdomain. Userspace can trigger it with a plain
> NL80211_CMD_GET_REG request.
> 
> Drivers can register such a wiphy first and set its regdomain later.
> ath12k, for example, calls ieee80211_register_hw() and only then applies
> the regdomain with ath12k_regd_update(). iwd queries the regdomain of a
> new wiphy as soon as it shows up, so it can hit that window at boot:
> 
>   WARNING: net/wireless/nl80211.c:10828 at nl80211_get_reg_do+0x1d0/0x1fc [cfg80211], CPU#5: iwd/721

I'm not a fan of this, I think the drivers should have the regdom ready.

> The same trace has been reported with an Intel BE200 (iwlwifi).

I _thought_ we fixed that issue.

Anyway I think we need to fix the bugs, not paper over them. If it comes
to it we can even put a WARN_ON there to reject wiphy registration w/o a
regdomain. There should be one. As it is, iwd will get empty data or
something, that makes no sense.

johannes

  parent reply	other threads:[~2026-10-07 14:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 16:17 François Roux
2026-10-07 12:33 ` Diederik de Haas
2026-10-07 14:55 ` Johannes Berg [this message]
2026-10-07 15:18   ` Diederik de Haas
2026-10-07 15:20     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16aa99921c4e92e8d4da3c84aacbec2e673666aa.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=diederik@cknow-tech.com \
    --cc=emmanuel.grumbach@intel.com \
    --cc=franzelfranzel@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®