mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shawn Lin <shawn.lin@rock-chips.com>
To: Ulf Hansson <ulfh@kernel.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shawn Lin <shawn.lin@linux.dev>
Subject: [PATCH 3/3] mmc: core: fix stale mmc_start_req() references in comments
Date: Thu, 17 Sep 2026 16:48:37 +0800	[thread overview]
Message-ID: <1789634917-143165-4-git-send-email-shawn.lin@rock-chips.com> (raw)
In-Reply-To: <1789634917-143165-1-git-send-email-shawn.lin@rock-chips.com>

From: Shawn Lin <shawn.lin@linux.dev>

Two comments still refer to mmc_start_req(). That function was renamed
to mmc_start_areq() then removed.

So, let's update the mmc_is_req_done() and mmc_pre_req() comments to refer
to the current APIs: mmc_start_request() and mmc_wait_for_req().

Signed-off-by: Shawn Lin <shawn.lin@linux.dev>
---

 drivers/mmc/core/core.c | 4 ++--
 drivers/mmc/core/core.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 59430bc..920e4b1 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -588,8 +588,8 @@ EXPORT_SYMBOL(mmc_cqe_recovery);
  *	mmc_is_req_done() is used with requests that have
  *	mrq->cap_cmd_during_tfr = true. mmc_is_req_done() must be called after
  *	starting a request and before waiting for it to complete. That is,
- *	either in between calls to mmc_start_req(), or after mmc_wait_for_req()
- *	and before mmc_wait_for_req_done(). If it is called at other times the
+ *	after mmc_start_request() or mmc_wait_for_req() and before
+ *	mmc_wait_for_req_done(). If it is called at other times the
  *	result is not meaningful.
  */
 bool mmc_is_req_done(struct mmc_host *host, struct mmc_request *mrq)
diff --git a/drivers/mmc/core/core.h b/drivers/mmc/core/core.h
index 601c737..9be2875 100644
--- a/drivers/mmc/core/core.h
+++ b/drivers/mmc/core/core.h
@@ -170,7 +170,7 @@ int mmc_cqe_recovery(struct mmc_host *host);
  *	@host: MMC host to prepare command
  *	@mrq: MMC request to prepare for
  *
- *	mmc_pre_req() is called in prior to mmc_start_req() to let
+ *	mmc_pre_req() is called in prior to mmc_start_request() to let
  *	host prepare for the new request. Preparation of a request may be
  *	performed while another request is running on the host.
  */
-- 
2.7.4


  parent reply	other threads:[~2026-09-17 16:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17  8:48 [PATCH 0/3] Small improvement about mmc documentation Shawn Lin
2026-09-17  8:48 ` [PATCH 1/3] docs: mmc: document eMMC health status support in mmc-tools Shawn Lin
2026-09-17  8:48 ` [PATCH 2/3] docs: mmc: fix stale async request documentation Shawn Lin
2026-09-17  8:48 ` Shawn Lin [this message]
2026-09-28 16:13 ` [PATCH 0/3] Small improvement about mmc documentation Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1789634917-143165-4-git-send-email-shawn.lin@rock-chips.com \
    --to=shawn.lin@rock-chips.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=shawn.lin@linux.dev \
    --cc=ulfh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®