From: "tip-bot2 for Peter Fang" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Peter Fang <peter.fang@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: x86/tdx] x86/tdx: Add a helper to query maximum Quote size
Date: Fri, 02 Oct 2026 16:29:44 -0000 [thread overview]
Message-ID: <179095858462.3910103.3489250100172784695.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260930103739.2851980-6-peter.fang@intel.com>
The following commit has been merged into the x86/tdx branch of tip:
Commit-ID: a2bf0ccd55b14a577e5bd16a245602687072b5fd
Gitweb: https://git.kernel.org/tip/a2bf0ccd55b14a577e5bd16a245602687072b5fd
Author: Peter Fang <peter.fang@intel.com>
AuthorDate: Wed, 30 Sep 2026 03:30:54 -07:00
Committer: Dave Hansen <dave.hansen@linux.intel.com>
CommitterDate: Fri, 02 Oct 2026 09:03:53 -07:00
x86/tdx: Add a helper to query maximum Quote size
Newer crypto algorithms can make Quotes larger, so guests can no longer
rely on a fixed-size buffer.
The TDX module added a new ABI that reports the largest possible Quote
size via a metadata field [1]. Add a helper to query the size instead of
exposing tdg_vm_rd() directly, as it can read arbitrary metadata fields.
The reported size covers every Quote type the platform can produce,
including SGX-based Quotes.
AI was used under supervision to collect/apply feedback, review code and
workshop logs.
[1] Intel TDX Module ABI Definitions, August 2026, TD-scope metadata
field "TD_QUOTE_MAX_SIZE"
Signed-off-by: Peter Fang <peter.fang@intel.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
Link: https://patch.msgid.link/20260930103739.2851980-6-peter.fang@intel.com
---
arch/x86/coco/tdx/tdx.c | 16 ++++++++++++++++
arch/x86/include/asm/shared/tdx.h | 1 +
arch/x86/include/asm/tdx.h | 2 ++
3 files changed, 19 insertions(+)
diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c
index 92c2438..02c2871 100644
--- a/arch/x86/coco/tdx/tdx.c
+++ b/arch/x86/coco/tdx/tdx.c
@@ -198,6 +198,22 @@ u64 tdx_hcall_get_quote(void *buf, size_t size)
}
EXPORT_SYMBOL_FOR_MODULES(tdx_hcall_get_quote, "tdx-guest");
+/*
+ * Ask the TDX module what the largest Quote on the host platform might be.
+ */
+int tdx_get_max_quote_size(u64 *max_quote_size)
+{
+ u64 err;
+
+ err = tdg_vm_rd(TDCS_QUOTE_MAX_SIZE, max_quote_size);
+
+ /* Old modules do not support this. Tell the caller. */
+ if (err)
+ return -EINVAL;
+
+ return 0;
+}
+
static void __noreturn tdx_panic(const char *msg)
{
struct tdx_module_args args = {
diff --git a/arch/x86/include/asm/shared/tdx.h b/arch/x86/include/asm/shared/tdx.h
index f2cfa71..f1c5439 100644
--- a/arch/x86/include/asm/shared/tdx.h
+++ b/arch/x86/include/asm/shared/tdx.h
@@ -50,6 +50,7 @@
/* TDX TD-Scope Metadata. To be used by TDG.VM.WR and TDG.VM.RD */
#define TDCS_CONFIG_FLAGS 0x1110000300000016
#define TDCS_TD_CTLS 0x1110000300000017
+#define TDCS_QUOTE_MAX_SIZE 0x9010000200000007
#define TDCS_NOTIFY_ENABLES 0x9100000000000010
#define TDCS_TOPOLOGY_ENUM_CONFIGURED 0x9100000000000019
diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h
index 97bf6c8..1fcfaed 100644
--- a/arch/x86/include/asm/tdx.h
+++ b/arch/x86/include/asm/tdx.h
@@ -84,6 +84,8 @@ int tdx_mcall_extend_rtmr(u8 index, u8 *data);
u64 tdx_hcall_get_quote(void *buf, size_t size);
+int tdx_get_max_quote_size(u64 *max_quote_size);
+
void __init tdx_dump_attributes(u64 td_attr);
void __init tdx_dump_td_ctls(u64 td_ctls);
next prev parent reply other threads:[~2026-10-02 16:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 10:30 [PATCH v6 0/6] tdx-guest: Make Quote buffer size dynamic Peter Fang
2026-09-30 10:30 ` [PATCH v6 1/6] x86/tdx: Take the Quote buffer as a generic pointer Peter Fang
2026-10-02 11:54 ` [tip: x86/tdx] " tip-bot2 for Peter Fang
2026-10-02 16:29 ` tip-bot2 for Peter Fang
2026-09-30 10:30 ` [PATCH v6 2/6] virt: tdx-guest: Give the Quote buffer an explicit type Peter Fang
2026-10-02 11:54 ` [tip: x86/tdx] " tip-bot2 for Peter Fang
2026-10-02 16:29 ` tip-bot2 for Peter Fang
2026-09-30 10:30 ` [PATCH v6 3/6] virt: tdx-guest: Calculate the Quote buffer size safely Peter Fang
2026-10-02 11:54 ` [tip: x86/tdx] " tip-bot2 for Peter Fang
2026-10-02 16:29 ` tip-bot2 for Peter Fang
2026-09-30 10:30 ` [PATCH v6 4/6] virt: tdx-guest: Add a helper for the Quote buffer size Peter Fang
2026-09-30 22:14 ` Edgecombe, Rick P
2026-09-30 22:52 ` Peter Fang
2026-09-30 22:58 ` Edgecombe, Rick P
2026-10-02 11:54 ` [tip: x86/tdx] " tip-bot2 for Peter Fang
2026-10-02 16:29 ` tip-bot2 for Peter Fang
2026-09-30 10:30 ` [PATCH v6 5/6] x86/tdx: Add a helper to query maximum Quote size Peter Fang
2026-10-02 11:53 ` [tip: x86/tdx] " tip-bot2 for Peter Fang
2026-10-02 16:29 ` tip-bot2 for Peter Fang [this message]
2026-09-30 10:30 ` [PATCH v6 6/6] virt: tdx-guest: Make the Quote buffer size dynamic Peter Fang
2026-10-02 11:53 ` [tip: x86/tdx] " tip-bot2 for Peter Fang
2026-10-02 16:29 ` tip-bot2 for Peter Fang
2026-09-30 22:17 ` [PATCH v6 0/6] tdx-guest: Make " Edgecombe, Rick P
2026-09-30 22:54 ` Peter Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179095858462.3910103.3489250100172784695.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peter.fang@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®