From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBC163E8338; Wed, 30 Sep 2026 19:29:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.251.229.89 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790796586; cv=none; b=nvtbNbyqrrHL7AS3XOlSQHY/ztMclQkfWmVaaJq+YiG8rAvhSBxquF4kPGS25ldkvNhDpfhwCBelujgWoycDr795UUKR9huUIsYJu3g6Nz418+t9/wQ7dq1Fhu+K9y7lhqJoxkUgxfrRtJkNjjHlWs0nfAlkwD9SYrxGyGAG66I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790796586; c=relaxed/simple; bh=mFHBAohtZ7YN4nog88mmrblodSh3GrnDWNSnrXiIaRY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W8Pm7Pbw5SCdqbRy3Df9O8fdaTQQC/FLnack7EELOOtt2Jua0ywO97coVf0gqEIzIE6S1WY/g1CZviN82py4QxBOCcATGEt8za0cjiZIB/vGvbDSSeXA0p1gLi1fIcfMOVmLdY3LmlZux+DANmTMxbfiAoHUThaAByIhDESUhec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b=itQpGtQc; arc=none smtp.client-ip=178.251.229.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b="itQpGtQc" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A0AE1106FC1; Wed, 30 Sep 2026 21:29:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1790796578; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=dR7TRsCJ25q9nKc0aVFqV0DBkjf9gpIXafQpdl4hBAg=; b=itQpGtQcIgyGw8VPcQ4FGKI7x/CWWKMkTXKgixCP51xt6XRKDhdqbztd3DgbcmMAv3HCJu PGl0CIE9TMjyMVw0GIiS6WrK7kePbt9Z4/qhqfIJo8K7o5F7JnosFh8qId5aIKAgoxsKms uP9ZSHKbJVLd30xpQOBrwmP4kMzFDDl2NliEa1QzgEkMMNR9wfK/2+oZY281MqTxbcybBK i+jzt338VIohdETUZTSrPbfEXyM3EcgbNWGbSs/t4hhWS6/fUE/3LuVpBQM/WMGedAtpMM iWoDG1XQTduklzEXFNRVsxPnxgdNHLOxfX3eJCipscNPT3L6xk+XiGBkUb1zbw== Message-ID: <17f240e5-9c65-4562-ba51-535b0c69c5fd@nabladev.com> Date: Wed, 30 Sep 2026 21:29:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/3] arm64: dts: imx95: Add support for Data Modul i.MX95 eDM SBC To: Frank Li , Francesco Dolcini Cc: linux-arm-kernel@lists.infradead.org, Aswath Govindraju , Conor Dooley , Fabio Estevam , Frank Li , Krzysztof Kozlowski , Marc Kleine-Budde , Rob Herring , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260928204741.175754-1-marex@nabladev.com> <20260928204741.175754-3-marex@nabladev.com> <49303872-5622-4e1d-8e1a-01394ec29367@nabladev.com> <20260930174413.GA2463938@francesco-nb> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 9/30/26 8:57 PM, Frank Li wrote: > On Wed, Sep 30, 2026 at 07:44:13PM +0200, Francesco Dolcini wrote: >> On Tue, Sep 29, 2026 at 05:20:27PM +0200, Marek Vasut wrote: >>> On 9/29/26 4:45 PM, Frank Li wrote: >>> >>> Hello Frank, >>> >>>>> + backlight_lvds: backlight-lvds { >>>>> + compatible = "pwm-backlight"; >>>>> + pinctrl-names = "default"; >>>>> + pinctrl-0 = <&pinctrl_panel_backlight_lvds>; >>>>> + brightness-levels = <0 1 10 20 30 40 50 60 70 75 80 90 100>; >>>>> + default-brightness-level = <7>; >>>>> + enable-gpios = <&gpio2 27 GPIO_ACTIVE_HIGH>; >>>>> + pwms = <&tpm3 3 5000000 0>; >>>>> + /* Disabled by default, unless display board plugged in. */ >>>>> + status = "disabled"; >>>>> + }; >>>> >>>> The both backlight is not used in this dts, can you remove it and >>>> add these when it real use. >>> It's the same thing we do on the other boards, so I would prefer to keep >>> this consistent: >> >> I agree with Marek, and I would not use the criteria about being used or >> not. > > > Others boards: some has dtso, which use it. And krzy have some concern for > similar case although he have not reply alex's answer. > > https://lore.kernel.org/imx/30599533-91de-41fd-9420-3f8693ec92ac@kernel.org/ > > And it is most likely go through nexus connector node to support display > panel in future. I do not think nexus node will apply to this connector, no. > So I suggest remove it now and add it when need. Can we please go with consistency between these boards from one vendor ? Thank you.