From: Dave Hansen <dave.hansen@intel.com>
To: Sohil Mehta <sohil.mehta@intel.com>,
x86@kernel.org, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
Uros Bizjak <ubizjak@gmail.com>,
Sandipan Das <sandipan.das@amd.com>,
Sean Christopherson <seanjc@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Vegard Nossum <vegard.nossum@oracle.com>,
Tony Luck <tony.luck@intel.com>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Nikolay Borisov <nik.borisov@suse.com>,
Eric Biggers <ebiggers@google.com>, Xin Li <xin3.li@intel.com>,
Alexander Shishkin <alexander.shishkin@intel.com>,
Kirill Shutemov <kirill.shutemov@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/cpufeature: Add feature dependency checks
Date: Wed, 30 Oct 2024 16:39:39 -0700 [thread overview]
Message-ID: <1c1c25f4-2aa3-42cb-87e2-0bc54b2d0e07@intel.com> (raw)
In-Reply-To: <20241030233118.615493-1-sohil.mehta@intel.com>
On 10/30/24 16:31, Sohil Mehta wrote:
> Unexpected failures can occur when the kernel tries to use such a
> feature. Rather than debug such scenarios, it would be better to
> disable the feature upfront.
It Looks OK and sane to me. It's nice that it inherits the "Loop until
we get a stable state" from do_clear_cpu_cap().
Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
next prev parent reply other threads:[~2024-10-30 23:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 23:31 Sohil Mehta
2024-10-30 23:39 ` Dave Hansen [this message]
2024-10-30 23:44 ` Luck, Tony
2024-10-30 23:57 ` Sohil Mehta
2024-10-31 1:59 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c1c25f4-2aa3-42cb-87e2-0bc54b2d0e07@intel.com \
--to=dave.hansen@intel.com \
--cc=alexander.shishkin@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=ebiggers@google.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=seanjc@google.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=ubizjak@gmail.com \
--cc=vegard.nossum@oracle.com \
--cc=x86@kernel.org \
--cc=xin3.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®