mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
	Nicolas Dufresne <nicolas.dufresne@collabora.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Detlev Casanova <detlev.casanova@collabora.com>,
	Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@kernel.org>,
	kernel@collabora.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Conor Dooley <conor.dooley@microchip.com>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v2 1/3] media: dt-bindings: rockchip,vdec: Correct reg-names order for RK35{76,88}
Date: Tue, 24 Feb 2026 15:34:36 +0100	[thread overview]
Message-ID: <1cdc36f2-6e51-492a-9063-7d0a784f5118@kernel.org> (raw)
In-Reply-To: <0c9a158a-f70e-461c-900b-6f6485064a02@collabora.com>

On 24/02/2026 15:07, Cristian Ciocaltea wrote:
> On 2/24/26 3:54 PM, Krzysztof Kozlowski wrote:
>> On 24/02/2026 14:48, Nicolas Dufresne wrote:
>>> Le mardi 24 février 2026 à 14:18 +0100, Krzysztof Kozlowski a écrit :
>>>> On 24/02/2026 14:14, Nicolas Dufresne wrote:
>>>>>>>  
>>>>>>>    reg-names:
>>>>>>> -    items:
>>>>>>> +    oneOf:
>>>>>>>        - const: function
>>>>>>> -      - const: link
>>>>>>> -      - const: cache
>>>>>>> +      - items:
>>>>>>> +          - const: link
>>>>>>> +          - const: function
>>>>>>> +          - const: cache
>>>>>>
>>>>>> No, ABI break without point.
>>>>>
>>>>> Its not released yet, otherwise both order would need to be allowed.
>>>>>
>>>> Also, not true.
>>>>
>>>> git describe --contains  c6ffb7e1fb90
>>>> v6.17-rc1~90^2~3
>>>
>>> Ack, I thought this was part of 7.0, it would have been logical to be part of
>>> 7.0-rc1 I must say. Whatever happen, backward compat will unfortunatly be
>>> needed.
>>
>>
>> I was here checking the binding, so the ABI. DTS maybe was in v7.0-rc1
>> indeed. Anyway, the commit msg should describe the impact on users of
>> this ABI, at least known users.
> 
> My bad, I only checked the DTS changes which landed in v7.0-rc1, and wrongly
> assumed the binding also landed about the same time.  I think it's unlikely
> there are any (external) users of this binding, but obviously we cannot be 100%
> sure.
> 
> Would it be acceptable to extend the binding so that it allows both the current
> and the new proposed order to coexist?

Depends also on the drivers and that's your "users analysis" should
cover. If there are no known released users of relatively new ABI, it is
fine to propose the change with such explanation and reason - poor
hardware description because convention expects the main device's
address to be used as first "reg" entry.

You can have also oneOf with older list "deprecated: true", if want to
keep any users unaffected.


Best regards,
Krzysztof

  reply	other threads:[~2026-02-24 14:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 19:49 [PATCH v2 0/3] arm64: dts: rockchip: Fix vdec register blocks order on RK3576/RK3588 Cristian Ciocaltea
2026-02-23 19:49 ` [PATCH v2 1/3] media: dt-bindings: rockchip,vdec: Correct reg-names order for RK35{76,88} Cristian Ciocaltea
2026-02-23 23:05   ` Heiko Stübner
2026-02-24  7:17   ` Krzysztof Kozlowski
2026-02-24 13:14     ` Nicolas Dufresne
2026-02-24 13:17       ` Krzysztof Kozlowski
2026-02-24 13:18       ` Krzysztof Kozlowski
2026-02-24 13:48         ` Nicolas Dufresne
2026-02-24 13:54           ` Krzysztof Kozlowski
2026-02-24 14:07             ` Cristian Ciocaltea
2026-02-24 14:34               ` Krzysztof Kozlowski [this message]
2026-02-23 19:49 ` [PATCH v2 2/3] arm64: dts: rockchip: Fix vdec register blocks order on RK3576 Cristian Ciocaltea
2026-02-24  7:22   ` Krzysztof Kozlowski
2026-02-24 13:17     ` Nicolas Dufresne
2026-02-24 13:20       ` Krzysztof Kozlowski
2026-02-23 19:49 ` [PATCH v2 3/3] arm64: dts: rockchip: Fix vdec register blocks order on RK3588 Cristian Ciocaltea
2026-02-24  7:18   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1cdc36f2-6e51-492a-9063-7d0a784f5118@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=detlev.casanova@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=heiko@sntech.de \
    --cc=hverkuil@kernel.org \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=nicolas.dufresne@collabora.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®