From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B33EDC433FE for ; Thu, 27 Jan 2022 23:40:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240843AbiA0Xkb (ORCPT ); Thu, 27 Jan 2022 18:40:31 -0500 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:29328 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236183AbiA0Xk3 (ORCPT ); Thu, 27 Jan 2022 18:40:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1643326829; x=1674862829; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=NadNmmlzB77tjWV3btgPpuY8pP8FjW2UhgusoP+QS6Q=; b=mcK13YUVyoFCbp1KL9NqbqiDdgT+uv7U1x/XHLbRyQ2V0PYC7Fiyu1nN dGvw6G4K3Zk+GX2ltblQBtzBxWS3JDeoBzIjG1q9v0/6wqe3XcmJSG/Ns vzK7EwSNCqGfy7C9wkLadbbUMRLMb3hfFB1LDQbUgfNheSW5dLN00os/U RVy50YdJSOZHw3qzJXnXwUoHdur0UIg8eZzScxR0rwoAEFsliGjOxJK2/ aopplapo+iISK2XuuSlOSBiAAPC0FETlkFk3cg3ZNDZNgLSiRMsaSgejV UTWdc8RBy/Q3T7s/Pjg6k8C/CVO5Y2xfBavx2I4t0zj8cCJRJU6tO7ACK Q==; X-IronPort-AV: E=Sophos;i="5.88,321,1635177600"; d="scan'208";a="190527647" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 28 Jan 2022 07:40:26 +0800 IronPort-SDR: Z2ELwoIs1efN8JuuY3engaWvvgOdREU51OLTUT1TKWPrcz2NpOMHPXpQ1dglrQ50uppbXeSxmF iahdlzMVdxOQShzuylFkDD0uPF41JBUjRELRqCVCZUYmNKopN7tDuZicXPGEsfAwnqN2FL+Ghl L4fayg97KTjcnSG9VH0bZsCy10qvPcj+/NqeLKTtOJ4fIYANikhVa7LnyS06QPDZKYZ2QRc/M2 0crTVNwG6wgHx5kdCXWdSEImQMof12DDZmtoZfR0LOgfWP4ORLm8Fz+yV3sq0bd2FgK9wV76l0 z+SSDgr4O2hw/uNwHXZ73431 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 15:12:28 -0800 IronPort-SDR: EeVO0xmhKZfYIqKQ0zM5NTkEz5km3/aFdebLn4EAhGa2hruyQE1oGXGnAX/MTGak+ILbK8ux1z 8/2nbXwT374y1n5F0jvUt+sIm4n9EmuiiPPqI6zWpkWyVvozna2uFHiTtsHwEQbCRQjOU0AG/M xr53lYyteDdo0SBHJvSDkQqZutSLpu3sDo6117WnbfZbWaujikg4IyxcXKddQ2KTRKfIhHxNqy 3si/11f+aDl2c6cHqPVrUc+jtaANYtRMVIDLxmqYwz8ohXqk2SgPZpCDI3JbFfLkYB4VkzaHuc kvs= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 15:40:25 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4JlHBw1sLjz1SHwl for ; Thu, 27 Jan 2022 15:40:24 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1643326823; x=1645918824; bh=NadNmmlzB77tjWV3btgPpuY8pP8FjW2Uhgu soP+QS6Q=; b=mmxXZQaAAE8JX0xcWzjYN/RQjp7ffAG07LDEOx+Y7/fDXlMPk38 RAk5ew9fWQy8kvk4gIE87CINNyf8TThx22aVxlHcXJKk9G1mmgo0JxKsCKCzIMP9 +6EIAGK9Jm3HdpSiwPMmSQZn4YGRug+CcyO+Xca9MWOM0yoTwQoptZh5gr75HWhz PbFZ6OWgiyhKA8Bdqtcjt6emolxMuO5uZd6FTvtGm8uNwrto1eexOy8JdXPl8LuJ CCMzDRjjAb+X8PxXNr2FbKr3PhdaeFq0drndTXTl8wTpHnb35fqrZGkcieynigKd eHKTp4xrXd7RxV42fsan+RVpLIniUzZdBLw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 5jJT92-VmVVl for ; Thu, 27 Jan 2022 15:40:23 -0800 (PST) Received: from [10.225.163.58] (unknown [10.225.163.58]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4JlHBt4Tpfz1RvlN; Thu, 27 Jan 2022 15:40:22 -0800 (PST) Message-ID: <1ef3e995-3f61-ef53-0d5e-03bb41a52624@opensource.wdc.com> Date: Fri, 28 Jan 2022 08:40:21 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] ata: ahci: Skip 200 ms debounce delay for Marvell 88SE9235 Content-Language: en-US To: Paul Menzel Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220127233527.445659-1-pmenzel@molgen.mpg.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220127233527.445659-1-pmenzel@molgen.mpg.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/28/22 08:35, Paul Menzel wrote: > The 200 ms delay before debouncing the PHY in `sata_link_resume()` is > not needed for the Marvell 88SE9235. >=20 > $ lspci -nn -s 0021:0e:00.0 > 0021:0e:00.0 SATA controller [0106]: Marvell Technology Group Ltd. = 88SE9235 PCIe 2.0 x2 4-port SATA 6 Gb/s Controller [1b4b:9235] (rev 11) >=20 > So, remove it. Tested on IBM S822LC with current Linux 5.17-rc1: >=20 > Without this patch (with 200 ms delay): >=20 > [ 3.358158] ata1: SATA max UDMA/133 abar m2048@0x3fe881000000 po= rt 0x3fe881000100 irq 39 > [ 3.358175] ata2: SATA max UDMA/133 abar m2048@0x3fe881000000 po= rt 0x3fe881000180 irq 39 > [ 3.358191] ata3: SATA max UDMA/133 abar m2048@0x3fe881000000 po= rt 0x3fe881000200 irq 39 > [ 3.358207] ata4: SATA max UDMA/133 abar m2048@0x3fe881000000 po= rt 0x3fe881000280 irq 39 > [=E2=80=A6] > [ 3.677542] ata3: SATA link down (SStatus 0 SControl 300) > [ 3.677719] ata4: SATA link down (SStatus 0 SControl 300) > [ 3.839242] ata2: SATA link up 6.0 Gbps (SStatus 133 SControl 30= 0) > [ 3.839828] ata2.00: ATA-10: ST1000NX0313 00LY266 00LY26= 5IBM, BE33, max UDMA/133 > [ 3.840029] ata2.00: 1953525168 sectors, multi 0: LBA48 NCQ (dep= th 32), AA > [ 3.841796] ata2.00: configured for UDMA/133 > [ 3.843231] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 30= 0) > [ 3.844083] ata1.00: ATA-10: ST1000NX0313 00LY266 00LY26= 5IBM, BE33, max UDMA/133 > [ 3.844313] ata1.00: 1953525168 sectors, multi 0: LBA48 NCQ (dep= th 32), AA > [ 3.846043] ata1.00: configured for UDMA/133 >=20 > With patch (no delay): >=20 > [ 3.624259] ata1: SATA max UDMA/133 abar m2048@0x3fe881000000 po= rt 0x3f e881000100 irq 39 > [ 3.624436] ata2: SATA max UDMA/133 abar m2048@0x3fe881000000 po= rt 0x3f e881000180 irq 39 > [ 3.624452] ata3: SATA max UDMA/133 abar m2048@0x3fe881000000 po= rt 0x3f e881000200 irq 39 > [ 3.624468] ata4: SATA max UDMA/133 abar m2048@0x3fe881000000 po= rt 0x3f e881000280 irq 39 > [=E2=80=A6] > [ 3.731966] ata3: SATA link down (SStatus 0 SControl 300) > [ 3.732069] ata4: SATA link down (SStatus 0 SControl 300) > [ 3.897448] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 30= 0) > [ 3.897678] ata2: SATA link up 6.0 Gbps (SStatus 133 SControl 30= 0) > [ 3.898140] ata1.00: ATA-10: ST1000NX0313 00LY266 00LY26= 5IBM, BE33, max UDMA/133 > [ 3.898175] ata2.00: ATA-10: ST1000NX0313 00LY266 00LY26= 5IBM, BE33, max UDMA/133 > [ 3.898287] ata1.00: 1953525168 sectors, multi 0: LBA48 NCQ (dep= th 32), AA > [ 3.898349] ata2.00: 1953525168 sectors, multi 0: LBA48 NCQ (dep= th 32), AA > [ 3.900070] ata1.00: configured for UDMA/133 > [ 3.900166] ata2.00: configured for UDMA/133 >=20 > Signed-off-by: Paul Menzel > --- > drivers/ata/ahci.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index ab5811ef5a53..edca4e8fd44e 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -582,6 +582,8 @@ static const struct pci_device_id ahci_pci_tbl[] =3D= { > .driver_data =3D board_ahci_yes_fbs }, > { PCI_DEVICE(PCI_VENDOR_ID_MARVELL_EXT, 0x9230), > .driver_data =3D board_ahci_yes_fbs }, > + { PCI_DEVICE(PCI_VENDOR_ID_MARVELL_EXT, 0x9235), > + .driver_data =3D board_ahci_no_debounce_delay }, > { PCI_DEVICE(PCI_VENDOR_ID_TTI, 0x0642), /* highpoint rocketraid 642L= */ > .driver_data =3D board_ahci_yes_fbs }, > { PCI_DEVICE(PCI_VENDOR_ID_TTI, 0x0645), /* highpoint rocketraid 644L= */ Looks good. But for the commit message, instead of the dmesg copy-paste, could you simply write the gains in terms of shortened scan time ? That would make it easier to understand the benefits of the patch. Also, there is no need for the lspci output. --=20 Damien Le Moal Western Digital Research