From: Christoph Hellwig <hch@infradead.org>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"David A. Hinds" <dahinds@users.sourceforge.net>,
linux-pcmcia <linux-pcmcia@lists.infradead.org>
Subject: Re: [PATCH] check the return value of __copy_to_user in drivers/pcmcia/ds.c::ds_ioctl and return -EFAULT if it fails
Date: Wed, 6 Oct 2004 11:43:42 +0100 [thread overview]
Message-ID: <20041006114342.B29243@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0410060012590.2913@dragon.hygekrogen.localhost>; from juhl-lkml@dif.dk on Wed, Oct 06, 2004 at 12:21:58AM +0200
On Wed, Oct 06, 2004 at 12:21:58AM +0200, Jesper Juhl wrote:
>
> CC drivers/pcmcia/ds.o
> include/asm/uaccess.h: In function `ds_ioctl':
> drivers/pcmcia/ds.c:1049: warning: ignoring return value of `__copy_to_user', declared with attribute warn_unused_result
>
> Patch adds a check of the return value and returns -EFAULT if
> __copy_to_user fails.
I think this function should use the non-__ prefix version and remove access_ok
again
next prev parent reply other threads:[~2004-10-06 10:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-05 22:21 Jesper Juhl
2004-10-06 10:43 ` Christoph Hellwig [this message]
2004-10-06 20:25 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041006114342.B29243@infradead.org \
--to=hch@infradead.org \
--cc=dahinds@users.sourceforge.net \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®