From: Christian Borntraeger <cborntra@de.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Arjan van de Ven <arjan@infradead.org>, Andrew Morton <akpm@osdl.org>
Subject: [PATCH] reintroduce EXPORT_SYMBOL(task_nice) for binfmt_elf32
Date: Thu, 13 Jan 2005 20:42:30 +0100 [thread overview]
Message-ID: <200501132042.31215.cborntra@de.ibm.com> (raw)
Building an s390x kernel with binfmt_elf32 as a module, I get the following
errors:
*** Warning: "task_nice" [arch/s390/kernel/binfmt_elf32.ko] undefined!
*** Warning: "arch_pick_mmap_layout" [arch/s390/kernel/binfmt_elf32.ko]
undefined!
IIRC 2.6.8 did not show this problem. Therefore I suggest to revert the
removal of the EXPORT_SYMBOL(task_nice). The rationale for removing the
export was the fact, that binfmt_elf is no longer modular. Unfortunately
that is not true in the emulation case on s390 and (untested) sparc64.
If there are no objections, please apply.
--- a/kernel/sched.c 2005-01-12 01:42:35 +01:00
+++ b/kernel/sched.c 2005-01-12 23:25:22 +01:00
@@ -3187,6 +3187,8 @@
return TASK_NICE(p);
}
+EXPORT_SYMBOL(task_nice);
+
/**
* idle_cpu - is a given cpu idle currently?
* @cpu: the processor in question.
next reply other threads:[~2005-01-13 19:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-13 19:42 Christian Borntraeger [this message]
2005-01-13 19:48 ` Christoph Hellwig
2005-01-13 21:02 ` Christian Borntraeger
2005-01-13 21:05 ` Christoph Hellwig
2005-01-13 22:29 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501132042.31215.cborntra@de.ibm.com \
--to=cborntra@de.ibm.com \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®