From: Andrew Morton <akpm@osdl.org>
To: Andy Whitcroft <apw@shadowen.org>
Cc: apw@shadowen.org, kravetz@us.ibm.com, haveblue@us.ibm.com,
lhms-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] register_ and unregister_memory_notifier should be global
Date: Mon, 14 Nov 2005 15:23:16 -0800 [thread overview]
Message-ID: <20051114152316.4060d30c.akpm@osdl.org> (raw)
In-Reply-To: <20051114193738.GA15494@shadowen.org>
Andy Whitcroft <apw@shadowen.org> wrote:
>
> Both register_memory_notifer and unregister_memory_notifier are global
> and declared so in linux.h. Update the HOTPLUG specific definitions
> to match. This fixes a compile warning when HOTPLUG is enabled.
>
There is no linux.h and I can find no .h file which declares
register_memory_notifier(). Please clarify?
> ---
> memory.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff -upN reference/drivers/base/memory.c current/drivers/base/memory.c
> --- reference/drivers/base/memory.c
> +++ current/drivers/base/memory.c
> @@ -50,12 +50,12 @@ static struct kset_hotplug_ops memory_ho
>
> static struct notifier_block *memory_chain;
>
> -static int register_memory_notifier(struct notifier_block *nb)
> +int register_memory_notifier(struct notifier_block *nb)
> {
> return notifier_chain_register(&memory_chain, nb);
> }
>
> -static void unregister_memory_notifier(struct notifier_block *nb)
> +void unregister_memory_notifier(struct notifier_block *nb)
> {
> notifier_chain_unregister(&memory_chain, nb);
> }
next prev parent reply other threads:[~2005-11-14 23:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-14 19:37 [PATCH 0/4] Squash hotplug warnings Andy Whitcroft
2005-11-14 19:37 ` [PATCH 1/4] __add_section remove unused pgdat definition Andy Whitcroft
2005-11-14 19:37 ` [PATCH 2/4] register_ and unregister_memory_notifier should be global Andy Whitcroft
2005-11-14 23:23 ` Andrew Morton [this message]
2005-11-15 0:30 ` mike kravetz
2005-11-15 1:17 ` Andrew Morton
2005-11-14 19:37 ` [PATCH 3/4] register_memory " Andy Whitcroft
2005-11-14 19:37 ` [PATCH 4/4] memory_hotplug_name should be const Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051114152316.4060d30c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=haveblue@us.ibm.com \
--cc=kravetz@us.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®