From: Andrew Morton <akpm@osdl.org>
To: Pavel Machek <pavel@suse.cz>
Cc: rmk+lkml@arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Convert serial_core oopses to BUG_ON
Date: Tue, 28 Feb 2006 10:17:13 -0800 [thread overview]
Message-ID: <20060228101713.6fd44027.akpm@osdl.org> (raw)
In-Reply-To: <20060227141315.GD2429@ucw.cz>
Pavel Machek <pavel@suse.cz> wrote:
>
>
> On Sun 26-02-06 02:14:14, Andrew Morton wrote:
> > Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> > >
> > > Calling serial functions to flush buffers, or try to send more data
> > > after the port has been closed or hung up is a bug in the code doing
> > > the calling, not in the serial_core driver.
> > >
> > > Make this explicitly obvious by adding BUG_ON()'s.
> >
> > If we make it
> >
> > if (!info) {
> > WARN_ON(1);
> > return;
> > }
> >
> > will that allow people's kernels to limp along until it gets fixed?
>
> It will oops in hard-to-guess, place, anyway.
Will it? Where? Unfixably?
> BUG_ON is right.
WARN_ON+return is far better. It keeps people's machines working until the
bug gets fixed.
next prev parent reply other threads:[~2006-02-28 18:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-26 10:05 Russell King
2006-02-26 10:14 ` Andrew Morton
2006-02-26 10:18 ` Nick Piggin
2006-02-26 18:17 ` Russell King
2006-02-26 20:00 ` Russell King
2006-02-27 14:13 ` Pavel Machek
2006-02-28 18:17 ` Andrew Morton [this message]
2006-02-28 22:01 ` Martin Michlmayr
2006-02-28 23:32 ` Andrew Morton
2006-03-01 17:10 ` Russell King
2006-03-01 19:47 ` Pavel Machek
2006-03-01 22:32 ` Andrew Morton
[not found] <5Kr1a-6MF-15@gated-at.bofh.it>
[not found] ` <5KraE-6XP-15@gated-at.bofh.it>
[not found] ` <5KyFv-RL-15@gated-at.bofh.it>
2006-02-26 22:34 ` Karol Kozimor
2006-02-26 22:41 ` Russell King
[not found] <20060227162827.GC2389@ucw.cz>
2006-03-01 19:00 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060228101713.6fd44027.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®