mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jerome Marchand <jmarchan@redhat.com>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ptrace_untrace: use wake_up_process() instead of bogus signal_wake_up()
Date: Sun,  8 Feb 2009 17:38:04 -0800 (PST)	[thread overview]
Message-ID: <20090209013804.C99B3FC330@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of  Sunday, 8 February 2009 19:47:27 +0100 <20090208184727.GA27081@redhat.com>

> Both ptrace_stop() and do_signal_stop() pathes always take ->siglock and
> do recalc_sigpending() after wakeup.

Yes, that's true.  But so what?  Why is this a reason to introduce yet
another unconditional (i.e. wrong) wake_up_process?  signal_wake_up does
the job fine, i.e. it calls wake_up_state the right way.  For exactly the
reasons you cited, setting TIF_SIGPENDING is both superfluous and
harmless--its effects will happen upon resume whether it was set or not.
So what's wrong with signal_wake_up?


Thanks,
Roland

  reply	other threads:[~2009-02-09  1:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-08 18:47 Oleg Nesterov
2009-02-09  1:38 ` Roland McGrath [this message]
2009-02-09  2:42   ` Oleg Nesterov
2009-02-09  3:42     ` Roland McGrath
2009-02-10 21:35       ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090209013804.C99B3FC330@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dvlasenk@redhat.com \
    --cc=jmarchan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®