mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Subject: [PATCH v2 06/12] ACPI: processor: remove early _PDC optin quirks
Date: Mon, 22 Feb 2010 12:11:34 -0700	[thread overview]
Message-ID: <20100222191134.19752.43236.stgit@bob.kio> (raw)
In-Reply-To: <20100222190145.19752.20978.stgit@bob.kio>

Now that we check for physically present processors before blindly
evaluating _PDC, we no longer need to maintain a DMI opt-in table
nor a kernel param.

Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Alex Chiang <achiang@hp.com>
---

 Documentation/kernel-parameters.txt |    4 ----
 drivers/acpi/processor_core.c       |   37 -----------------------------------
 2 files changed, 0 insertions(+), 41 deletions(-)

diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index 404864d..d2e84d1 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -198,10 +198,6 @@ and is between 256 and 4096 characters. It is defined in the file
 			acpi_display_output=video
 			See above.
 
-	acpi_early_pdc_eval	[HW,ACPI] Evaluate processor _PDC methods
-				early. Needed on some platforms to properly
-				initialize the EC.
-
 	acpi_irq_balance [HW,ACPI]
 			ACPI will balance active IRQs
 			default in APIC mode
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index f0c68c1..ef34faa 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -341,36 +341,6 @@ void acpi_processor_set_pdc(acpi_handle handle)
 }
 EXPORT_SYMBOL_GPL(acpi_processor_set_pdc);
 
-static int early_pdc_optin;
-static int set_early_pdc_optin(const struct dmi_system_id *id)
-{
-	early_pdc_optin = 1;
-	return 0;
-}
-
-static int param_early_pdc_optin(char *s)
-{
-	early_pdc_optin = 1;
-	return 1;
-}
-__setup("acpi_early_pdc_eval", param_early_pdc_optin);
-
-static struct dmi_system_id __cpuinitdata early_pdc_optin_table[] = {
-	{
-	set_early_pdc_optin, "HP Envy", {
-	DMI_MATCH(DMI_BIOS_VENDOR, "Hewlett-Packard"),
-	DMI_MATCH(DMI_PRODUCT_NAME, "HP Envy") }, NULL},
-	{
-	set_early_pdc_optin, "HP Pavilion dv6", {
-	DMI_MATCH(DMI_BIOS_VENDOR, "Hewlett-Packard"),
-	DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6") }, NULL},
-	{
-	set_early_pdc_optin, "HP Pavilion dv7", {
-	DMI_MATCH(DMI_BIOS_VENDOR, "Hewlett-Packard"),
-	DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv7") }, NULL},
-	{},
-};
-
 static acpi_status
 early_init_pdc(acpi_handle handle, u32 lvl, void *context, void **rv)
 {
@@ -396,13 +366,6 @@ void __init acpi_early_processor_set_pdc(void)
 	 */
 	dmi_check_system(processor_idle_dmi_table);
 
-	/*
-	 * Allow systems to opt-in to early _PDC evaluation.
-	 */
-	dmi_check_system(early_pdc_optin_table);
-	if (!early_pdc_optin)
-		return;
-
 	acpi_walk_namespace(ACPI_TYPE_PROCESSOR, ACPI_ROOT_OBJECT,
 			    ACPI_UINT32_MAX,
 			    early_init_pdc, NULL, NULL, NULL);


  parent reply	other threads:[~2010-02-22 19:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-22 19:11 [PATCH v2 00/12] ACPI: processor driver vs. core Alex Chiang
2010-02-22 19:11 ` [PATCH v2 01/12] ACPI: processor: mv processor_core.c processor_driver.c Alex Chiang
2010-02-22 19:11 ` [PATCH v2 02/12] ACPI: processor: mv processor_pdc.c processor_core.c Alex Chiang
2010-02-22 19:11 ` [PATCH v2 03/12] ACPI: processor: export acpi_get_cpuid() Alex Chiang
2010-02-22 19:11 ` [PATCH v2 04/12] ACPI: processor: move acpi_get_cpuid into processor_core.c Alex Chiang
2010-02-22 19:11 ` [PATCH v2 05/12] ACPI: processor: add internal processor_physically_present() Alex Chiang
2010-02-22 19:11 ` Alex Chiang [this message]
2010-02-22 19:11 ` [PATCH v2 07/12] ACPI: processor: driver doesn't need to evaluate _PDC Alex Chiang
2010-02-22 19:11 ` [PATCH v2 08/12] ACPI: processor: refactor internal map_lapic_id() Alex Chiang
2010-02-22 19:11 ` [PATCH v2 09/12] ACPI: processor: refactor internal map_x2apic_id() Alex Chiang
2010-02-22 19:11 ` [PATCH v2 10/12] ACPI: processor: refactor internal map_lsapic_id() Alex Chiang
2010-02-22 19:12 ` [PATCH v2 11/12] ACPI: processor: push file static MADT pointer into internal map_madt_entry() Alex Chiang
2010-02-22 19:12 ` [PATCH v2 12/12] ACPI: processor core: style and sparse cleanups Alex Chiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100222191134.19752.43236.stgit@bob.kio \
    --to=achiang@hp.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®